From 6816921f471506ab2235e82fe3bf54f84df46550 Mon Sep 17 00:00:00 2001
From: fusionate <nate@fusionpbx.com>
Date: Wed, 17 May 2023 07:02:45 +0000
Subject: [PATCH] Extension - Edit: Updates for PHP 8.1

---
 app/extensions/extension_edit.php | 190 ++++++++++++++----------------
 1 file changed, 88 insertions(+), 102 deletions(-)

diff --git a/app/extensions/extension_edit.php b/app/extensions/extension_edit.php
index 2071cb550e..4a0e6f2d49 100644
--- a/app/extensions/extension_edit.php
+++ b/app/extensions/extension_edit.php
@@ -47,7 +47,7 @@
 	$text = $language->get();
 
 //set the action as an add or an update
-	if (is_uuid($_REQUEST["id"])) {
+	if (!empty($_REQUEST["id"]) && is_uuid($_REQUEST["id"])) {
 		$action = "update";
 		$extension_uuid = $_REQUEST["id"];
 		$page = $_REQUEST['page'];
@@ -89,8 +89,8 @@
 				$extension = $database->select($sql, $parameters, 'column');
 				unset($sql, $parameters);
 			}
-			$number_alias = $_POST["number_alias"];
-			$password = $_POST["password"];
+			$number_alias = $_POST["number_alias"] ?? null;
+			$password = $_POST["password"] ?? null;
 
 			//server verification on account code
 			$accountcode = $_POST["accountcode"];
@@ -111,13 +111,13 @@
 			//$device_uuid = $_POST["device_uuid"];
 			//$device_line = $_POST["device_line"];
 			$voicemail_password = $_POST["voicemail_password"];
-			$voicemail_enabled = $_POST["voicemail_enabled"] ?: 'false';
+			$voicemail_enabled = $_POST["voicemail_enabled"] ?? 'false';
 			$voicemail_mail_to = $_POST["voicemail_mail_to"];
 			$voicemail_transcription_enabled = $_POST["voicemail_transcription_enabled"];
 			$voicemail_file = $_POST["voicemail_file"];
 			$voicemail_local_after_email = $_POST["voicemail_local_after_email"];
 			$user_context = $_POST["user_context"];
-			$range = $_POST["range"];
+			$range = $_POST["range"] ?? null;
 			$missed_call_app = $_POST["missed_call_app"];
 			$missed_call_data = $_POST["missed_call_data"];
 			$toll_allow = $_POST["toll_allow"];
@@ -130,13 +130,13 @@
 			$cidr = $_POST["cidr"];
 			$sip_force_contact = $_POST["sip_force_contact"];
 			$sip_force_expires = $_POST["sip_force_expires"];
-			$nibble_account = $_POST["nibble_account"];
+			$nibble_account = $_POST["nibble_account"] ?? null;
 			$mwi_account = $_POST["mwi_account"];
 			$sip_bypass_media = $_POST["sip_bypass_media"];
 			$absolute_codec_string = $_POST["absolute_codec_string"];
 			$force_ping = $_POST["force_ping"];
 			$dial_string = $_POST["dial_string"];
-			$enabled = $_POST["enabled"] ?: 'false';
+			$enabled = $_POST["enabled"] ?? 'false';
 			$description = $_POST["description"];
 
 			//outbound caller id number - only allow numeric and +
@@ -171,7 +171,7 @@
 			$toll_allow = str_replace(',',':', $toll_allow);
 
 		//set assigned user variables
-			$user_uuid = $_POST["extension_users"][0]["user_uuid"];
+			$user_uuid = $_POST["extension_users"][0]["user_uuid"] ?? null;
 
 		//device provisioning variables
 			if (is_array($_POST["devices"]) && @sizeof($_POST["devices"]) != 0) {
@@ -186,7 +186,7 @@
 			}
 
 		//get or set the device_uuid
-			if (is_array($device_mac_addresses) && @sizeof($device_mac_addresses) != 0) {
+			if (!empty($device_mac_addresses) && is_array($device_mac_addresses) && @sizeof($device_mac_addresses) != 0) {
 				foreach ($device_mac_addresses as $d => $device_mac_address) {
 					$device_mac_address = strtolower($device_mac_address);
 					$device_mac_address = preg_replace('#[^a-fA-F0-9./]#', '', $device_mac_address);
@@ -220,14 +220,14 @@
 					}
 					unset($sql, $parameters);
 
-					$device_uuids[$d] = is_uuid($device_uuid) ? $device_uuid : uuid();
+					$device_uuids[$d] = !empty($device_uuid) && is_uuid($device_uuid) ? $device_uuid : uuid();
 				}
 			}
 
 	}
 
 //delete the user from the v_extension_users
-	if ($_REQUEST["delete_type"] == "user" && is_uuid($_REQUEST["delete_uuid"]) && permission_exists("extension_delete")) {
+	if (!empty($_REQUEST["delete_type"]) && $_REQUEST["delete_type"] == "user" && is_uuid($_REQUEST["delete_uuid"]) && permission_exists("extension_delete")) {
 		//set the variables
 			$extension_uuid = $_REQUEST["id"];
 			$user_uuid = $_REQUEST["delete_uuid"];
@@ -257,7 +257,7 @@
 
 //delete the line from the v_device_lines
 	if (is_dir($_SERVER["DOCUMENT_ROOT"].PROJECT_PATH.'/app/devices')) {
-		if ($_REQUEST["delete_type"] == "device_line" && is_uuid($_REQUEST["delete_uuid"]) && permission_exists("extension_delete")) {
+		if (!empty($_REQUEST["delete_type"]) && $_REQUEST["delete_type"] == "device_line" && is_uuid($_REQUEST["delete_uuid"]) && permission_exists("extension_delete")) {
 			//set the variables
 				$device_line_uuid = $_REQUEST["delete_uuid"];
 
@@ -324,13 +324,13 @@
 
 		//prevent users from bypassing extension limit by using range
 			if ($_SESSION['limit']['extensions']['numeric'] != '') {
-				if ($total_extensions + $range > $_SESSION['limit']['extensions']['numeric']){
+				if (isset($total_extensions) && ($total_extensions ?? 0) + $range > $_SESSION['limit']['extensions']['numeric']) {
 					$range = $_SESSION['limit']['extensions']['numeric'] - $total_extensions;
 				}
 			}
 
 		//add or update the database
-			if ($_POST["persistformvar"] != "true") {
+			if (empty($_POST["persistformvar"]) || $_POST["persistformvar"] != "true") {
 
 				//prep missed call values for db insert/update
 					switch ($missed_call_app) {
@@ -685,7 +685,7 @@
 												$array["voicemails"][$i]["voicemail_local_after_email"] = $voicemail_local_after_email;
 											}
 											$array["voicemails"][$i]["voicemail_transcription_enabled"] = $voicemail_transcription_enabled;
-											$array["voicemails"][$i]["voicemail_tutorial"] = $voicemail_tutorial;
+											$array["voicemails"][$i]["voicemail_tutorial"] = $voicemail_tutorial ?? null;
 											$array["voicemails"][$i]["voicemail_enabled"] = $voicemail_enabled;
 											$array["voicemails"][$i]["voicemail_description"] = $description;
 
@@ -764,7 +764,7 @@
 					if (permission_exists('extension_add') || permission_exists('extension_edit')) {
 
 						//synchronize configuration
-							if (is_writable($_SESSION['switch']['extensions']['dir'])) {
+							if (!empty($_SESSION['switch']['extensions']['dir']) && is_writable($_SESSION['switch']['extensions']['dir'])) {
 								require_once "app/extensions/resources/classes/extension.php";
 								$ext = new extension;
 								$ext->xml();
@@ -819,7 +819,7 @@
 	}
 
 //pre-populate the form
-	if (count($_GET) > 0 && $_POST["persistformvar"] != "true") {
+	if (count($_GET) > 0 && (empty($_POST["persistformvar"]) || $_POST["persistformvar"] != "true")) {
 		$extension_uuid = $_GET["id"];
 		$sql = "select * from v_extensions ";
 		$sql .= "where extension_uuid = :extension_uuid ";
@@ -884,8 +884,8 @@
 			$database = new database;
 			$row = $database->select($sql, $parameters, 'row');
 			if (is_array($row) && @sizeof($row) != 0) {
-				$voicemail_password = str_replace("#", "", $row["voicemail_password"]);
-				$voicemail_mail_to = str_replace(" ", "", $row["voicemail_mail_to"]);
+				$voicemail_password = str_replace("#", "", $row["voicemail_password"] ?? '');
+				$voicemail_mail_to = str_replace(" ", "", $row["voicemail_mail_to"] ?? '');
 				$voicemail_transcription_enabled = $row["voicemail_transcription_enabled"];
 				$voicemail_tutorial = $row["voicemail_tutorial"];
 				$voicemail_file = $row["voicemail_file"];
@@ -908,8 +908,8 @@
 	$sql .= "and l.domain_uuid = :domain_uuid ";
 	$sql .= "and l.device_uuid = d.device_uuid ";
 	$sql .= "order by l.line_number, d.device_mac_address asc ";
-	$parameters['user_id_1'] = $extension;
-	$parameters['user_id_2'] = $number_alias;
+	$parameters['user_id_1'] = $extension ?? null;
+	$parameters['user_id_2'] = $number_alias ?? null;
 	$parameters['domain_uuid'] = $domain_uuid;
 	$database = new database;
 	$device_lines = $database->select($sql, $parameters, 'all');
@@ -934,7 +934,7 @@
 	unset($sql);
 
 //get assigned users
-	if (is_uuid($extension_uuid)) {
+	if (!empty($extension_uuid) && is_uuid($extension_uuid)) {
 		$sql = "select u.username, e.user_uuid ";
 		$sql .= "from v_extension_users as e, v_users as u ";
 		$sql .= "where e.user_uuid = u.user_uuid  ";
@@ -957,7 +957,7 @@
 //get the users
 	$sql = "select * from v_users ";
 	$sql .= "where domain_uuid = :domain_uuid ";
-	if (is_array($assigned_user_uuids) && @sizeof($assigned_user_uuids) != 0) {
+	if (!empty($assigned_user_uuids) && is_array($assigned_user_uuids) && @sizeof($assigned_user_uuids) != 0) {
 		foreach ($assigned_user_uuids as $index => $assigned_user_uuid) {
 			$sql .= "and user_uuid <> :user_uuid_".$index." ";
 			$parameters['user_uuid_'.$index] = $assigned_user_uuid;
@@ -994,11 +994,11 @@
 	}
 
 //change toll allow delimiter
-	$toll_allow = str_replace(':',',', $toll_allow);
+	$toll_allow = str_replace(':',',', $toll_allow ?? '');
 
 //set the defaults
 	if (empty($user_context)) { $user_context = $_SESSION['domain_name']; }
-	if (empty($max_registrations)) { $max_registrations = $_SESSION['extension']['max_registrations']['numeric']; }
+	if (empty($max_registrations)) { $max_registrations = $_SESSION['extension']['max_registrations']['numeric'] ?? ''; }
 	if (empty($accountcode)) { $accountcode = get_accountcode(); }
 	if (empty($limit_max)) { $limit_max = '5'; }
 	if (empty($limit_destination)) { $limit_destination = '!USER_BUSY'; }
@@ -1042,13 +1042,13 @@
 	echo "	var new_ext = prompt('".$text['message-extension']."');\n";
 	echo "	if (new_ext != null) {\n";
 	echo "		if (!isNaN(new_ext)) {\n";
-	echo "			document.location.href='extension_copy.php?id=".escape($extension_uuid)."&ext=' + new_ext".(is_numeric($page) ? " + '&page=".$page."'" : null).";\n";
+	echo "			document.location.href='extension_copy.php?id=".escape($extension_uuid ?? '')."&ext=' + new_ext".(!empty($page) && is_numeric($page) ? " + '&page=".$page."'" : null).";\n";
 	echo "		}\n";
 	echo "		else {\n";
 	echo "			var new_number_alias = prompt('".$text['message-number_alias']."');\n";
 	echo "			if (new_number_alias != null) {\n";
 	echo "				if (!isNaN(new_number_alias)) {\n";
-	echo "					document.location.href='extension_copy.php?id=".escape($extension_uuid)."&ext=' + new_ext + '&alias=' + new_number_alias".(is_numeric($page) ? " + '&page=".$page."'" : null).";\n";
+	echo "					document.location.href='extension_copy.php?id=".escape($extension_uuid ?? '')."&ext=' + new_ext + '&alias=' + new_number_alias".(!empty($page) && is_numeric($page) ? " + '&page=".$page."'" : null).";\n";
 	echo "				}\n";
 	echo "			}\n";
 	echo "		}\n";
@@ -1068,15 +1068,15 @@
 	}
 	echo 	"</div>\n";
 	echo "	<div class='actions'>\n";
-	echo button::create(['type'=>'button','label'=>$text['button-back'],'icon'=>$_SESSION['theme']['button_icon_back'],'id'=>'btn_back','link'=>'extensions.php'.(is_numeric($page) ? '?page='.$page : null)]);
+	echo button::create(['type'=>'button','label'=>$text['button-back'],'icon'=>$_SESSION['theme']['button_icon_back'],'id'=>'btn_back','link'=>'extensions.php'.(isset($page) && is_numeric($page) ? '?page='.$page : null)]);
 	if ($action == 'update') {
 		$button_margin = 'margin-left: 15px;';
 		if (permission_exists('xml_cdr_view')) {
-			echo button::create(['type'=>'button','label'=>$text['button-cdr'],'icon'=>'info-circle','style'=>$button_margin,'link'=>'../xml_cdr/xml_cdr.php?extension_uuid='.urlencode($extension_uuid)]);
+			echo button::create(['type'=>'button','label'=>$text['button-cdr'],'icon'=>'info-circle','style'=>($button_margin ?? ''),'link'=>'../xml_cdr/xml_cdr.php?extension_uuid='.urlencode($extension_uuid)]);
 			unset($button_margin);
 		}
 		if (permission_exists('follow_me') || permission_exists('call_forward') || permission_exists('do_not_disturb')) {
-			echo button::create(['type'=>'button','label'=>$text['button-call_forward'],'icon'=>'project-diagram','style'=>$button_margin,'link'=>'../call_forward/call_forward_edit.php?id='.urlencode($extension_uuid)]);
+			echo button::create(['type'=>'button','label'=>$text['button-call_forward'],'icon'=>'project-diagram','style'=>($button_margin ?? ''),'link'=>'../call_forward/call_forward_edit.php?id='.urlencode($extension_uuid)]);
 			unset($button_margin);
 		}
 		if (permission_exists('extension_setting_view')) {
@@ -1100,7 +1100,7 @@
 	echo "</td>\n";
 	echo "<td width='70%' class='vtable' align='left'>\n";
 	if ($action == "add" || permission_exists("extension_extension")) {
-		echo "    <input class='formfld' type='text' name='extension' autocomplete='new-password' maxlength='255' value=\"".escape($extension)."\" required='required'>\n";
+		echo "    <input class='formfld' type='text' name='extension' autocomplete='new-password' maxlength='255' value=\"".escape($extension ?? '')."\" required='required'>\n";
 		echo "    <input type='text' style='display: none;' disabled='disabled'>\n"; //help defeat browser auto-fill
 		echo "<br />\n";
 		echo $text['description-extension']."\n";
@@ -1117,7 +1117,7 @@
 		echo "    ".$text['label-number_alias']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='number' name='number_alias' autocomplete='new-password' maxlength='255' min='0' step='1' value=\"".escape($number_alias)."\">\n";
+		echo "    <input class='formfld' type='number' name='number_alias' autocomplete='new-password' maxlength='255' min='0' step='1' value=\"".escape($number_alias ?? '')."\">\n";
 		echo "    <input type='text' style='display: none;' disabled='disabled'>\n"; //help defeat browser auto-fill
 		echo "<br />\n";
 		echo $text['description-number_alias']."\n";
@@ -1132,7 +1132,7 @@
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <input type='password' style='display: none;' disabled='disabled'>\n"; //help defeat browser auto-fill
-		echo "    <input class='formfld' type='password' name='password' id='password' autocomplete='new-password' onmouseover=\"this.type='text';\" onfocus=\"this.type='text';\" onmouseout=\"if (!$(this).is(':focus')) { this.type='password'; }\" onblur=\"this.type='password';\" maxlength='50' value=\"".escape($password)."\">\n";
+		echo "    <input class='formfld' type='password' name='password' id='password' autocomplete='new-password' onmouseover=\"this.type='text';\" onfocus=\"this.type='text';\" onmouseout=\"if (!$(this).is(':focus')) { this.type='password'; }\" onblur=\"this.type='password';\" maxlength='50' value=\"".escape($password ?? '')."\">\n";
 		echo "    <br />\n";
 		echo "    ".$text['description-password']."\n";
 		echo "</td>\n";
@@ -1184,7 +1184,7 @@
 		echo "	<tr>";
 		echo "		<td class='vncell' valign='top'>".($action == "update" ? $text['label-users'] : $text['label-user'])."</td>";
 		echo "		<td class='vtable'>";
-		if (is_array($assigned_users) && @sizeof($assigned_users) != 0 && $action == "update") {
+		if (!empty($assigned_users) && is_array($assigned_users) && @sizeof($assigned_users) != 0 && $action == "update") {
 			echo "		<table width='30%'>\n";
 			foreach($assigned_users as $field) {
 				echo "		<tr>\n";
@@ -1222,7 +1222,7 @@
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <input type='password' style='display: none;' disabled='disabled'>\n"; //help defeat browser auto-fill
-		echo "    <input class='formfld' type='password' name='voicemail_password' id='voicemail_password' autocomplete='new-password' onmouseover=\"this.type='text';\" onfocus=\"this.type='text';\" onmouseout=\"if (!$(this).is(':focus')) { this.type='password'; }\" onblur=\"this.type='password';\" maxlength='255' value='".escape($voicemail_password)."'>\n";
+		echo "    <input class='formfld' type='password' name='voicemail_password' id='voicemail_password' autocomplete='new-password' onmouseover=\"this.type='text';\" onfocus=\"this.type='text';\" onmouseout=\"if (!$(this).is(':focus')) { this.type='password'; }\" onblur=\"this.type='password';\" maxlength='255' value='".escape($voicemail_password ?? '')."'>\n";
 		echo "    <br />\n";
 		echo "    ".$text['description-voicemail_password']."\n";
 		echo "</td>\n";
@@ -1284,7 +1284,7 @@
 			for ($d = 0; $d <= 4; $d++) {
 				echo "		<tr>\n";
 				echo "		<td ".($action == 'edit' ? "class='vtable'" : null).">";
-				echo "			<select id='line_number' name='devices[".$d."][line_number]' class='formfld' style='width: auto;' onchange=\"".escape($onchange)."\">\n";
+				echo "			<select id='line_number' name='devices[".$d."][line_number]' class='formfld' style='width: auto;' onchange=\"".escape($onchange ?? '')."\">\n";
 				echo "			<option value=''></option>\n";
 				for ($n = 1; $n <=99; $n++) {
 					echo "		<option value='".escape($n)."'>".escape($n)."</option>\n";
@@ -1358,7 +1358,7 @@
 						if (is_dir($template_dir.'/'.$row["name"])) {
 							$templates = scandir($template_dir.'/'.$row["name"]);
 							foreach($templates as $dir) {
-								if ($file != "." && $dir != ".." && $dir[0] != '.' && is_dir($template_dir.'/'.$row["name"].'/'.$dir)) {
+								if (!empty($file) && $file != "." && !empty($dir) && $dir != ".." && $dir[0] != '.' && !empty($template_dir) && is_dir($template_dir.'/'.$row["name"].'/'.$dir)) {
 									$selected = $device_template == $row["name"]."/".$dir ? "selected='selected'" : null;
 									echo "				<option value='".escape($row["name"])."/".escape($dir)."' ".$selected.">".escape($row["name"])."/".escape($dir)."</option>\n";
 								}
@@ -1393,7 +1393,7 @@
 		echo "    ".$text['label-effective_caller_id_name']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='effective_caller_id_name' maxlength='255' value=\"".escape($effective_caller_id_name)."\">\n";
+		echo "    <input class='formfld' type='text' name='effective_caller_id_name' maxlength='255' value=\"".escape($effective_caller_id_name ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-effective_caller_id_name']."\n";
 		echo "</td>\n";
@@ -1406,7 +1406,7 @@
 		echo "    ".$text['label-effective_caller_id_number']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='effective_caller_id_number' min='0' step='1' maxlength='255' value=\"".escape($effective_caller_id_number)."\">\n";
+		echo "    <input class='formfld' type='text' name='effective_caller_id_number' min='0' step='1' maxlength='255' value=\"".escape($effective_caller_id_number ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-effective_caller_id_number']."\n";
 		echo "</td>\n";
@@ -1443,11 +1443,11 @@
 				echo $text['description-outbound_caller_id_name-select']."\n";
 			}
 			else {
-				echo "	<input type=\"button\" class=\"btn\" name=\"\" alt=\"".$text['button-add']."\" onclick=\"window.location='".PROJECT_PATH."/app/destinations/destinations.php'\" value='".$text['button-add']."'>\n";
+				echo "	<input type='button' class='btn' name='' alt=\"".$text['button-add']."\" onclick=\"window.location='".PROJECT_PATH."/app/destinations/destinations.php'\" value='".$text['button-add']."'>\n";
 			}
 		}
 		else {
-			echo "    <input class='formfld' type='text' name='outbound_caller_id_name' maxlength='255' value=\"".escape($outbound_caller_id_name)."\">\n";
+			echo "    <input class='formfld' type='text' name='outbound_caller_id_name' maxlength='255' value=\"".escape($outbound_caller_id_name ?? '')."\">\n";
 			echo "<br />\n";
 			echo $text['description-outbound_caller_id_name-custom']."\n";
 		}
@@ -1484,11 +1484,11 @@
 				echo $text['description-outbound_caller_id_number-select']."\n";
 			}
 			else {
-				echo "	<input type=\"submit\" class=\"btn\" name=\"\" alt=\"".$text['button-add']."\" onclick=\"window.location='".PROJECT_PATH."/app/destinations/destinations.php'\" value='".$text['button-add']."'>\n";
+				echo "	<input type='submit' class='btn' name='' alt=\"".$text['button-add']."\" onclick=\"window.location='".PROJECT_PATH."/app/destinations/destinations.php'\" value='".$text['button-add']."'>\n";
 			}
 		}
 		else {
-			echo "    <input class='formfld' type='text' name='outbound_caller_id_number' maxlength='255' min='0' step='1' value=\"".escape($outbound_caller_id_number)."\">\n";
+			echo "    <input class='formfld' type='text' name='outbound_caller_id_number' maxlength='255' min='0' step='1' value=\"".escape($outbound_caller_id_number ?? '')."\">\n";
 			echo "<br />\n";
 			echo $text['description-outbound_caller_id_number-custom']."\n";
 		}
@@ -1527,7 +1527,7 @@
 			}
 		}
 		else {
-			echo "	<input class='formfld' type='text' name='emergency_caller_id_name' maxlength='255' value=\"".escape($emergency_caller_id_name)."\">\n";
+			echo "	<input class='formfld' type='text' name='emergency_caller_id_name' maxlength='255' value=\"".escape($emergency_caller_id_name ?? '')."\">\n";
 		}
 		echo "<br />\n";
 		if (permission_exists('outbound_caller_id_select') && count($destinations) > 0) {
@@ -1573,7 +1573,7 @@
 			}
 		}
 		else {
-			echo "    <input class='formfld' type='text' name='emergency_caller_id_number' maxlength='255' min='0' step='1' value=\"".escape($emergency_caller_id_number)."\">\n";
+			echo "    <input class='formfld' type='text' name='emergency_caller_id_number' maxlength='255' min='0' step='1' value=\"".escape($emergency_caller_id_number ?? '')."\">\n";
 		}
 		echo "<br />\n";
 		if (permission_exists('emergency_caller_id_select') && count($emergency_destinations) > 0){
@@ -1595,8 +1595,8 @@
 		echo "    ".$text['label-directory_full_name']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='directory_first_name' maxlength='255' value=\"".escape($directory_first_name)."\">\n";
-		echo "    <input class='formfld' type='text' name='directory_last_name' maxlength='255' value=\"".escape($directory_last_name)."\">\n";
+		echo "    <input class='formfld' type='text' name='directory_first_name' maxlength='255' value=\"".escape($directory_first_name ?? '')."\">\n";
+		echo "    <input class='formfld' type='text' name='directory_last_name' maxlength='255' value=\"".escape($directory_last_name ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-directory_full_name']."\n";
 		echo "</td>\n";
@@ -1608,13 +1608,13 @@
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <select class='formfld' name='directory_visible'>\n";
-		if ($directory_visible == "true") {
+		if (!empty($directory_visible) && $directory_visible == "true") {
 			echo "    <option value='true' selected='selected'>".$text['label-true']."</option>\n";
 		}
 		else {
 			echo "    <option value='true'>".$text['label-true']."</option>\n";
 		}
-		if ($directory_visible == "false") {
+		if (!empty($directory_visible) && $directory_visible == "false") {
 			echo "    <option value='false' selected >".$text['label-false']."</option>\n";
 		}
 		else {
@@ -1632,13 +1632,13 @@
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <select class='formfld' name='directory_exten_visible'>\n";
-		if ($directory_exten_visible == "true") {
+		if (!empty($directory_exten_visible) && $directory_exten_visible == "true") {
 			echo "    <option value='true' selected='selected'>".$text['label-true']."</option>\n";
 		}
 		else {
 			echo "    <option value='true'>".$text['label-true']."</option>\n";
 		}
-		if ($directory_exten_visible == "false") {
+		if (!empty($directory_exten_visible) && $directory_exten_visible == "false") {
 			echo "    <option value='false' selected >".$text['label-false']."</option>\n";
 		}
 		else {
@@ -1657,7 +1657,7 @@
 		echo "    ".$text['label-max_registrations']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='max_registrations' maxlength='255' value=\"".escape($max_registrations)."\">\n";
+		echo "    <input class='formfld' type='text' name='max_registrations' maxlength='255' value=\"".escape($max_registrations ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-max_registrations']."\n";
 		echo "</td>\n";
@@ -1670,7 +1670,7 @@
 		echo "    ".$text['label-limit_max']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='limit_max' maxlength='255' value=\"".escape($limit_max)."\">\n";
+		echo "    <input class='formfld' type='text' name='limit_max' maxlength='255' value=\"".escape($limit_max ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-limit_max']."\n";
 		echo "</td>\n";
@@ -1681,7 +1681,7 @@
 		echo "    ".$text['label-limit_destination']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='limit_destination' maxlength='255' value=\"".escape($limit_destination)."\">\n";
+		echo "    <input class='formfld' type='text' name='limit_destination' maxlength='255' value=\"".escape($limit_destination ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-limit_destination']."\n";
 		echo "</td>\n";
@@ -1718,7 +1718,7 @@
 		echo "    ".$text['label-voicemail_mail_to']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='voicemail_mail_to' maxlength='255' value=\"".escape($voicemail_mail_to)."\">\n";
+		echo "    <input class='formfld' type='text' name='voicemail_mail_to' maxlength='255' value=\"".escape($voicemail_mail_to ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-voicemail_mail_to']."\n";
 		echo "</td>\n";
@@ -1782,12 +1782,12 @@
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <select class='formfld' name='missed_call_app' id='missed_call_app' onchange=\"if (this.selectedIndex != 0) { document.getElementById('missed_call_data').style.display = ''; document.getElementById('missed_call_data').focus(); } else { document.getElementById('missed_call_data').style.display='none'; }\">\n";
 		echo "		<option value=''></option>\n";
-		echo "    	<option value='email' ".(($missed_call_app == "email" && $missed_call_data != '') ? "selected='selected'" : null).">".$text['label-email']."</option>\n";
+		echo "    	<option value='email' ".((!empty($missed_call_app) && $missed_call_app == "email" && !empty($missed_call_data) && $missed_call_data != '') ? "selected='selected'" : null).">".$text['label-email']."</option>\n";
 		//echo "    	<option value='text' ".(($missed_call_app == "text" && $missed_call_data != '') ? "selected='selected'" : null).">".$text['label-text']."</option>\n";
 		//echo "    	<option value='url' ".(($missed_call_app == "url" && $missed_call_data != '') ? "selected='selected'" : null).">".$text['label-url']."</option>\n";
 		echo "    </select>\n";
-		$missed_call_data = ($missed_call_app == 'text') ? format_phone($missed_call_data) : $missed_call_data;
-		echo "    <input class='formfld' type='text' name='missed_call_data' id='missed_call_data' maxlength='255' value=\"".escape($missed_call_data)."\" style='min-width: 200px; width: 200px; ".(($missed_call_app == '' || $missed_call_data == '') ? "display: none;" : null)."'>\n";
+		$missed_call_data = !empty($missed_call_app) && $missed_call_app == 'text' ? format_phone($missed_call_data ?? '') : $missed_call_data ?? '';
+		echo "    <input class='formfld' type='text' name='missed_call_data' id='missed_call_data' maxlength='255' value=\"".escape($missed_call_data ?? '')."\" style='min-width: 200px; width: 200px; ".((empty($missed_call_app) || empty($missed_call_data)) ? "display: none;" : null)."'>\n";
 		echo "<br />\n";
 		echo $text['description-missed_call']."\n";
 		echo "</td>\n";
@@ -1800,7 +1800,7 @@
 		echo "    ".$text['label-toll_allow']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		if (is_array($_SESSION['toll allow']['name'])) {
+		if (!empty($_SESSION['toll allow']['name']) && is_array($_SESSION['toll allow']['name'])) {
 			echo "	<select class='formfld' name='toll_allow' id='toll_allow'>\n";
 			echo "		<option value=''></option>\n";
 			foreach ($_SESSION['toll allow']['name'] as $name) {
@@ -1814,7 +1814,7 @@
 			echo "	</select>\n";
 		}
 		else {
-			echo "    <input class='formfld' type='text' name='toll_allow' maxlength='255' value=\"".escape($toll_allow)."\">\n";
+			echo "    <input class='formfld' type='text' name='toll_allow' maxlength='255' value=\"".escape($toll_allow ?? '')."\">\n";
 		}
 		echo "<br />\n";
 		echo $text['description-toll_allow']."\n";
@@ -1827,7 +1827,7 @@
 	echo "	".$text['label-call_timeout']."\n";
 	echo "</td>\n";
 	echo "<td class='vtable' align='left'>\n";
-	echo "	<input class='formfld' type='number' name='call_timeout' maxlength='255' min='1' step='1' value=\"".escape($call_timeout)."\">\n";
+	echo "	<input class='formfld' type='number' name='call_timeout' maxlength='255' min='1' step='1' value=\"".escape($call_timeout ?? '')."\">\n";
 	echo "<br />\n";
 	echo $text['description-call_timeout']."\n";
 	echo "</td>\n";
@@ -1839,7 +1839,7 @@
 		echo "	".$text['label-call_group']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		if (is_array($_SESSION['call group']['name'])) {
+		if (!empty($_SESSION['call group']['name']) && is_array($_SESSION['call group']['name'])) {
 			echo "	<select class='formfld' name='call_group'>\n";
 			echo "		<option value=''></option>\n";
 			foreach ($_SESSION['call group']['name'] as $name) {
@@ -1851,8 +1851,9 @@
 				}
 			}
 			echo "	</select>\n";
-		} else {
-			echo "	<input class='formfld' type='text' name='call_group' maxlength='255' value=\"".escape($call_group)."\">\n";
+		}
+		else {
+			echo "	<input class='formfld' type='text' name='call_group' maxlength='255' value=\"".escape($call_group ?? '')."\">\n";
 		}
 		echo "<br />\n";
 		echo $text['description-call_group']."\n";
@@ -1934,7 +1935,7 @@
 		require_once "app/music_on_hold/resources/classes/switch_music_on_hold.php";
 		$options = '';
 		$moh = new switch_music_on_hold;
-		echo $moh->select('hold_music', $hold_music, $options);
+		echo $moh->select('hold_music', $hold_music ?? '', $options);
 		echo "	<br />\n";
 		echo $text['description-hold_music']."\n";
 		echo "</td>\n";
@@ -1969,7 +1970,7 @@
 		echo "    ".$text['label-user_context']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='user_context' maxlength='255' value=\"".escape($user_context)."\" required='required'>\n";
+		echo "    <input class='formfld' type='text' name='user_context' maxlength='255' value=\"".escape($user_context ?? '')."\" required='required'>\n";
 		echo "<br />\n";
 		echo $text['description-user_context']."\n";
 		echo "</td>\n";
@@ -2001,7 +2002,7 @@
 		echo "    ".$text['label-auth_acl']."\n";
 		echo "</td>\n";
 		echo "<td width=\"70%\" class='vtable' align='left'>\n";
-		echo "   <input class='formfld' type='text' name='auth_acl' maxlength='255' value=\"".escape($auth_acl)."\">\n";
+		echo "   <input class='formfld' type='text' name='auth_acl' maxlength='255' value=\"".escape($auth_acl ?? '')."\">\n";
 		echo "   <br />\n";
 		echo $text['description-auth_acl']."\n";
 		echo "</td>\n";
@@ -2013,7 +2014,7 @@
 			echo "    ".$text['label-cidr']."\n";
 			echo "</td>\n";
 			echo "<td class='vtable' align='left'>\n";
-			echo "    <input class='formfld' type='text' name='cidr' maxlength='255' value=\"".escape($cidr)."\">\n";
+			echo "    <input class='formfld' type='text' name='cidr' maxlength='255' value=\"".escape($cidr ?? '')."\">\n";
 			echo "<br />\n";
 			echo $text['description-cidr']."\n";
 			echo "</td>\n";
@@ -2027,14 +2028,14 @@
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <select class='formfld' name='sip_force_contact'>\n";
 		echo "    <option value=''></option>\n";
-		switch ($sip_force_contact) {
+		switch ($sip_force_contact ?? null) {
 			case "NDLB-connectile-dysfunction": 		$selected[1] = "selected='selected'"; 	break;
 			case "NDLB-connectile-dysfunction-2.0": 	$selected[2] = "selected='selected'"; 	break;
 			case "NDLB-tls-connectile-dysfunction": 	$selected[3] = "selected='selected'"; 	break;
 		}
-		echo "    <option value='NDLB-connectile-dysfunction' ".$selected[1].">".$text['label-rewrite_contact_ip_and_port']."</option>\n";
-		echo "    <option value='NDLB-connectile-dysfunction-2.0' ".$selected[2].">".$text['label-rewrite_contact_ip_and_port_2']."</option>\n";
-		echo "    <option value='NDLB-tls-connectile-dysfunction' ".$selected[3].">".$text['label-rewrite_tls_contact_port']."</option>\n";
+		echo "    <option value='NDLB-connectile-dysfunction' ".($selected[1] ?? '').">".$text['label-rewrite_contact_ip_and_port']."</option>\n";
+		echo "    <option value='NDLB-connectile-dysfunction-2.0' ".($selected[2] ?? '').">".$text['label-rewrite_contact_ip_and_port_2']."</option>\n";
+		echo "    <option value='NDLB-tls-connectile-dysfunction' ".($selected[3] ?? '').">".$text['label-rewrite_tls_contact_port']."</option>\n";
 		unset($selected);
 		echo "    </select>\n";
 		echo "<br />\n";
@@ -2047,7 +2048,7 @@
 		echo "    ".$text['label-sip_force_expires']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='number' name='sip_force_expires' maxlength='255' min='1' step='1' value=\"".escape($sip_force_expires)."\">\n";
+		echo "    <input class='formfld' type='number' name='sip_force_expires' maxlength='255' min='1' step='1' value=\"".escape($sip_force_expires ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-sip_force_expires']."\n";
 		echo "</td>\n";
@@ -2059,7 +2060,7 @@
 			echo "    ".$text['label-nibble_account']."\n";
 			echo "</td>\n";
 			echo "<td class='vtable' align='left'>\n";
-			echo "    <input class='formfld' type='text' name='nibble_account' maxlength='255' value=\"".escape($nibble_account)."\">\n";
+			echo "    <input class='formfld' type='text' name='nibble_account' maxlength='255' value=\"".escape($nibble_account ?? '')."\">\n";
 			echo "<br />\n";
 			echo $text['description-nibble_account']."\n";
 			echo "</td>\n";
@@ -2071,7 +2072,7 @@
 		echo "    ".$text['label-mwi_account']."\n";
 		echo "</td>\n";
 		echo "<td class='vtable' align='left'>\n";
-		echo "    <input class='formfld' type='text' name='mwi_account' maxlength='255' value=\"".escape($mwi_account)."\">\n";
+		echo "    <input class='formfld' type='text' name='mwi_account' maxlength='255' value=\"".escape($mwi_account ?? '')."\">\n";
 		echo "<br />\n";
 		echo $text['description-mwi_account']."\n";
 		echo "</td>\n";
@@ -2084,14 +2085,14 @@
 		echo "<td class='vtable' align='left'>\n";
 		echo "    <select class='formfld' name='sip_bypass_media'>\n";
 		echo "    <option value=''></option>\n";
-		switch ($sip_bypass_media) {
+		switch ($sip_bypass_media ?? null) {
 			case "bypass-media" : 				$selected[1] = "selected='selected'"; 	break;
 			case "bypass-media-after-bridge" : 	$selected[2] = "selected='selected'"; 	break;
 			case "proxy-media" : 				$selected[3] = "selected='selected'"; 	break;
 		}
-		echo "    <option value='bypass-media' ".$selected[1].">".$text['label-bypass_media']."</option>\n";
-		echo "    <option value='bypass-media-after-bridge'".$selected[2].">".$text['label-bypass_media_after_bridge']."</option>\n";
-		echo "    <option value='proxy-media'".$selected[3].">".$text['label-proxy_media']."</option>\n";
+		echo "    <option value='bypass-media' ".($selected[1] ?? '').">".$text['label-bypass_media']."</option>\n";
+		echo "    <option value='bypass-media-after-bridge'".($selected[2] ?? '').">".$text['label-bypass_media_after_bridge']."</option>\n";
+		echo "    <option value='proxy-media'".($selected[3] ?? '').">".$text['label-proxy_media']."</option>\n";
 		unset($selected);
 		echo "    </select>\n";
 		echo "<br />\n";
@@ -2105,7 +2106,7 @@
 			echo "    ".$text['label-absolute_codec_string']."\n";
 			echo "</td>\n";
 			echo "<td class='vtable' align='left'>\n";
-			echo "    <input class='formfld' type='text' name='absolute_codec_string' maxlength='255' value=\"".escape($absolute_codec_string)."\">\n";
+			echo "    <input class='formfld' type='text' name='absolute_codec_string' maxlength='255' value=\"".escape($absolute_codec_string ?? '')."\">\n";
 			echo "<br />\n";
 			echo $text['description-absolute_codec_string']."\n";
 			echo "</td>\n";
@@ -2119,24 +2120,9 @@
 			echo "</td>\n";
 			echo "<td class='vtable' align='left'>\n";
 			echo "    <select class='formfld' name='force_ping'>\n";
-			if ($force_ping == "") {
-				echo "    <option value='' selected='selected'></option>\n";
-			}
-			else {
-				echo "    <option value=''></option>\n";
-			}
-			if ($force_ping == "true") {
-				echo "    <option value='true' selected='selected'>".$text['label-true']."</option>\n";
-			}
-			else {
-				echo "    <option value='true'>".$text['label-true']."</option>\n";
-			}
-			if ($force_ping == "false") {
-				echo "    <option value='false' selected='selected'>".$text['label-false']."</option>\n";
-			}
-			else {
-				echo "    <option value='false'>".$text['label-false']."</option>\n";
-			}
+			echo "    	<option value=''></option>\n";
+			echo "    	<option value='true' ".(!empty($force_ping) && $force_ping == "true" ? "selected='selected'" : null).">".$text['label-true']."</option>\n";
+			echo "    	<option value='false' ".(!empty($force_ping) && $force_ping == "false" ? "selected='selected'" : null).">".$text['label-false']."</option>\n";
 			echo "    </select>\n";
 			echo "<br />\n";
 			echo $text['description-force_ping']."\n";
@@ -2150,7 +2136,7 @@
 			echo "    ".$text['label-dial_string']."\n";
 			echo "</td>\n";
 			echo "<td class='vtable' align='left'>\n";
-			echo "    <input class='formfld' type='text' name='dial_string' maxlength='4096' value=\"".escape($dial_string)."\">\n";
+			echo "    <input class='formfld' type='text' name='dial_string' maxlength='4096' value=\"".escape($dial_string ?? '')."\">\n";
 			echo "<br />\n";
 			echo $text['description-dial_string']."\n";
 			echo "</td>\n";
@@ -2195,7 +2181,7 @@
 	echo "    ".$text['label-description']."\n";
 	echo "</td>\n";
 	echo "<td class='vtable' align='left'>\n";
-	echo "    <input type='text' class='formfld' name='description' value=\"".$description."\">\n";
+	echo "    <input type='text' class='formfld' name='description' value=\"".escape($description ?? '')."\">\n";
 	echo "<br />\n";
 	echo $text['description-description']."\n";
 	echo "</td>\n";
@@ -2204,7 +2190,7 @@
 	echo "</table>";
 	echo "<br><br>";
 
-	if (is_numeric($page)) {
+	if (isset($page) && is_numeric($page)) {
 		echo "<input type='hidden' name='page' value='".$page."'>\n";
 	}
 	if ($action == "update") {
@@ -2231,4 +2217,4 @@
 //include the footer
 	require_once "resources/footer.php";
 
-?>
+?>
\ No newline at end of file