From 5d37e2a570443636769e3c4259c4a920ce34e381 Mon Sep 17 00:00:00 2001 From: fusionate Date: Thu, 20 Mar 2025 17:20:14 -0600 Subject: [PATCH] Access Control - Edit: Add additional sanitization on dig value. --- app/access_controls/access_control_edit.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/access_controls/access_control_edit.php b/app/access_controls/access_control_edit.php index dfb644d9fe..43de3ee8bf 100644 --- a/app/access_controls/access_control_edit.php +++ b/app/access_controls/access_control_edit.php @@ -190,7 +190,7 @@ else { $digs[] = [ 'type'=>$row['node_type'], - 'value'=>$row['node_cidr'], + 'value'=>escapeshellarg(str_replace(' ', '', $row['node_cidr'])), 'description'=>$row['node_description'], ]; } @@ -202,7 +202,7 @@ //attempt digs if (!empty($digs) && is_array($digs)) { foreach ($digs as $dig) { - $response = shell_exec("dig +noall +answer ".escapeshellarg($dig['value'])." | awk '{ print $5 }'"); + $response = shell_exec("dig +noall +answer ".$dig['value']." | awk '{ print $5 }'"); if (!empty($response)) { $lines = explode("\n", $response); foreach ($lines as $l => $line) {