From 4e2003ec7a327259d736251b96120515ecd9b0d5 Mon Sep 17 00:00:00 2001
From: FusionPBX <markjcrane@gmail.com>
Date: Tue, 3 Jun 2025 11:50:39 -0600
Subject: [PATCH] Update a few Grandstream templates

---
 app/grandstream/app_config.php                | 34 ++++++++++++++++++-
 .../provision/grandstream/gxp2135/{$mac}.xml  | 24 ++++++++++++-
 .../provision/grandstream/ht801/{$mac}.xml    | 21 ++++++++++--
 .../provision/grandstream/ht802/{$mac}.xml    | 21 ++++++++++--
 4 files changed, 92 insertions(+), 8 deletions(-)

diff --git a/app/grandstream/app_config.php b/app/grandstream/app_config.php
index 7f919e03ab..748ad2bfe2 100644
--- a/app/grandstream/app_config.php
+++ b/app/grandstream/app_config.php
@@ -1200,5 +1200,37 @@
 		$apps[$x]['default_settings'][$y]['default_setting_enabled'] = "false";
 		$apps[$x]['default_settings'][$y]['default_setting_description'] = "Public Mode. 0 - No, 1 - Yes. Default is 0";
 		$y++;
+		$apps[$x]['default_settings'][$y]['default_setting_uuid'] = "fb20a7c7-ef89-4b7a-9080-75a2e40fe88a";
+		$apps[$x]['default_settings'][$y]['default_setting_category'] = "provision";
+		$apps[$x]['default_settings'][$y]['default_setting_subcategory'] = "grandstream_random_port";
+		$apps[$x]['default_settings'][$y]['default_setting_name'] = "text";
+		$apps[$x]['default_settings'][$y]['default_setting_value'] = "0";
+		$apps[$x]['default_settings'][$y]['default_setting_enabled'] = "false";
+		$apps[$x]['default_settings'][$y]['default_setting_description'] = "Use Random Port. 0 - No, 1 - Yes. Default is 0";
+		$y++;
+		$apps[$x]['default_settings'][$y]['default_setting_uuid'] = "f1e8c4a5-9b2d-4f7e-8c3a-1d5e6f9a8b7c";
+		$apps[$x]['default_settings'][$y]['default_setting_category'] = "provision";
+		$apps[$x]['default_settings'][$y]['default_setting_subcategory'] = "grandstream_snmp_enable";
+		$apps[$x]['default_settings'][$y]['default_setting_name'] = "numeric";
+		$apps[$x]['default_settings'][$y]['default_setting_value'] = "0";
+		$apps[$x]['default_settings'][$y]['default_setting_enabled'] = "false";
+		$apps[$x]['default_settings'][$y]['default_setting_description'] = "Enable SNMP. 0 - No, 1 - Yes. Default is 0 (disabled).";
+		$y++;
+		$apps[$x]['default_settings'][$y]['default_setting_uuid'] = "a2b3c4d5-6e7f-8a9b-0c1d-2e3f4a5b6c7d";
+		$apps[$x]['default_settings'][$y]['default_setting_category'] = "provision";
+		$apps[$x]['default_settings'][$y]['default_setting_subcategory'] = "grandstream_snmp_version";
+		$apps[$x]['default_settings'][$y]['default_setting_name'] = "numeric";
+		$apps[$x]['default_settings'][$y]['default_setting_value'] = "2";
+		$apps[$x]['default_settings'][$y]['default_setting_enabled'] = "false";
+		$apps[$x]['default_settings'][$y]['default_setting_description'] = "SNMP Version. 1 - Version 1, 2 - Version 2c, 3 - Version 3. Default is 2 (Version 2c).";
+		$y++;
+		$apps[$x]['default_settings'][$y]['default_setting_uuid'] = "b3c4d5e6-7f8a-9b0c-1d2e-3f4a5b6c7d8e";
+		$apps[$x]['default_settings'][$y]['default_setting_category'] = "provision";
+		$apps[$x]['default_settings'][$y]['default_setting_subcategory'] = "grandstream_snmp_community";
+		$apps[$x]['default_settings'][$y]['default_setting_name'] = "text";
+		$apps[$x]['default_settings'][$y]['default_setting_value'] = "public";
+		$apps[$x]['default_settings'][$y]['default_setting_enabled'] = "false";
+		$apps[$x]['default_settings'][$y]['default_setting_description'] = "SNMPv1/v2c Community string. Default is 'public'.";
+		$y++;
 
-?>
+?>
\ No newline at end of file
diff --git a/resources/templates/provision/grandstream/gxp2135/{$mac}.xml b/resources/templates/provision/grandstream/gxp2135/{$mac}.xml
index 28ab42ad7b..baf61a056c 100644
--- a/resources/templates/provision/grandstream/gxp2135/{$mac}.xml
+++ b/resources/templates/provision/grandstream/gxp2135/{$mac}.xml
@@ -1057,10 +1057,24 @@
 		<!-- ## Network/SNMP Settings                     ## -->
 		<!-- ############################################################################## -->
 		<!-- # Enable SNMP. Yes or No -->
+{if isset($grandstream_snmp_enable) && $grandstream_snmp_enable == '1'}
+		<item name="network.snmp.enable">Yes</item>
+{else}
 		<item name="network.snmp.enable">No</item>
+{/if}
 
 		<!-- # Version. Version1, Version2, Version3. Default is Version3 -->
+{if isset($grandstream_snmp_version)}
+	{if $grandstream_snmp_version == '1'}
+		<item name="network.snmp.version">Version1</item>
+	{elseif $grandstream_snmp_version == '2'}
+		<item name="network.snmp.version">Version2</item>
+	{else}
 		<item name="network.snmp.version">Version3</item>
+	{/if}
+{else}
+		<item name="network.snmp.version">Version2</item>
+{/if}
 
 		<!-- # Port -->
 		<!-- # Number. Default is 161. -->
@@ -1068,7 +1082,11 @@
 
 		<!-- # Community -->
 		<!-- # String -->
-		<item name="network.snmp.community"/>
+{if isset($grandstream_snmp_community)}
+		<item name="network.snmp.community">{$grandstream_snmp_community}</item>
+{else}
+		<item name="network.snmp.community">public</item>
+{/if}
 
 		<!-- # SNMP Trap Version -->
 		<!-- # Version1, Version2, Version3. -->
@@ -2214,7 +2232,11 @@
 		<item name="sip.showError">Yes</item>
 
 		<!-- # Enable Missed Call Notification. Yes or No -->
+		{if isset($grandstream_missed_call_notification)}
 		<item name="features.history.missedCallNotification">{$grandstream_missed_call_notification}</item>
+		{else}
+		<item name="features.history.missedCallNotification">No</item>
+		{/if}
 
 		<!-- # Enable Call Completion Service. Yes or No -->
 		<item name="call.dial.callComplete.enable"/>
diff --git a/resources/templates/provision/grandstream/ht801/{$mac}.xml b/resources/templates/provision/grandstream/ht801/{$mac}.xml
index 0916d0fa72..a5f28660f6 100644
--- a/resources/templates/provision/grandstream/ht801/{$mac}.xml
+++ b/resources/templates/provision/grandstream/ht801/{$mac}.xml
@@ -87,6 +87,9 @@
     <!-- # Firmware Upgrade and Privisioning. 0 - TFTP Upgrade, 1 - HTTP Upgrade, 2 - HTTPS Upgrade, 3 - FTP Upgrade, 4 - FTPS Upgrade. -->
     <!-- # Number: 0, 1, 2, 3, 4 -->
     <!-- # Mandatory -->
+    {if isset($grandstream_firmware_upgrade_protocol) }
+    <P212>{$grandstream_firmware_upgrade_protocol}</P212>
+    {else}
     <P212>2</P212>
 
     <!-- Firmware Server Path -->
@@ -271,12 +274,20 @@
     <!-- # Enable SNMP. 0 - No, 1 - Yes, default value is 0. -->
     <!-- # Number: 0, 1 -->
     <!-- # Mandatory -->
+{if isset($grandstream_snmp_enable)}
+    <P21896>{$grandstream_snmp_enable}</P21896>
+    {else}
     <P21896>0</P21896>
+{/if}
 
     <!-- # SNMP Version. 1 - Version 1, 2 - Version 2c, 3 - Version 3. Default value is 3. -->
     <!-- # Nmuber: 1, 2, 3 -->
     <!-- # Mandatory -->
-    <P21904>3</P21904>
+{if isset($grandstream_snmp_version)}
+    <P21904>{$grandstream_snmp_version}</P21904>
+    {else}
+    <P21904>2</P21904>
+{/if}
 
     <!-- # SNMP Port. Default is port 162 -->
     <!-- # Number: 162 or 1025 to 65535 -->
@@ -302,7 +313,11 @@
 
     <!-- # SNMPv1/v2c Community -->
     <!-- # Max Character Number: 64 -->
-    <P21902></P21902>
+{if isset($grandstream_snmp_community)}
+    <P21902>{$grandstream_snmp_community}</P21902>
+    {else}
+    <P21902>public</P21902>
+{/if}
 
     <!-- # SNMP Trap Community -->
     <!-- # Max String Length: 64 -->
@@ -2075,4 +2090,4 @@
     <!-- # Number of gateway ARP response failures allowed for network monitor -->
     <!-- #P20712=1 -->
   </config>
-</gs_provision>
+</gs_provision>
\ No newline at end of file
diff --git a/resources/templates/provision/grandstream/ht802/{$mac}.xml b/resources/templates/provision/grandstream/ht802/{$mac}.xml
index de86db987d..635c29684b 100644
--- a/resources/templates/provision/grandstream/ht802/{$mac}.xml
+++ b/resources/templates/provision/grandstream/ht802/{$mac}.xml
@@ -87,6 +87,9 @@
     <!-- # Firmware Upgrade and Privisioning. 0 - TFTP Upgrade, 1 - HTTP Upgrade, 2 - HTTPS Upgrade, 3 - FTP Upgrade, 4 - FTPS Upgrade. -->
     <!-- # Number: 0, 1, 2, 3, 4 -->
     <!-- # Mandatory -->
+    {if isset($grandstream_firmware_upgrade_protocol) }
+    <P212>{$grandstream_firmware_upgrade_protocol}</P212>
+    {else}
     <P212>2</P212>
 
     <!-- Firmware Server Path -->
@@ -271,12 +274,20 @@
     <!-- # Enable SNMP. 0 - No, 1 - Yes, default value is 0. -->
     <!-- # Number: 0, 1 -->
     <!-- # Mandatory -->
+{if isset($grandstream_snmp_enable)}
+    <P21896>{$grandstream_snmp_enable}</P21896>
+    {else}
     <P21896>0</P21896>
+{/if}
 
     <!-- # SNMP Version. 1 - Version 1, 2 - Version 2c, 3 - Version 3. Default value is 3. -->
     <!-- # Nmuber: 1, 2, 3 -->
     <!-- # Mandatory -->
-    <P21904>3</P21904>
+{if isset($grandstream_snmp_version)}
+    <P21904>{$grandstream_snmp_version}</P21904>
+    {else}
+    <P21904>2</P21904>
+{/if}
 
     <!-- # SNMP Port. Default is port 162 -->
     <!-- # Number: 162 or 1025 to 65535 -->
@@ -302,7 +313,11 @@
 
     <!-- # SNMPv1/v2c Community -->
     <!-- # Max Character Number: 64 -->
-    <P21902></P21902>
+{if isset($grandstream_snmp_community)}
+    <P21902>{$grandstream_snmp_community}</P21902>
+    {else}
+    <P21902>public</P21902>
+{/if}
 
     <!-- # SNMP Trap Community -->
     <!-- # Max String Length: 64 -->
@@ -2448,7 +2463,7 @@
     <!-- # IP Address. 0 - DHCP, 2 - PPPoE, 1 - Static IP -->
     <!-- # Number: 0, 1, 2 -->
     <!-- # Mandatory -->
-    <P8>0</P8>
+    {if isset($grandstream_ip_mode)}<P8>{$grandstream_ip_mode}</P8>{else}<P8>0</P8>{/if}</P8>
 
     <!-- ################################################################################# -->
     <!-- # DHCP -->