nsinnovations/fusionpbx
2
0
Fork 0
mirror of https://github.com/fusionpbx/fusionpbx.git synced 2025-12-30 00:53:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

use loose comparison instead of strict comparison (#7064)

Browse Source 
Update comparison checks when testing the database status and
add a unified log message with a more detailed message from the
database when there is a failure

Authored-by: Tim Fry <tim@fusionpbx.com>
This commit is contained in:
frytimo
2024-07-23 22:58:13 -03:00
committed by GitHub
parent 64c6527ab8
commit 46abe4897c
5 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/database_transactions/resources/classes/database_transactions.php
View File

@@ -57,12 +57,14 @@ class database_transactions {
$sql = "delete from v_{$table} WHERE transaction_date < NOW() - INTERVAL '{$retention_days} days'"
. " and domain_uuid = '{$domain_uuid}'";
$database->execute($sql);
if ($database->message['code'] === 200) {
$code = $database->message['code'] ?? 0;
if ($code == 200) {
//success
maintenance_service::log_write(self::class, "Successfully removed database_transaction entries from $domain_name", $domain_uuid);
maintenance_service::log_write(self::class, "Successfully removed entries older than $retention_days", $domain_uuid);
} else {
//failure
maintenance_service::log_write(self::class, "Unable to remove records for domain $domain_name", $domain_uuid, maintenance_service::LOG_ERROR);
$message = $database->message['message'] ?? "An unknown error has occurred";
maintenance_service::log_write(self::class, "Unable to remove old database records. Error message: $message ($code)", $domain_uuid, maintenance_service::LOG_ERROR);
}
} else {
//report an invalid setting