From 328d79e95d82271e47aba03c1fc4ad9ab0760df6 Mon Sep 17 00:00:00 2001 From: agree <37550360+greenbea@users.noreply.github.com> Date: Tue, 3 Nov 2020 16:17:58 -0500 Subject: [PATCH 1/2] Prevent users from overriding user_context --- app/extensions/extension_edit.php | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/app/extensions/extension_edit.php b/app/extensions/extension_edit.php index 9144b45376..b3dfd1c3fc 100644 --- a/app/extensions/extension_edit.php +++ b/app/extensions/extension_edit.php @@ -267,15 +267,6 @@ return; } - //set the default user context - if (permission_exists("extension_user_context")) { - //allow a user assigned to super admin to change the user_context - } - else { - //if the user_context was not set then set the default value - $user_context = $_SESSION['domain_name']; - } - //prevent users from bypassing extension limit by using range if ($_SESSION['limit']['extensions']['numeric'] != '') { if ($total_extensions + $range > $_SESSION['limit']['extensions']['numeric']){ @@ -402,7 +393,14 @@ $array["extensions"][$i]["directory_exten_visible"] = $directory_exten_visible; $array["extensions"][$i]["limit_max"] = $limit_max; $array["extensions"][$i]["limit_destination"] = $limit_destination; - $array["extensions"][$i]["user_context"] = $user_context; + if (permission_exists("extension_user_context")) { + $array["extensions"][$i]["user_context"] = $user_context; + } + else { + if ($action == "add") { + $user_context = $_SESSION['domain_name']; + } + } if (permission_exists('extension_missed_call')) { $array["extensions"][$i]["missed_call_app"] = $missed_call_app; $array["extensions"][$i]["missed_call_data"] = $missed_call_data; From 139461cf2e84a9b9a6391709f260d68ecad86536 Mon Sep 17 00:00:00 2001 From: agree <37550360+greenbea@users.noreply.github.com> Date: Tue, 3 Nov 2020 16:31:40 -0500 Subject: [PATCH 2/2] Update extension_edit.php --- app/extensions/extension_edit.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/extensions/extension_edit.php b/app/extensions/extension_edit.php index b3dfd1c3fc..4ef2eddade 100644 --- a/app/extensions/extension_edit.php +++ b/app/extensions/extension_edit.php @@ -398,7 +398,7 @@ } else { if ($action == "add") { - $user_context = $_SESSION['domain_name']; + $array["extensions"][$i]["user_context"] = $_SESSION['domain_name']; } } if (permission_exists('extension_missed_call')) {