diff --git a/core/users/user_edit.php b/core/users/user_edit.php
index 6c098aba9d..ffd17591b4 100644
--- a/core/users/user_edit.php
+++ b/core/users/user_edit.php
@@ -38,7 +38,7 @@
$text = $language->get();
//get user uuid
- if ((is_uuid($_REQUEST["id"]) && permission_exists('user_edit')) || (is_uuid($_REQUEST["id"]) && $_REQUEST["id"] == $_SESSION['user_uuid'])) {
+ if (!empty($_REQUEST["id"]) && ((is_uuid($_REQUEST["id"]) && permission_exists('user_edit')) || (is_uuid($_REQUEST["id"]) && $_REQUEST["id"] == $_SESSION['user_uuid']))) {
$user_uuid = $_REQUEST["id"];
$action = 'edit';
}
@@ -498,7 +498,7 @@
//add user setting to array for update
$array['users'][$x]['user_uuid'] = $user_uuid;
$array['users'][$x]['domain_uuid'] = $domain_uuid;
- if ($username != '' && $username != $username_old) {
+ if ($username != '' && (empty($username_old) || $username != $username_old)) {
$array['users'][$x]['username'] = $username;
}
if ($password != '' && $password == $password_confirm) {
@@ -725,12 +725,12 @@
echo "
".$text['label-username']." | ";
echo " ";
if (permission_exists("user_edit")) {
- echo " \n";
+ echo " \n";
echo " \n"; //help defeat browser auto-fill
}
else {
echo " ".escape($username)."\n";
- echo " \n";
+ echo " \n";
}
echo " | ";
echo " ";
@@ -781,7 +781,7 @@
echo " ";
echo " | ".$text['label-email']." | ";
- echo " | ";
+ echo " | ";
echo "
";
echo " \n";
@@ -924,15 +924,15 @@
elseif ($action == 'add' && permission_exists("user_add") && permission_exists('contact_add')) {
echo "
";
echo " | ".$text['label-first_name']." | ";
- echo " | ";
+ echo " | ";
echo "
";
echo " ";
echo " | ".$text['label-last_name']." | ";
- echo " | ";
+ echo " | ";
echo "
";
echo " ";
echo " | ".$text['label-organization']." | ";
- echo " | ";
+ echo " | ";
echo "
";
}
@@ -986,7 +986,7 @@
$sql = "select * from v_groups ";
$sql .= "where (domain_uuid = :domain_uuid or domain_uuid is null) ";
- if (is_array($assigned_groups) && sizeof($assigned_groups) > 0) {
+ if (!empty($assigned_groups) && is_array($assigned_groups) && sizeof($assigned_groups) > 0) {
$sql .= "and group_uuid not in ('".implode("','",$assigned_groups)."') ";
}
$sql .= "order by domain_uuid desc, group_name asc ";
@@ -1040,7 +1040,7 @@
echo " ";
echo " | ".$text['label-api_key']." | ";
echo " \n";
- echo " ";
+ echo " ";
if (empty($api_key)) {
//generate api key
echo button::create(['type'=>'button',
|