diff --git a/app/event_guard/event_guard_logs.php b/app/event_guard/event_guard_logs.php index e8afa6a249..5ede53b9a4 100644 --- a/app/event_guard/event_guard_logs.php +++ b/app/event_guard/event_guard_logs.php @@ -1,7 +1,7 @@ + Copyright (C) 2022-2023 Mark J Crane Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: @@ -46,14 +46,14 @@ $text = $language->get(); //get the http post data - if (is_array($_POST['event_guard_logs'])) { + if (!empty($_POST['event_guard_logs']) && is_array($_POST['event_guard_logs'])) { $action = $_POST['action']; $search = $_POST['search']; $event_guard_logs = $_POST['event_guard_logs']; } //process the http post data by action - if ($action != '' && is_array($event_guard_logs) && @sizeof($event_guard_logs) != 0) { + if (!empty($action) && !empty($event_guard_logs) && is_array($event_guard_logs) && @sizeof($event_guard_logs) != 0) { switch ($action) { case 'copy': @@ -82,12 +82,12 @@ } //get order and order by - $order_by = $_GET["order_by"]; - $order = $_GET["order"]; + $order_by = $_GET["order_by"] ?? null; + $order = $_GET["order"] ?? null; //add the search - if (isset($_GET["search"])) { - $search = strtolower($_GET["search"]); + if (!empty($_GET["search"])) { + $search = $_GET["search"]; } //get the count @@ -96,27 +96,27 @@ $sql .= "where true "; if (isset($search)) { $sql .= "and ("; - $sql .= " hostname like :search "; + $sql .= " lower(hostname) like :search "; $sql .= " or filter like :search "; $sql .= " or ip_address like :search "; $sql .= " or extension like :search "; - $sql .= " or user_agent like :search "; - $sql .= " or log_status like :search "; + $sql .= " or lower(user_agent) like :search "; + $sql .= " or lower(log_status) like :search "; $sql .= ") "; - $parameters['search'] = '%'.$search.'%'; + $parameters['search'] = '%'.strtolower($search).'%'; } if (isset($_GET["filter"]) && $_GET["filter"] != '') { $sql .= "and filter = :filter "; $parameters['filter'] = $_GET["filter"]; } $database = new database; - $num_rows = $database->select($sql, $parameters, 'column'); + $num_rows = $database->select($sql, $parameters ?? null, 'column'); unset($sql, $parameters); //prepare to page the results $rows_per_page = ($_SESSION['domain']['paging']['numeric'] != '') ? $_SESSION['domain']['paging']['numeric'] : 50; - $param = $search ? "&search=".$search : null; - $page = is_numeric($_GET['page']) ? $_GET['page'] : 0; + $param = !empty($search) ? "&search=".$search : null; + $page = !empty($_GET['page']) && is_numeric($_GET['page']) ? $_GET['page'] : 0; list($paging_controls, $rows_per_page) = paging($num_rows, $param, $rows_per_page); list($paging_controls_mini, $rows_per_page) = paging($num_rows, $param, $rows_per_page, true); $offset = $rows_per_page * $page; @@ -144,25 +144,25 @@ $sql .= "log_status "; $sql .= "from v_event_guard_logs "; $sql .= "where true "; - if (isset($_GET["search"]) && $_GET["search"] != '') { + if (!empty($search)) { $sql .= "and ("; - $sql .= " hostname like :search "; + $sql .= " lower(hostname) like :search "; $sql .= " or filter like :search "; $sql .= " or ip_address like :search "; $sql .= " or extension like :search "; - $sql .= " or user_agent like :search "; - $sql .= " or log_status like :search "; + $sql .= " or lower(user_agent) like :search "; + $sql .= " or lower(log_status) like :search "; $sql .= ") "; - $parameters['search'] = '%'.$search.'%'; + $parameters['search'] = '%'.strtolower($search).'%'; } - if (isset($_GET["filter"]) && $_GET["filter"] != '') { + if (!empty($_GET["filter"])) { $sql .= "and filter = :filter "; $parameters['filter'] = $_GET["filter"]; } $sql .= order_by($order_by, $order, 'log_date', 'desc'); $sql .= limit_offset($rows_per_page, $offset); $database = new database; - $event_guard_logs = $database->select($sql, $parameters, 'all'); + $event_guard_logs = $database->select($sql, $parameters ?? null, 'all'); unset($sql, $parameters); //create token @@ -193,22 +193,12 @@ echo " \n"; - echo ""; - echo button::create(['label'=>$text['button-search'],'icon'=>$_SESSION['theme']['button_icon_search'],'type'=>'submit','id'=>'btn_search','style'=>($search != '' ? 'display: none;' : null)]); - echo button::create(['label'=>$text['button-reset'],'icon'=>$_SESSION['theme']['button_icon_reset'],'type'=>'button','id'=>'btn_reset','link'=>'event_guard_logs.php','style'=>($search == '' ? 'display: none;' : null)]); + echo ""; + echo button::create(['label'=>$text['button-search'],'icon'=>$_SESSION['theme']['button_icon_search'],'type'=>'submit','id'=>'btn_search','style'=>(!empty($search) ? 'display: none;' : null)]); + echo button::create(['label'=>$text['button-reset'],'icon'=>$_SESSION['theme']['button_icon_reset'],'type'=>'button','id'=>'btn_reset','link'=>'event_guard_logs.php','style'=>(empty($search) ? 'display: none;' : null)]); if ($paging_controls_mini != '') { echo "".$paging_controls_mini."\n"; } @@ -232,24 +222,24 @@ echo "
\n"; echo "\n"; - echo "\n"; + echo "\n"; echo "\n"; echo "\n"; if (permission_exists('event_guard_log_add') || permission_exists('event_guard_log_edit') || permission_exists('event_guard_log_delete')) { echo " \n"; } echo "\n"; echo "\n"; echo "\n"; - echo th_order_by('filter', $text['label-filter'], $order_by, $order); + echo th_order_by('filter', $text['label-filter'], $order_by, $order, null, "style='text-align: center;'"); echo th_order_by('ip_address', $text['label-ip_address'], $order_by, $order); echo th_order_by('extension', $text['label-extension'], $order_by, $order); echo "\n"; echo th_order_by('log_status', $text['label-log_status'], $order_by, $order); - if (permission_exists('event_guard_log_edit') && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { + if (permission_exists('event_guard_log_edit') && !empty($_SESSION['theme']['list_row_edit_button']['boolean']) && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { echo " \n"; } echo "\n"; @@ -277,13 +267,16 @@ echo " \n"; echo " \n"; echo " \n"; - - echo " \n"; + switch($row['filter']) { + case 'sip-auth-ip': $filter = $text['option-ip']; break; + case 'sip-auth-fail': $filter = $text['option-authentication']; break; + } + echo " \n"; echo " \n"; echo " \n"; echo " \n"; - echo " \n"; - if (permission_exists('event_guard_log_edit') && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { + echo " \n"; + if (permission_exists('event_guard_log_edit') && !empty($_SESSION['theme']['list_row_edit_button']['boolean']) && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { echo " \n"; @@ -303,4 +296,4 @@ //include the footer require_once "resources/footer.php"; -?> +?> \ No newline at end of file
\n"; - echo " \n"; + echo " \n"; echo " ".$text['label-hostname']."".$text['label-date']."".$text['label-time']."".$text['label-user_agent']." 
".escape($row['log_date_formatted'])."".escape($row['log_time_formatted'])."".escape($row['filter'])."".escape($filter)."".escape($row['ip_address'])."".escape($row['extension'])."".escape($row['user_agent'])."".escape($row['log_status'])."".escape($text['label-'.$row['log_status']])."\n"; echo button::create(['type'=>'button','title'=>$text['button-edit'],'icon'=>$_SESSION['theme']['button_icon_edit'],'link'=>$list_row_url]); echo "