diff --git a/core/users/user_edit.php b/core/users/user_edit.php index 25b2a93a3c..ec94c652e4 100644 --- a/core/users/user_edit.php +++ b/core/users/user_edit.php @@ -81,7 +81,7 @@ } //delete the group from the user - if ($_GET["a"] == "delete" && is_uuid($_GET["group_uuid"]) && is_uuid($user_uuid) && permission_exists("user_delete")) { + if (!empty($_GET["a"]) && $_GET["a"] == "delete" && is_uuid($_GET["group_uuid"]) && is_uuid($user_uuid) && permission_exists("user_delete")) { //set the variables $group_uuid = $_GET["group_uuid"]; //delete the group from the users @@ -125,7 +125,7 @@ $password = $_POST["password"]; $password_confirm = $_POST["password_confirm"]; $user_email = $_POST["user_email"]; - $user_status = $_POST["user_status"]; + $user_status = $_POST["user_status"] ?? null; $user_language = $_POST["user_language"]; $user_time_zone = $_POST["user_time_zone"]; @@ -228,7 +228,7 @@ } //return if error - if (message::count() != 0 || (is_array($invalid) && @sizeof($invalid) != 0)) { + if (message::count() != 0 || !empty($invalid)) { if ($invalid) { message::add($text['message-required'].implode(', ', $invalid), 'negative', 7500); } persistent_form_values('store', $_POST); header("Location: user_edit.php".(permission_exists('user_edit') && $action != 'add' ? "?id=".urlencode($user_uuid) : null)); @@ -301,7 +301,7 @@ $parameters['user_uuid'] = $user_uuid; $database = new database; $row = $database->select($sql, $parameters, 'row'); - if ($row['user_setting_uuid'] == '' && $user_time_zone != '') { + if (empty($row['user_setting_uuid']) && !empty($user_time_zone)) { //add user setting to array for insert $array['user_settings'][$i]['user_setting_uuid'] = uuid(); $array['user_settings'][$i]['user_uuid'] = $user_uuid; @@ -314,7 +314,7 @@ $i++; } else { - if ($row['user_setting_value'] == '' || $user_time_zone == '') { + if (empty($row['user_setting_value']) || !empty($user_time_zone)) { $array_delete['user_settings'][0]['user_setting_category'] = 'domain'; $array_delete['user_settings'][0]['user_setting_subcategory'] = 'time_zone'; $array_delete['user_settings'][0]['user_uuid'] = $user_uuid; @@ -695,7 +695,7 @@ echo "