From 2085c950ee8cf992091eef190c754e87f979b954 Mon Sep 17 00:00:00 2001 From: frytimo Date: Mon, 9 Sep 2024 12:14:45 -0300 Subject: [PATCH] Use isset in permission exists for improved efficiency(#7126) Using isset on the key name of the array allows it to use a hash table lookup to improve the lookup times for a permission. The permission name is not set if it does not exist for the current user. --- resources/classes/permissions.php | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/resources/classes/permissions.php b/resources/classes/permissions.php index f3fdd22fd7..2fd75cdcbf 100644 --- a/resources/classes/permissions.php +++ b/resources/classes/permissions.php @@ -127,21 +127,12 @@ if (!class_exists('permissions')) { return true; } - //set default to false - $result = false; - //search for the permission - if (!empty($this->permissions) && !empty($permission_name)) { - foreach($this->permissions as $key => $value) { - if ($key == $permission_name) { - $result = true; - break; - } - } + if (!empty($permission_name)) { + return isset($this->permissions[$permission_name]); } - //return the result - return $result; + return false; } /**