From 107dcd9b6903b50cba8097793f2b29fc2acdec48 Mon Sep 17 00:00:00 2001
From: Nate Jones <git@reliberate.com>
Date: Tue, 17 Feb 2015 11:04:56 +0000
Subject: [PATCH] Operator Panel: Added ability to set Eavesdrop destination
 (from assigned extensions), pause refresh manually or on mouse hover of
 control elements for better user experience.  Hide eavesdrop function if no
 extensions assigned to user (addresses Issue 851).

---
 app/operator_panel/app_languages.php          |  20 ++++++
 app/operator_panel/index.php                  |   8 ++-
 app/operator_panel/index_inc.php              |  61 +++++++++++++-----
 .../resources/images/refresh_active.gif       | Bin 0 -> 1079 bytes
 .../resources/images/refresh_paused.png       | Bin 0 -> 501 bytes
 resources/functions.php                       |  24 ++++---
 6 files changed, 87 insertions(+), 26 deletions(-)
 create mode 100644 app/operator_panel/resources/images/refresh_active.gif
 create mode 100644 app/operator_panel/resources/images/refresh_paused.png

diff --git a/app/operator_panel/app_languages.php b/app/operator_panel/app_languages.php
index 8ec1eeaf3d..d53768c89e 100644
--- a/app/operator_panel/app_languages.php
+++ b/app/operator_panel/app_languages.php
@@ -60,6 +60,11 @@
 	$text['label-eavesdrop']['pt-pt'] = "Bisbilhotar";
 	$text['label-eavesdrop']['fr-fr'] = "Espionner";
 
+	$text['description-eavesdrop_destination']['en-us'] = "Select the Eavesdrop Destination";
+	$text['description-eavesdrop_destination']['es-cl'] = "Seleccione el Eavesdrop Destino";
+	$text['description-eavesdrop_destination']['pt-pt'] = "Selecione o Eavesdrop Destino";
+	$text['description-eavesdrop_destination']['fr-fr'] = "Sélectionnez le Eavesdrop Destinations";
+
 	$text['label-kill']['en-us'] = "Kill";
 	$text['label-kill']['es-cl'] = "Finalizar Llamada";
 	$text['label-kill']['pt-pt'] = "Chamada Final";
@@ -80,4 +85,19 @@
 	$text['button-all']['pt-pt'] = "Tudo";
 	$text['button-all']['fr-fr'] = "Tous";
 
+	$text['label-refresh_pause']['en-us'] = "Pause Refresh";
+	$text['label-refresh_pause']['es-cl'] = "Actualizar Pausa";
+	$text['label-refresh_pause']['pt-pt'] = "Pausa Atualizar";
+	$text['label-refresh_pause']['fr-fr'] = "Pause Actualiser";
+
+	$text['label-refresh_enable']['en-us'] = "Enable Refresh";
+	$text['label-refresh_enable']['es-cl'] = "Activar Actualizar";
+	$text['label-refresh_enable']['pt-pt'] = "Habilitar Atualização";
+	$text['label-refresh_enable']['fr-fr'] = "Activer Actualiser";
+
+	$text['label-call_direction']['en-us'] = "Call Direction";
+	$text['label-call_direction']['es-cl'] = "Dirección de la llamada";
+	$text['label-call_direction']['pt-pt'] = "Direção da chamada";
+	$text['label-call_direction']['fr-fr'] = "Sens de l'appel";
+
 ?>
\ No newline at end of file
diff --git a/app/operator_panel/index.php b/app/operator_panel/index.php
index 278b1853c0..3a85312628 100644
--- a/app/operator_panel/index.php
+++ b/app/operator_panel/index.php
@@ -17,7 +17,7 @@
 
 	The Initial Developer of the Original Code is
 	Mark J Crane <markjcrane@fusionpbx.com>
-	Portions created by the Initial Developer are Copyright (C) 2008-2012
+	Portions created by the Initial Developer are Copyright (C) 2008-2015
 	the Initial Developer. All Rights Reserved.
 
 	Contributor(s):
@@ -119,6 +119,7 @@ require_once "resources/header.php";
 		url += '&vd_ext_from=' + document.getElementById('vd_ext_from').value;
 		url += '&vd_ext_to=' + document.getElementById('vd_ext_to').value;
 		url += '&group=' + ((document.getElementById('group')) ? document.getElementById('group').value : '');
+		url += '&eavesdrop_dest=' + ((document.getElementById('eavesdrop_dest')) ? document.getElementById('eavesdrop_dest').value : '');
 		<?php
 		if (isset($_GET['debug'])) {
 			echo "url += '&debug';";
@@ -192,14 +193,17 @@ require_once "resources/header.php";
 //refresh controls
 	function refresh_stop() {
 		clearInterval(interval_timer_id);
+		document.getElementById('refresh_state').innerHTML = "<img src='resources/images/refresh_paused.png' style='width: 16px; height: 16px; border: none; margin-top: 1px; cursor: pointer;' onclick='refresh_start();' alt=\"<?=$text['label-refresh_enable']?>\" title=\"<?=$text['label-refresh_enable']?>\">";
 	}
 
 	function refresh_start() {
+		if (document.getElementById('refresh_state')) { document.getElementById('refresh_state').innerHTML = "<img src='resources/images/refresh_active.gif' style='width: 16px; height: 16px; border: none; margin-top: 3px; cursor: pointer;' alt=\"<?=$text['label-refresh_pause']?>\" title=\"<?=$text['label-refresh_pause']?>\">"; }
 		interval_timer_id = setInterval( function() {
 			url = source_url;
 			url += '&vd_ext_from=' + document.getElementById('vd_ext_from').value;
 			url += '&vd_ext_to=' + document.getElementById('vd_ext_to').value;
 			url += '&group=' + ((document.getElementById('group')) ? document.getElementById('group').value : '');
+			url += '&eavesdrop_dest=' + ((document.getElementById('eavesdrop_dest')) ? document.getElementById('eavesdrop_dest').value : '');
 			<?php
 			if (isset($_GET['debug'])) {
 				echo "url += '&debug';";
@@ -286,7 +290,7 @@ require_once "resources/header.php";
 	}
 
 	function get_eavesdrop_cmd(ext, chan_uuid) {
-		cmd = "bgapi originate {origination_caller_id_name=<?=$text['label-eavesdrop']?>,origination_caller_id_number=" + ext + "}user/<?=$_SESSION['user']['extensions'][0]?>@<?=$_SESSION['domain_name']?> &eavesdrop(" + chan_uuid + ")";
+		cmd = "bgapi originate {origination_caller_id_name=<?=$text['label-eavesdrop']?>,origination_caller_id_number=" + ext + "}user/"+(document.getElementById('eavesdrop_dest').value)+"@<?=$_SESSION['domain_name']?> &eavesdrop(" + chan_uuid + ")";
 		return cmd;
 	}
 
diff --git a/app/operator_panel/index_inc.php b/app/operator_panel/index_inc.php
index bf2a8e9635..989b0b87f9 100644
--- a/app/operator_panel/index_inc.php
+++ b/app/operator_panel/index_inc.php
@@ -17,7 +17,7 @@
 
 	The Initial Developer of the Original Code is
 	Mark J Crane <markjcrane@fusionpbx.com>
-	Portions created by the Initial Developer are Copyright (C) 2008-2012
+	Portions created by the Initial Developer are Copyright (C) 2008-2015
 	the Initial Developer. All Rights Reserved.
 
 	Contributor(s):
@@ -57,6 +57,8 @@ foreach ($activity as $extension => $fields) {
 $groups = array_unique($groups);
 sort($groups);
 
+$onhover_pause_refresh = " onmouseover='refresh_stop();' onmouseout='refresh_start();'";
+
 echo "<table width='100%'>";
 echo "	<tr>";
 echo "		<td valign='top' align='left' width='50%' nowrap>";
@@ -84,34 +86,61 @@ if (sizeof($_SESSION['user']['extensions']) > 0) {
 	$status_options[5]['style'] = "op_btn_status_logged_out";
 
 	foreach ($status_options as $status_option) {
-		echo "	<input type='button' id='".$status_option['style']."' class='btn' value=\"".$status_option['label']."\" onclick=\"send_cmd('index.php?status='+escape('".$status_option['status']."'));\">\n";
+		echo "	<input type='button' id='".$status_option['style']."' class='btn' value=\"".$status_option['label']."\" onclick=\"send_cmd('index.php?status='+escape('".$status_option['status']."'));\" ".$onhover_pause_refresh.">\n";
 	}
 }
 
 echo "		</td>";
 echo "		<td valign='top' align='right' width='50%' nowrap>";
+echo "			<table cellpadding='0' cellspacing='0' border='0'>";
+echo "				<tr>";
+echo "					<td valign='middle' nowrap='nowrap' style='padding-right: 15px' id='refresh_state'>";
+echo "						<img src='resources/images/refresh_active.gif' style='width: 16px; height: 16px; border: none; margin-top: 3px; cursor: pointer;' onclick='refresh_stop();' alt=\"".$text['label-refresh_pause']."\" title=\"".$text['label-refresh_pause']."\">";
+echo "					</td>";
+
+if (permission_exists('operator_panel_eavesdrop')) {
+	echo "				<td valign='top' nowrap='nowrap'>";
+	if (sizeof($_SESSION['user']['extensions']) > 1) {
+		echo "				<input type='hidden' id='eavesdrop_dest' value=\"".(($_REQUEST['eavesdrop_dest'] == '') ? $_SESSION['user']['extensions'][0] : $_REQUEST['eavesdrop_dest'])."\">";
+		echo "				<img src='resources/images/eavesdrop.png' style='width: 12px; height: 12px; border: none; margin: 0px 5px; cursor: help;' title='".$text['description-eavesdrop_destination']."' align='absmiddle' ".$onhover_pause_refresh.">";
+		echo "				<select class='formfld' style='margin-right: 5px;' align='absmiddle' onchange=\"document.getElementById('eavesdrop_dest').value = this.options[this.selectedIndex].value; refresh_start();\" onfocus='refresh_stop();' xonblur='refresh_start();'>\n";
+		foreach ($_SESSION['user']['extensions'] as $user_extension) {
+			echo "				<option value='".$user_extension."' ".(($_REQUEST['eavesdrop_dest'] == $user_extension) ? "selected" : null).">".$user_extension."</option>\n";
+		}
+		echo "				</select>\n";
+	}
+	else if (sizeof($_SESSION['user']['extensions']) == 1) {
+		echo "				<input type='hidden' id='eavesdrop_dest' value=\"".$_SESSION['user']['extensions'][0]."\">";
+	}
+	echo "				</td>";
+}
 
 if (sizeof($groups) > 0) {
-	echo "		<input type='hidden' id='group' value=\"".$_REQUEST['group']."\">";
+	echo "				<td valign='top' nowrap='nowrap'>";
+	echo "					<input type='hidden' id='group' value=\"".$_REQUEST['group']."\">";
 	if (sizeof($groups) > 5) {
 		//show select box
-		echo "	<select class='formfld' onchange=\"document.getElementById('group').value = this.options[this.selectedIndex].value; refresh_start();\" onfocus='refresh_stop();' onblur='refresh_start();'>\n";
-		echo "		<option value='' ".(($_REQUEST['group'] == '') ? "selected" : null).">".$text['label-call_group']."</option>";
-		echo "		<option value=''>".$text['button-all']."</option>";
+		echo "				<select class='formfld' onchange=\"document.getElementById('group').value = this.options[this.selectedIndex].value; refresh_start();\" onfocus='refresh_stop();' xonblur='refresh_start();'>\n";
+		echo "					<option value='' ".(($_REQUEST['group'] == '') ? "selected" : null).">".$text['label-call_group']."</option>";
+		echo "					<option value=''>".$text['button-all']."</option>";
 		foreach ($groups as $group) {
-			echo "	<option value='".$group."' ".(($_REQUEST['group'] == $group) ? "selected" : null).">".$group."</option>\n";
+			echo "				<option value='".$group."' ".(($_REQUEST['group'] == $group) ? "selected" : null).">".$group."</option>\n";
 		}
-		echo "	</select>\n";
+		echo "				</select>\n";
 	}
 	else {
 		//show buttons
-		echo "	<input type='button' class='btn' title=\"".$text['label-call_group']."\" value=\"".$text['button-all']."\" onclick=\"document.getElementById('group').value = '';\">";
+		echo "				<input type='button' class='btn' title=\"".$text['label-call_group']."\" value=\"".$text['button-all']."\" onclick=\"document.getElementById('group').value = '';\" ".$onhover_pause_refresh.">";
 		foreach ($groups as $group) {
-			echo "	<input type='button' class='btn' title=\"".$text['label-call_group']."\" value=\"".$group."\" ".(($_REQUEST['group'] == $group) ? "disabled='disabled'" : null)." onclick=\"document.getElementById('group').value = this.value;\">";
+			echo "			<input type='button' class='btn' title=\"".$text['label-call_group']."\" value=\"".$group."\" ".(($_REQUEST['group'] == $group) ? "disabled='disabled'" : null)." onclick=\"document.getElementById('group').value = this.value;\">";
 		}
 	}
+	echo "				</td>";
 }
 
+echo "				</tr>";
+echo "			</table>";
+
 echo "		</td>";
 echo "	</tr>";
 echo "</table>";
@@ -256,7 +285,7 @@ foreach ($activity as $extension => $ext) {
 	$block .= "		</td>";
 	$block .= "		<td class='op_ext_info ".$style."'>";
 	if ($dir_icon != '') {
-		$block .= "			<img src='resources/images/".$dir_icon.".png' align='right' style='margin-top: 3px; margin-right: 1px; width: 12px; height: 12px;' draggable='false'>";
+		$block .= "			<img src='resources/images/".$dir_icon.".png' align='right' style='margin-top: 3px; margin-right: 1px; width: 12px; height: 12px; cursor: help;' draggable='false' alt=\"".$text['label-call_direction']."\" title=\"".$text['label-call_direction']."\" ".$onhover_pause_refresh.">";
 	}
 	$block .= "			<span class='op_user_info'>";
 	if ($ext['effective_caller_id_name'] != '' && $ext['effective_caller_id_name'] != $extension) {
@@ -275,15 +304,15 @@ foreach ($activity as $extension => $ext) {
 			$call_identifier_record = $ext['call_uuid'];
 			$rec_file = $_SESSION['switch']['recordings']['dir']."/archive/".date("Y")."/".date("M")."/".date("d")."/".$call_identifier_record.".wav";
 			if (file_exists($rec_file)) {
-				$block .= 		"<img src='resources/images/recording.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: help;' title=\"".$text['label-recording']."\">";
+				$block .= 		"<img src='resources/images/recording.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: help;' title=\"".$text['label-recording']."\" ".$onhover_pause_refresh.">";
 			}
 			else {
-				$block .= 		"<img src='resources/images/record.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: pointer;' title=\"".$text['label-record']."\" onclick=\"record_call('".$call_identifier_record."');\">";
+				$block .= 		"<img src='resources/images/record.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: pointer;' title=\"".$text['label-record']."\" onclick=\"record_call('".$call_identifier_record."');\" ".$onhover_pause_refresh.">";
 			}
 		}
 		//eavesdrop
-		if (permission_exists('operator_panel_eavesdrop') && $ext_state == 'active' && !in_array($extension, $_SESSION['user']['extensions'])) {
-			$block .= 			"<img src='resources/images/eavesdrop.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: pointer;' title='".$text['label-eavesdrop']."' onclick=\"eavesdrop_call('".$extension."','".$call_identifier."');\">";
+		if (permission_exists('operator_panel_eavesdrop') && $ext_state == 'active' && sizeof($_SESSION['user']['extensions']) > 0 && !in_array($extension, $_SESSION['user']['extensions'])) {
+			$block .= 			"<img src='resources/images/eavesdrop.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: pointer;' title='".$text['label-eavesdrop']."' onclick=\"eavesdrop_call('".$extension."','".$call_identifier."');\" ".$onhover_pause_refresh.">";
 		}
 		//kill
 		if (in_array($extension, $_SESSION['user']['extensions']) || permission_exists('operator_panel_kill')) {
@@ -296,7 +325,7 @@ foreach ($activity as $extension => $ext) {
 			else {
 				$call_identifier_kill = $call_identifier;
 			}
-			$block .= 			"<img src='resources/images/kill.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: pointer;' title='".$text['label-kill']."' onclick=\"kill_call('".$call_identifier_kill."');\">";
+			$block .= 			"<img src='resources/images/kill.png' style='width: 12px; height: 12px; border: none; margin: 4px 0px 0px 5px; cursor: pointer;' title='".$text['label-kill']."' onclick=\"kill_call('".$call_identifier_kill."');\" ".$onhover_pause_refresh.">";
 		}
 		$block .= "			</td></tr></table>";
 		$block .= "			<strong>".$call_name."</strong><br>".$call_number;
diff --git a/app/operator_panel/resources/images/refresh_active.gif b/app/operator_panel/resources/images/refresh_active.gif
new file mode 100644
index 0000000000000000000000000000000000000000..305457831c3f47939d634650660e859f50f18224
GIT binary patch
literal 1079
zcmZ?wbhEHb6krfw_{_lY|NsA0U~uKimGkG%KYaM`#fum3-o5+$`SYz?x4wP*cIM0(
z1|*>PpWDwhB-q(8z|~04fSC~}rT9<ExhOTUBsE2$JhLQ2Au%hlA}2pFMK3ciEuTU0
zCkrPRP?ZkI5Rjz|EZPDmJXi0v@IScw{~ZUBV~q(9Bj$yB&03+bZ_U$nAA7cM;`+Qm
z!QEL$s(%Ux0sS!(d5%z`|4yRFNe5ExH$=F9PLqt=M4lGWzNa(8v@;j2QaF`YyWJ#b
z^Ja0?W5Rh3C;HM(=2&S8V)KO=k||3R+5=UX9a|4X%zLTTv7~d=?K{^D^fu~6>$q3n
zO>tew&yZDRa$!Y@S0^yIF#{CID4C^TqZC^&!;E6k-dQ&1{8}lV<;)-2jBdSFW47#`
z1vIJ`t5L{)gBT?kmRz|^`|7L}S{*99_jCT;vIy5ToB7wlqaU~5kYZS7nL_(UfrqBk
z(zDj8X?3K$2`jK(z145C(S#4nG^P4aV2xolq_Ej0;4GAuT$!{|vttSOYJI8o;oR@$
zJ^Oz^L6r$xSRh*s)EXo~qSeR&uoa}AU5JbTK#mcJDN5wV2$E5AwtyYvL~c4k^4lFJ
R9?wLX4uT2S8kB9p001&weI)<@

literal 0
HcmV?d00001

diff --git a/app/operator_panel/resources/images/refresh_paused.png b/app/operator_panel/resources/images/refresh_paused.png
new file mode 100644
index 0000000000000000000000000000000000000000..38937ec1f222094efb05cd3d3c634f752f84deb2
GIT binary patch
literal 501
zcmV<R0Sf+!P)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV00004b3#c}2nYxW
zd<bNS00009a7bBm000D?000D?0em!Tp#T5?8FWQhbW?9;ba!ELWdL_~cP?peYja~^
zaAhuUa%Y?FJQ@H10dh%1K~y-6rIWvEltC25e=}!3w(xD#?UZ!e`350{&!E`p3kX`-
z3nFNrppB)NN020yi+`iwCXwBpxpOVX{jw|U*JNN|?wxzioO57;yK|M5){EV}-G?{F
zH*N!*&t~Od|LvpEXcWie>wBx2>F4R;%NMVn_aJxg_miiOUzd`-l<Y?*AAM)%)}6^@
za`(sSch7n0XXi7&|KQ%Ub<Bo>3gn!7VkA&I7c*+DB!%r3QpAguz80Ve)s0dLW`<JQ
zPT)aqJ%K|KQNpWZR;bm8QQHY3U}mid?NUVCom!g(g*ZT<=+$e(dtgQ3I9847mDmj^
zST5%I^yfDK=JQ1##M#AfxCnrwIG`X%q^`A+6;KQD5)_6rP!uV3?IIZhqC{FtUK-5c
zayX>~5+e4hT7Q6`Q>6PhY?hE(2<r->1}udC6bM0N(*gquPL7X19qhk(2T)25%jM!%
r*LBxEygxiz%}l?3`LprpRloCJ0R6KCvd?rv00000NkvXXu0mjfpda3S

literal 0
HcmV?d00001

diff --git a/resources/functions.php b/resources/functions.php
index 61eb9db077..f105132d0c 100644
--- a/resources/functions.php
+++ b/resources/functions.php
@@ -776,7 +776,7 @@ function format_string ($format, $data) {
 	}
 
 //browser detection without browscap.ini dependency
-	function http_user_agent() {
+	function http_user_agent($info = '') {
 		$u_agent = $_SERVER['HTTP_USER_AGENT'];
 		$bname = 'Unknown';
 		$platform = 'Unknown';
@@ -851,13 +851,21 @@ function format_string ($format, $data) {
 		// check if we have a number
 			if ($version==null || $version=="") {$version="?";}
 
-		return array(
-			'userAgent' => $u_agent,
-			'name'      => $bname,
-			'version'   => $version,
-			'platform'  => $platform,
-			'pattern'    => $pattern
-		);
+		switch ($info) {
+			case "agent": return $u_agent; break;
+			case "name": return $bname; break;
+			case "version": return $version; break;
+			case "platform": return $platform; break;
+			case "pattern": return $pattern; break;
+			default :
+				return array(
+					'userAgent' => $u_agent,
+					'name' => $bname,
+					'version' => $version,
+					'platform' => $platform,
+					'pattern' => $pattern
+				);
+		}
 	}
 
 //tail php function for non posix systems