erpnext

mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 07:28:39 +00:00

Files

Mihir Kandoi 39eb34f333 refactor(postgres): address Greptile review on warranty_claim on_cancel

- Filter the parent Maintenance Visit's docstatus (mv.docstatus != 2) via a qb join, as
  the original SQL did, instead of the child Maintenance Visit Purpose row's docstatus.
  Synced in normal flows, but exactly faithful to the original intent.
- Add a limit(500) to bound the read on a cancellation path.

Adds two both-engine tests calling on_cancel directly: an active (non-cancelled) visit
blocks the claim cancel; with no referencing visit the claim is marked Cancelled.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-19 13:13:14 +05:30

doctype

refactor(postgres): address Greptile review on warranty_claim on_cancel

2026-06-19 13:13:14 +05:30

page

chore: remove utf-8 compat code

2021-11-05 11:16:29 +05:30

report

refactor(postgres): port Support module queries to the query builder

2026-06-19 12:58:52 +05:30

web_form

fix: Hold_to_On_Hold