erpnext

mirror of https://github.com/frappe/erpnext.git synced 2026-08-23 20:16:40 +00:00

Files

Mihir Kandoi 0583349ae4 test: convert aggregate/pluck/positional raw SQL to ORM

A deeper re-audit (with an adversarial skeptic) of the queries left raw
in the prior commit found more that have exact ORM equivalents:

- scalar SUM/MAX  -> frappe.qb + Sum/Max .run()[0][0]
- SUM ... GROUP BY -> frappe.qb .groupby().select(Sum().as_()) run(as_dict)
- name IN (values) -> get_all(filters={'f': ['in', ...]})
- sql_list(select col) -> get_all(pluck='col')
- bulk UPDATE ... = NULL/value -> frappe.db.set_value(filters, field, val)
- positional as_list reads -> get_all(..., as_list=True) (+ sorted())

Note: get_value(dt, filters, 'sum(x)') and get_all(fields=['sum(x)'])
are rejected by frappe ('SQL functions are not allowed as strings'), so
aggregates go through frappe.qb. get_all(as_list=True) returns a tuple
(not a list), so consumers that mutate use sorted().

All affected test modules pass on MariaDB.

2026-06-26 11:34:31 +05:30

dashboard_chart

chore: adapt filter signature to frappe/frappe#28218 (#44553 )

2024-12-05 11:32:32 +00:00

doctype

test: convert aggregate/pluck/positional raw SQL to ORM

2026-06-26 11:34:31 +05:30

manufacturing_dashboard/manufacturing

feat: Exported manufacturing dashboard (#22626 )

2020-07-22 16:58:17 +05:30

module_onboarding/manufacturing_onboarding

fix: patch to complete onboarding stpes for existing records