mirror of
https://github.com/frappe/erpnext.git
synced 2026-08-18 17:08:42 +00:00
99152b8300
The 'Create Multiple Variants' dialog rendered one checkbox per attribute value and read the numeric config from the variant attribute child row. This broke in several ways: - A template whose attribute was made numeric after being added kept numeric_values=0 on the child row, so the dialog treated it as non-numeric, queried the empty Item Attribute Value table, and showed no values. - Enumerating a large range (e.g. 1-100000) into checkboxes froze the browser. Rework the dialog: - Read numeric_values / from_range / to_range / increment from the Item Attribute master, and guard increment > 0. - Replace the checkbox-per-value list with one MultiSelectPills per attribute, with a search placeholder. - Stop enumerating numeric ranges: preview the first few values and validate typed input against the range on demand, so huge ranges stay instant. - Block variant creation with a modal error if any selected value or pending input is invalid (out of range, off-increment, or not a number), so garbage like '00A' can't reach creation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>