mirror of
https://github.com/frappe/erpnext.git
synced 2026-08-25 04:53:01 +00:00
549a24f7b9
The Postgres test job is label-gated, so it does not run on every PR. This adds an always-on pre-commit hook that statically flags the *mechanical* breaks: MySQL-only functions (timestamp(date,time), timediff, str_to_date, date_format/add/sub, group_concat, period_diff, SQL IF()), SHOW INDEX/TABLES/COLUMNS, single-quoted aliases, UPDATE..JOIN, interpolated/f-string SQL carrying MySQL-isms, set_value/db_set(<Check>, bool), and MySQL SHOW INDEX result keys. It deliberately does NOT flag the framework auto-translations (ifnull->coalesce, backtick/locate/REGEXP, .like()->ILIKE) nor the *semantic* divergences (loose GROUP BY, case-sensitive ==/IN, NULL ordering, tiebreakers) — those need the test suite, which remains the backstop. AST + structure-gated regex keep false positives near zero (docstrings and prose skipped); '# pg-ok' exempts intentional MariaDB-only branches. Scoped to erpnext/ excluding patches/. Includes a unit test of the checker.
85 lines
2.5 KiB
YAML
85 lines
2.5 KiB
YAML
exclude: 'node_modules|.git'
|
|
default_stages: [pre-commit]
|
|
fail_fast: false
|
|
|
|
|
|
repos:
|
|
- repo: https://github.com/pre-commit/pre-commit-hooks
|
|
rev: v4.3.0
|
|
hooks:
|
|
- id: trailing-whitespace
|
|
files: "erpnext.*"
|
|
exclude: ".*json$|.*txt$|.*csv|.*md"
|
|
- id: check-yaml
|
|
- id: no-commit-to-branch
|
|
args: ['--branch', 'develop']
|
|
- id: check-merge-conflict
|
|
- id: check-ast
|
|
- id: check-json
|
|
- id: check-toml
|
|
- id: check-yaml
|
|
- id: debug-statements
|
|
|
|
- repo: https://github.com/pre-commit/mirrors-prettier
|
|
rev: v2.7.1
|
|
hooks:
|
|
- id: prettier
|
|
types_or: [javascript, vue, scss]
|
|
# Ignore any files that might contain jinja / bundles
|
|
exclude: |
|
|
(?x)^(
|
|
erpnext/public/dist/.*|
|
|
cypress/.*|
|
|
.*node_modules.*|
|
|
.*boilerplate.*|
|
|
erpnext/templates/includes/.*
|
|
)$
|
|
|
|
- repo: https://github.com/pre-commit/mirrors-eslint
|
|
rev: v8.44.0
|
|
hooks:
|
|
- id: eslint
|
|
types_or: [javascript]
|
|
args: ['--quiet']
|
|
# Ignore any files that might contain jinja / bundles
|
|
exclude: |
|
|
(?x)^(
|
|
erpnext/public/dist/.*|
|
|
cypress/.*|
|
|
.*node_modules.*|
|
|
.*boilerplate.*|
|
|
erpnext/public/js/controllers/.*|
|
|
erpnext/templates/pages/order.js|
|
|
erpnext/templates/includes/.*
|
|
)$
|
|
|
|
- repo: https://github.com/astral-sh/ruff-pre-commit
|
|
rev: v0.2.0
|
|
hooks:
|
|
- id: ruff
|
|
name: "Run ruff import sorter"
|
|
args: ["--select=I", "--fix"]
|
|
|
|
- id: ruff
|
|
name: "Run ruff linter"
|
|
|
|
- id: ruff-format
|
|
name: "Run ruff formatter"
|
|
|
|
- repo: local
|
|
hooks:
|
|
- id: postgres-compat
|
|
name: "PostgreSQL compatibility (static check)"
|
|
description: "Flags MySQL-only SQL that breaks on Postgres; the label-gated PG test job is the backstop for semantic divergences."
|
|
entry: .github/helper/postgres_compat.py
|
|
language: script
|
|
files: ^erpnext/.*\.py$
|
|
# patches/ are historical, version-gated migrations (skipped on fresh Postgres installs);
|
|
# out of scope for the always-on gate. test_postgres_compat.py holds intentional bad-SQL fixtures.
|
|
exclude: ^erpnext/patches/|^erpnext/tests/test_postgres_compat\.py$
|
|
|
|
ci:
|
|
autoupdate_schedule: weekly
|
|
skip: []
|
|
submodules: false
|