Nabin Hait 498cd2b371 refactor(sales_invoice): extract non-GL services (Phase 7) ...

Split the sales_invoice.py monolith into focused service modules under
sales_invoice/services/:

- fixed_assets.py      — FixedAssetService (depreciation, disposal, split)
- inter_company.py     — validate/link/unlink inter-company docs
- loyalty.py           — LoyaltyService (earn, redeem, delete points)
- pos.py               — POSService + POS free functions
- status.py            — StatusService + is_overdue / get_discounting_status
- timesheet_billing.py — TimesheetBillingService

Lifecycle hooks (validate/on_submit/on_cancel) call services directly;
no thin shims. The 7 methods POS Invoice calls via self.* are kept on
the class with an explicit comment. @frappe.whitelist() doc-methods and
framework hooks (set_status, set_indicator) stay on the class.

sales_invoice.py: 2156 → 1205 lines. All 29 snapshot + 121 SI tests green.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-31 12:52:26 +05:30

..

accounts

refactor(sales_invoice): extract non-GL services (Phase 7)

2026-05-31 12:52:26 +05:30

assets

refactor(asset): move mapping functions to mapper.py

2026-05-29 13:38:00 +05:30

bulk_transaction

refactor: replace IntegrationTestCase with ERPNextTestCase repo-wide

2026-03-18 20:59:35 +05:30

buying

fix(purchase_order): re-export get_mapped_subcontracting_order for test compatibility

2026-05-29 16:56:40 +05:30

change_log

fix: add change log for bug fix in Additional Discount functionality

2025-06-09 18:06:16 +05:30

commands

…

communication

refactor(treewide): formatting and ruff fixes, + manually enabled F401

2024-03-27 16:06:04 +05:30

config

…

controllers

refactor: extract child item update cluster into ChildItemUpdater service

2026-05-28 20:38:25 +05:30

crm

refactor(lead): move mapping functions to mapper.py

2026-05-29 13:26:31 +05:30

desktop_icon

fix(banking): include paid purchase invoices in reports and bank clearance (#52675)

2026-03-17 10:17:32 +05:30

domains

…

edi

test(Code List): check content, not filename (#54490)

2026-04-23 15:40:22 +00:00

erpnext_integrations

chore: migrate Address/Contact custom fields from JSON fixtures to install (#55084)

2026-05-20 08:39:24 +00:00

gettext

feat: add extractor for setup wizard txt files

2024-08-17 01:50:55 +02:00

locale

chore: update POT file (#55235)

2026-05-24 14:47:38 +02:00

maintenance

refactor(test): remove explicit call to master data setup

2026-03-18 20:59:38 +05:30

manufacturing

refactor(job_card): move mapping functions to mapper.py

2026-05-29 13:20:50 +05:30

patches

chore: migrate Address/Contact custom fields from JSON fixtures to install (#55084)

2026-05-20 08:39:24 +00:00

portal

fix: set customer details on customer creation at login (#53509)

2026-03-19 12:04:31 +05:30

projects

fix(project): update customer and sales order as no copy

2026-05-22 16:47:46 +05:30

public

fix: corrected the pricing rule taking the wrong value (#54894)

2026-05-21 12:04:45 +05:30

quality_management

refactor: replace IntegrationTestCase with ERPNextTestCase repo-wide

2026-03-18 20:59:35 +05:30

regional

refactor: convert payment schedule and billing validation to service objects

2026-05-28 17:13:23 +05:30

report_center

feat: workspace sidebars and desktop icons for erpnext modules

2025-11-17 13:20:57 +05:30

selling

refactor(customer): move mapping functions to mapper.py

2026-05-29 12:19:09 +05:30

setup

feat(company): add Stock Delivered But Not Billed account configuration

2026-05-22 01:13:12 +05:30

shopping_cart

…

startup

Merge pull request #54946 from Shllokkk/letter-head-fix

2026-05-21 20:05:56 +05:30

stock

refactor(pick_list): move mapping functions to mapper.py

2026-05-29 12:45:32 +05:30

subcontracting

refactor(subcontracting_receipt): move mapping functions to mapper.py

2026-05-29 13:28:37 +05:30

support

fix: set letter_head_for for letterhead

2026-04-20 16:58:35 +05:30

telephony

refactor(test): move commits inside test guard clause

2026-03-24 11:57:02 +05:30

templates

fix(templates): using correct syntax of include in projects.html

2026-03-25 14:55:05 +05:30

tests

fix: consider batchwise valuation in stock ageing report (#54919)

2026-05-24 12:27:48 +05:30

utilities

refactor: remove old subcontracting flow (#54717)

2026-05-04 14:06:59 +05:30

workspace_sidebar

fix: use route_options for Credit Note and Debit Note sidebar links (#55026)

2026-05-19 23:13:30 +05:30

www

feat: new banking module (#54720)

2026-05-09 23:14:58 +05:30

__init__.py

build: Bump dev version

2026-01-13 12:15:21 +05:30

.stylelintrc

…

deprecation_dumpster.py

feat: add more fine-grained deprecation warning control (#44307)

2024-11-24 00:37:42 +01:00

exceptions.py

feat: dr/cr amounts in reporting_currency on gl entries

2025-09-03 12:36:44 +05:30

hooks.py

chore: remove leaderboard dead code (#55030)

2026-05-19 21:07:52 +05:30

modules.txt

feat: new DocTypes "Code List" and "Common Code" (#43425)

2024-11-17 15:05:33 +01:00

patches.txt

chore: migrate Address/Contact custom fields from JSON fixtures to install (#55084)

2026-05-20 08:39:24 +00:00