Files
erpnext/erpnext/stock/dashboard/item_dashboard.py
Mihir Kandoi 497a0abb07 refactor(stock): build item-group filter via qb in item_dashboard
Replace the raw EXISTS subquery (items within an item-group subtree) with
frappe.qb (item_group.isin(subquery)). Same result on MariaDB; valid under
Postgres' stricter SQL.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 00:00:57 +05:30

100 lines
3.2 KiB
Python

import frappe
from frappe.desk.reportview import build_match_conditions
from frappe.utils import cint, escape_html, flt
from erpnext.stock.doctype.stock_reservation_entry.stock_reservation_entry import (
get_sre_reserved_qty_for_items_and_warehouses as get_reserved_stock_details,
)
@frappe.whitelist()
def get_data(
item_code: str | None = None,
warehouse: str | None = None,
item_group: str | None = None,
start: int = 0,
sort_by: str = "actual_qty",
sort_order: str = "desc",
):
"""Return data to render the item dashboard"""
filters = []
if item_code:
filters.append(["item_code", "=", item_code])
if warehouse:
filters.append(["warehouse", "=", warehouse])
if item_group:
lft, rgt = frappe.db.get_value("Item Group", item_group, ["lft", "rgt"])
item = frappe.qb.DocType("Item")
item_group_dt = frappe.qb.DocType("Item Group")
items = (
frappe.qb.from_(item)
.select(item.name)
.where(
item.item_group.isin(
frappe.qb.from_(item_group_dt)
.select(item_group_dt.name)
.where((item_group_dt.lft >= lft) & (item_group_dt.rgt <= rgt))
)
)
.run(pluck="name")
)
filters.append(["item_code", "in", items])
try:
# check if user has any restrictions based on user permissions on warehouse
if build_match_conditions("Warehouse", user=frappe.session.user):
filters.append(["warehouse", "in", [w.name for w in frappe.get_list("Warehouse")]])
except frappe.PermissionError:
# user does not have access on warehouse
return []
items = frappe.db.get_all(
"Bin",
fields=[
"item_code",
"warehouse",
"projected_qty",
"reserved_qty",
"reserved_qty_for_production",
"reserved_qty_for_sub_contract",
"actual_qty",
"valuation_rate",
],
or_filters={
"projected_qty": ["!=", 0],
"reserved_qty": ["!=", 0],
"reserved_qty_for_production": ["!=", 0],
"reserved_qty_for_sub_contract": ["!=", 0],
"actual_qty": ["!=", 0],
},
filters=filters,
order_by=sort_by + " " + sort_order,
limit_start=start,
limit_page_length=21,
)
item_code_list = [item_code] if item_code else [i.item_code for i in items]
warehouse_list = [warehouse] if warehouse else [i.warehouse for i in items]
sre_reserved_stock_details = get_reserved_stock_details(item_code_list, warehouse_list)
precision = cint(frappe.db.get_single_value("System Settings", "float_precision"))
for item in items:
item.update(
{
"item_code": escape_html(item.item_code),
"item_name": escape_html(frappe.get_cached_value("Item", item.item_code, "item_name")),
"stock_uom": escape_html(frappe.get_cached_value("Item", item.item_code, "stock_uom")),
"warehouse": escape_html(item.warehouse),
"disable_quick_entry": frappe.get_cached_value("Item", item.item_code, "has_batch_no")
or frappe.get_cached_value("Item", item.item_code, "has_serial_no"),
"projected_qty": flt(item.projected_qty, precision),
"reserved_qty": flt(item.reserved_qty, precision),
"reserved_qty_for_production": flt(item.reserved_qty_for_production, precision),
"reserved_qty_for_sub_contract": flt(item.reserved_qty_for_sub_contract, precision),
"actual_qty": flt(item.actual_qty, precision),
"reserved_stock": flt(sre_reserved_stock_details.get((item.item_code, item.warehouse))),
}
)
return items