erpnext

mirror of https://github.com/frappe/erpnext.git synced 2026-07-27 06:28:18 +00:00

Files

Mihir Kandoi b93a3bca16 ci(postgres): fail setup if pg_ctl stop fails before baking the datadir

The "Stop DB and stage datadir" step swallowed a failed `pg_ctl -m fast -w
stop` with `|| true`, then moved and tarred the PGDATA regardless. A stop
that times out or errors would bake a still-running, crash-inconsistent
cluster into the artifact every test shard consumes — and with
full_page_writes off, crash recovery can't repair torn pages. Drop the
`|| true` so a failed stop fails the job, mirroring the MariaDB sister's
"don't bake a dirty datadir" guard.

Also drop the redundant `ALTER SYSTEM SET fsync/synchronous_commit/
full_page_writes = off` block from install.sh. Its comment claimed the
postgres workflow "runs a service-container DB and never calls start-db.sh",
but it does call start-db.sh, which already applies those flags via `-o` on
every postgres start (setup job and each shard). The block was a no-op and
its justification was factually wrong.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-06-29 21:29:22 +05:30

.flake8_strict

chore: ignore b028

2023-01-17 10:56:55 +05:30

documentation.py

fix: added docs.frappe.io in documentation_url (#44776 )

2024-12-18 11:58:22 +00:00

hydrate.sh

ci: address self-review findings

2026-06-25 13:24:15 +05:30

install.sh

ci(postgres): fail setup if pg_ctl stop fails before baking the datadir