erpnext

mirror of https://github.com/frappe/erpnext.git synced 2026-08-04 18:23:05 +00:00

Files

Mihir Kandoi f751f80158 ci(postgres): flag division by a possibly-zero divisor in the compat guard (#56363 )

Adds the division-by-zero divergence class to the PG-compat review tooling:
on a divisor that the data can drive to 0 (e.g. Sum(a)/Sum(b)), MariaDB
returns NULL for division by zero while PostgreSQL raises `division by zero`
and aborts the query. The portable fix is to wrap the divisor in
NullIf(divisor, 0), which yields NULL on both engines (matching MariaDB).

- .greptile/config.json: add it to the "would ERROR on PostgreSQL" list.
- .github/POSTGRES_COMPATIBILITY.md: document it under §1 (hard breaks).
- .github/helper/postgres_compat.py: note it in the docstring as a
  deliberately-not-statically-checked semantic divergence (data-dependent,
  like integer-division intent), so it stays a reviewer/Greptile concern.

Tooling-only; no source query changes. The instance fix shipped in #56361.

2026-06-23 12:00:50 +00:00

helper

ci(postgres): flag division by a possibly-zero divisor in the compat guard (#56363 )

2026-06-23 12:00:50 +00:00

ISSUE_TEMPLATE

Revise feature request template for clarity and structure (#54386 )

2026-04-19 07:17:22 +00:00

workflows

Merge pull request #56286 from nabinhait/ci-patch-test-no-workers-during-migrate

2026-06-22 17:05:15 +05:30

CONTRIBUTING.md

Revise CONTRIBUTING.md for clarity and formatting (#54739 )