mirror of
https://github.com/frappe/erpnext.git
synced 2026-09-17 18:45:20 +00:00
* fix(banking): reset scroll on searching accounts * fix(banking): show only past dates in date filter * fix(banking): clean up line heights and remove beta badge * fix(banking): show accurate count of import progress fix(banking): show latest 20 imports instead of 10 * fix(banking): layout sizing needs to be preserved on page change * fix(banking): cleaner bank balance UI * fix(banking): correctly parse Cr/Dr values in statement importer * Update banking/src/components/features/BankReconciliation/BankBalance.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
233 lines
8.8 KiB
TypeScript
233 lines
8.8 KiB
TypeScript
import { Button } from "@/components/ui/button"
|
|
import { Command, CommandEmpty, CommandGroup, CommandInput, CommandItem, CommandList } from "@/components/ui/command"
|
|
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover"
|
|
import { useCurrentCompany } from "@/hooks/useCurrentCompany"
|
|
import _ from "@/lib/translate"
|
|
import { cn } from "@/lib/utils"
|
|
import { useFrappeGetDocList } from "frappe-react-sdk"
|
|
import Fuse from "fuse.js"
|
|
import { ChevronDownIcon } from "lucide-react"
|
|
import { useLayoutEffect, useMemo, useRef, useState } from "react"
|
|
import { FormControl } from "../ui/form"
|
|
import useResetScrollOnSearch from "@/hooks/useResetScrollOnSearch"
|
|
|
|
|
|
export interface AccountsDropdownProps {
|
|
root_type?: ('Asset' | 'Liability' | 'Equity' | 'Income' | 'Expense')[],
|
|
report_type?: 'Balance Sheet' | 'Profit and Loss',
|
|
account_type?: string[],
|
|
value?: string,
|
|
onChange?: (value: string) => void,
|
|
readOnly?: boolean,
|
|
disabled?: boolean,
|
|
company?: string,
|
|
filterFunction?: (account: Account) => boolean,
|
|
// If true, the component will be wrapped in a FormControl component
|
|
useInForm?: boolean,
|
|
buttonClassName?: string,
|
|
size?: 'sm' | 'md' | 'lg',
|
|
}
|
|
/**
|
|
* Component to select an account - supports fuzzy search
|
|
* @param root_type - The root type of the account
|
|
* @param report_type - The report type of the account
|
|
* @param account_type - The type of the account
|
|
* @param value - The value of the account field
|
|
* @param onChange - The function to call when the value changes
|
|
* @returns
|
|
*/
|
|
const AccountsDropdown = ({ root_type, report_type, account_type, value, onChange, readOnly, disabled, company, filterFunction, useInForm, buttonClassName, size = 'md' }: AccountsDropdownProps) => {
|
|
|
|
const { data } = useGetAccounts(root_type, report_type, account_type, company, filterFunction)
|
|
|
|
const groupedAccounts = useMemo(() => {
|
|
if (!data) return []
|
|
|
|
const grouped: Record<string, Account[]> = data.reduce((acc, account) => {
|
|
const parentAccount = account.parent_account
|
|
if (!parentAccount) return acc
|
|
|
|
if (!acc[parentAccount]) {
|
|
acc[parentAccount] = []
|
|
}
|
|
|
|
acc[parentAccount].push(account)
|
|
return acc
|
|
}, {} as Record<string, Account[]>)
|
|
|
|
|
|
return Object.entries(grouped).map(([parentAccount, accounts]) => ({
|
|
// Remove the last abbreviation from the parent account name like "Assets - TCC" should be "Assets", and "Assets - USD - TCC" should be "Assets - USD"
|
|
parentAccount: parentAccount.split(" - ").slice(0, -1).join(" - "),
|
|
accounts
|
|
}))
|
|
|
|
}, [data])
|
|
|
|
const searchIndex = useMemo(() => {
|
|
|
|
if (!data) {
|
|
return null
|
|
}
|
|
|
|
return new Fuse(data, {
|
|
keys: ['name'],
|
|
threshold: 0.5,
|
|
includeScore: true
|
|
})
|
|
}, [data])
|
|
|
|
const [search, setSearch] = useState("")
|
|
|
|
const recommendedAccounts = useMemo(() => {
|
|
|
|
if (!searchIndex || !search) {
|
|
return []
|
|
}
|
|
|
|
return searchIndex.search(search).map((result) => result.item)
|
|
|
|
}, [searchIndex, search])
|
|
|
|
const [open, setOpen] = useState(false)
|
|
|
|
const onOpenChange = (open: boolean) => {
|
|
if (readOnly) return
|
|
setOpen(open)
|
|
// setSearch("")
|
|
}
|
|
|
|
const onSelect = (value: string) => {
|
|
onChange?.(value)
|
|
setOpen(false)
|
|
setSearch(value)
|
|
}
|
|
|
|
const buttonRef = useRef<HTMLButtonElement>(null)
|
|
|
|
// Searching replaces the grouped list with a short result list, so pin the scroll back to
|
|
// the top - otherwise the auto-selected first result can be out of view.
|
|
const listRef = useResetScrollOnSearch(search)
|
|
|
|
const [width, setWidth] = useState(320)
|
|
|
|
useLayoutEffect(() => {
|
|
if (buttonRef.current) {
|
|
setWidth(buttonRef.current.getBoundingClientRect().width)
|
|
}
|
|
}, [])
|
|
|
|
return (
|
|
<Popover open={open} onOpenChange={onOpenChange} modal={true}>
|
|
<PopoverTrigger asChild>
|
|
{useInForm ? <FormControl>
|
|
<Button
|
|
variant="subtle"
|
|
type='button'
|
|
size={size}
|
|
role="combobox"
|
|
ref={buttonRef}
|
|
tabIndex={0}
|
|
disabled={disabled || readOnly}
|
|
aria-readonly={readOnly}
|
|
aria-expanded={open}
|
|
className={cn("w-full justify-between font-normal",
|
|
readOnly ? "bg-surface-gray-1 pointer-events-none" : ""
|
|
, buttonClassName)}>
|
|
{value || _('Select Account')}
|
|
|
|
<ChevronDownIcon className="ms-2 h-4 w-4 shrink-0 opacity-50" />
|
|
</Button>
|
|
</FormControl>
|
|
: <Button
|
|
variant="subtle"
|
|
size={size}
|
|
type='button'
|
|
role="combobox"
|
|
ref={buttonRef}
|
|
disabled={disabled}
|
|
aria-expanded={open}
|
|
className={cn("w-full justify-between font-normal",
|
|
readOnly ? "bg-surface-gray-1" : ""
|
|
)}>
|
|
{value || _('Select Account')}
|
|
|
|
<ChevronDownIcon className="ms-2 h-4 w-4 shrink-0 opacity-50" />
|
|
</Button>}
|
|
</PopoverTrigger>
|
|
<PopoverContent className="p-0" style={{ minWidth: width }} align="start">
|
|
<Command shouldFilter={false} className="w-full">
|
|
<CommandInput placeholder={_("Search account...")} onValueChange={setSearch} value={search} />
|
|
<CommandList ref={listRef}>
|
|
<CommandEmpty>{_("No accounts found.")}</CommandEmpty>
|
|
|
|
{recommendedAccounts.length > 0 && (
|
|
<CommandGroup heading={_("Search Results")}>
|
|
{recommendedAccounts.map((account) => (
|
|
<CommandItem key={account.name} onSelect={() => onSelect(account.name)}>{account.name}</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
)}
|
|
|
|
{!search && groupedAccounts.map((group) => (
|
|
<CommandGroup key={group.parentAccount} heading={group.parentAccount}>
|
|
{group.accounts.map((account) => (
|
|
<CommandItem key={account.name} onSelect={() => onSelect(account.name)}>{account.name}</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
))}
|
|
|
|
</CommandList>
|
|
</Command>
|
|
</PopoverContent>
|
|
|
|
</Popover>
|
|
)
|
|
}
|
|
|
|
|
|
interface Account {
|
|
name: string
|
|
root_type: 'Asset' | 'Liability' | 'Equity' | 'Income' | 'Expense'
|
|
report_type: 'Balance Sheet' | 'Profit and Loss'
|
|
account_type: string
|
|
account_currency: string
|
|
parent_account: string
|
|
}
|
|
|
|
export const useGetAccounts = (root_type?: ('Asset' | 'Liability' | 'Equity' | 'Income' | 'Expense')[], report_type?: 'Balance Sheet' | 'Profit and Loss', account_type?: string[], company?: string,
|
|
filterFunction?: (account: Account) => boolean) => {
|
|
|
|
const currentCompany = useCurrentCompany()
|
|
const { data, isLoading, error, mutate } = useFrappeGetDocList<Account>("Account", {
|
|
fields: ["name", "root_type", "report_type", "account_type", "account_currency", "parent_account"],
|
|
filters: [["is_group", "=", 0], ["disabled", "=", 0], ["company", "=", company ?? currentCompany]],
|
|
limit: 1000,
|
|
orderBy: {
|
|
"field": "root_type",
|
|
// @ts-expect-error - we can pass in additional fields to orderBy
|
|
"order": "asc, account_number asc"
|
|
}
|
|
}, `accounts-${company ?? currentCompany}`, {
|
|
revalidateIfStale: false,
|
|
revalidateOnFocus: false,
|
|
revalidateOnReconnect: false,
|
|
})
|
|
|
|
const filteredData = useMemo(() => {
|
|
|
|
return data?.filter((account) => {
|
|
if (root_type && !root_type.includes(account.root_type)) return false
|
|
if (report_type && account.report_type !== report_type) return false
|
|
if (account_type && !account_type.includes(account.account_type)) return false
|
|
|
|
if (filterFunction) return filterFunction(account)
|
|
return true
|
|
}) ?? []
|
|
|
|
}, [data, root_type, report_type, account_type, filterFunction])
|
|
|
|
return { data: filteredData, isLoading, error, mutate }
|
|
}
|
|
|
|
export default AccountsDropdown |