# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors # License: GNU General Public License v3. See license.txt import frappe from frappe import _ from frappe.model.document import Document from frappe.utils import comma_or, flt, get_link_to_form, getdate, now, nowdate, safe_div class OverAllowanceError(frappe.ValidationError): pass def validate_status(status, options): if status not in options: frappe.throw(_("Status must be one of {0}").format(comma_or(options))) status_map = { "Lead": [ ["Lost Quotation", "has_lost_quotation"], ["Opportunity", "has_opportunity"], ["Quotation", "has_quotation"], ["Converted", "has_customer"], ], "Opportunity": [ ["Lost", "eval:self.status=='Lost'"], ["Lost", "has_lost_quotation"], ["Quotation", "has_active_quotation"], ["Converted", "has_ordered_quotation"], ["Closed", "eval:self.status=='Closed'"], ], "Quotation": [ ["Draft", None], ["Open", "eval:self.docstatus==1"], ["Lost", "eval:self.status=='Lost'"], ["Partially Ordered", "is_partially_ordered"], ["Ordered", "is_fully_ordered"], ["Cancelled", "eval:self.docstatus==2"], ], "Sales Order": [ ["Draft", None], [ "To Deliver and Bill", "eval:self.per_delivered < 100 and self.per_billed < 100 and self.docstatus == 1", ], [ "To Bill", "eval:(self.per_delivered >= 100 or self.skip_delivery_note) and self.per_billed < 100 and self.docstatus == 1", ], [ "To Deliver", "eval:self.per_delivered < 100 and self.per_billed >= 100 and self.docstatus == 1 and not self.skip_delivery_note", ], [ "To Pay", "eval:self.advance_payment_status == 'Requested' and self.docstatus == 1", ], [ "Completed", "eval:(self.per_delivered >= 100 or self.skip_delivery_note) and self.per_billed >= 100 and self.docstatus == 1", ], ["Cancelled", "eval:self.docstatus==2"], ["Closed", "eval:self.status=='Closed' and self.docstatus != 2"], ["On Hold", "eval:self.status=='On Hold'"], ], "Purchase Order": [ ["Draft", None], ["To Bill", "eval:self.per_received >= 100 and self.per_billed < 100 and self.docstatus == 1"], [ "To Receive", "eval:self.per_received < 100 and self.per_billed == 100 and self.docstatus == 1", ], [ "To Receive and Bill", "eval:self.per_received < 100 and self.per_billed < 100 and self.docstatus == 1", ], [ "To Pay", "eval:self.advance_payment_status == 'Initiated' and self.docstatus == 1", ], [ "Completed", "eval:self.per_received >= 100 and self.per_billed == 100 and self.docstatus == 1", ], ["Delivered", "eval:self.status=='Delivered'"], ["Cancelled", "eval:self.docstatus==2"], ["On Hold", "eval:self.status=='On Hold'"], ["Closed", "eval:self.status=='Closed' and self.docstatus != 2"], ], "Delivery Note": [ ["Draft", None], ["To Bill", "eval:self.per_billed == 0 and self.docstatus == 1"], ["Partially Billed", "eval:self.per_billed < 100 and self.per_billed > 0 and self.docstatus == 1"], ["Completed", "eval:self.per_billed == 100 and self.docstatus == 1"], ["Return Issued", "eval:self.per_returned == 100 and self.docstatus == 1"], ["Return", "eval:self.is_return == 1 and self.per_billed == 0 and self.docstatus == 1"], ["Cancelled", "eval:self.docstatus==2"], ["Closed", "eval:self.status=='Closed' and self.docstatus != 2"], ], "Purchase Receipt": [ ["Draft", None], ["To Bill", "eval:self.per_billed == 0 and self.docstatus == 1"], ["Partly Billed", "eval:self.per_billed > 0 and self.per_billed < 100 and self.docstatus == 1"], ["Return", "eval:self.is_return == 1 and self.per_billed == 0 and self.docstatus == 1"], ["Return Issued", "eval:self.per_returned == 100 and self.docstatus == 1"], [ "Completed", "eval:(self.per_billed >= 100 and self.docstatus == 1) or (self.docstatus == 1 and self.grand_total == 0 and self.per_returned != 100 and self.is_return == 0)", ], ["Cancelled", "eval:self.docstatus==2"], ["Closed", "eval:self.status=='Closed' and self.docstatus != 2"], ], "Material Request": [ ["Draft", None], ["Stopped", "eval:self.status == 'Stopped'"], ["Cancelled", "eval:self.docstatus == 2"], ["Pending", "eval:self.status != 'Stopped' and self.per_ordered == 0 and self.docstatus == 1"], [ "Ordered", "eval:self.status != 'Stopped' and self.per_ordered == 100 and self.docstatus == 1 and self.material_request_type in ['Purchase', 'Manufacture', 'Subcontracting']", ], [ "Transferred", "eval:self.status != 'Stopped' and self.per_ordered == 100 and self.docstatus == 1 and self.material_request_type == 'Material Transfer'", ], [ "Issued", "eval:self.status != 'Stopped' and self.per_ordered == 100 and self.docstatus == 1 and self.material_request_type == 'Material Issue'", ], [ "Received", "eval:self.status != 'Stopped' and self.docstatus == 1 and ((self.per_received == 100 and self.material_request_type == 'Purchase') or (self.per_ordered == 100 and self.material_request_type == 'Customer Provided'))", ], [ "Partially Received", "eval:self.status != 'Stopped' and self.per_received > 0 and self.per_received < 100 and self.docstatus == 1 and self.material_request_type == 'Purchase'", ], [ "Partially Received", "eval:self.status != 'Stopped' and self.per_ordered < 100 and self.per_ordered > 0 and self.docstatus == 1 and self.material_request_type in ['Material Transfer', 'Customer Provided']", ], [ "Partially Ordered", "eval:self.status != 'Stopped' and self.per_ordered < 100 and self.per_ordered > 0 and self.per_received < 100 and self.docstatus == 1 and self.material_request_type not in ['Material Transfer', 'Customer Provided']", ], ], "POS Opening Entry": [ ["Draft", None], ["Open", "eval:self.docstatus == 1 and not self.pos_closing_entry"], ["Closed", "eval:self.docstatus == 1 and self.pos_closing_entry"], ["Cancelled", "eval:self.docstatus == 2"], ], "POS Closing Entry": [ ["Draft", None], ["Submitted", "eval:self.docstatus == 1"], ["Queued", "eval:self.status == 'Queued'"], ["Failed", "eval:self.status == 'Failed'"], ["Cancelled", "eval:self.docstatus == 2"], ], "Transaction Deletion Record": [ ["Draft", None], ["Completed", "eval:self.docstatus == 1"], ], "Pick List": [ ["Draft", None], ["Open", "eval:self.docstatus == 1"], ["Completed", "is_fully_transferred"], ["Partially Transferred", "is_partially_transferred"], [ "Partly Delivered", "eval:self.purpose == 'Delivery' and self.delivery_status == 'Partly Delivered'", ], ["Completed", "eval:self.purpose == 'Delivery' and self.delivery_status == 'Fully Delivered'"], ["Cancelled", "eval:self.docstatus == 2"], ], } class StatusUpdater(Document): """ Updates the status of the calling records Delivery Note: Update Delivered Qty, Update Percent and Validate over delivery Sales Invoice: Update Billed Amt, Update Percent and Validate over billing Installation Note: Update Installed Qty, Update Percent Qty and Validate over installation """ def on_discard(self): if self.meta.has_field("status"): self.db_set("status", "Cancelled") def update_prevdoc_status(self): self.update_qty() self.validate_qty() def set_status(self, update=False, status=None, update_modified=True): if self.is_new(): if self.get("amended_from"): self.status = "Draft" return if self.doctype not in status_map: return _status = self.status # TODO: revise accidential complexity where update has a double meaning, see below self.status = status if status else self.status new_status = self.get_status()["status"] if new_status != _status: if new_status not in ("Cancelled", "Partially Ordered", "Ordered", "Issued", "Transferred"): self.add_comment("Label", _(new_status)) self.status = new_status if update: self.db_set("status", new_status, update_modified=update_modified) def get_status(self): """ Get the status of the document. Returns: dict: A dictionary containing the status. This allows callers to receive a dictionary for efficient bulk updates, for example when `per_billed` and other status fields also need to be updated. Note: Can be overriden on a doctype to implement more localized status updater logic. Example: { "status": "Draft", "per_billed": 50, "billing_status": "Partly Billed" } """ if self.doctype not in status_map: return { "status": self.get("status") } # sometimes status field is not present on certain DocTypes such as Stock Entry sl = status_map[self.doctype][:] sl.reverse() for s in sl: if not s[1]: return {"status": s[0]} elif s[1].startswith("eval:"): if frappe.safe_eval( s[1][5:], None, { "self": self.as_dict(), "getdate": getdate, "nowdate": nowdate, "get_value": frappe.db.get_value, }, ): return {"status": s[0]} elif getattr(self, s[1])(): return {"status": s[0]} return {"status": self.status} def validate_qty(self): """Validates qty at row level""" for args in self.status_updater: if "target_ref_field" not in args or args.get("validate_qty") is False: # if target_ref_field is not specified or validate_qty is explicitly set to False, skip validation continue # Reset per-args so each config block uses its own allowance source without # leaking cached values from a previous config block. self.item_allowance = {} self.global_qty_allowance = None self.global_amount_allowance = None items_to_validate = [] selling_negative_rate_allowed = frappe.get_single_value( "Selling Settings", "allow_negative_rates_for_items" ) buying_negative_rate_allowed = frappe.get_single_value( "Buying Settings", "allow_negative_rates_for_items" ) # get unique transactions to update for d in self.get_all_children(): if hasattr(d, "qty") and flt(d.qty) < 0 and not self.get("is_return"): frappe.throw(_("For an item {0}, quantity must be positive number").format(d.item_code)) if hasattr(d, "qty") and flt(d.qty) > 0 and self.get("is_return"): frappe.throw(_("For an item {0}, quantity must be negative number").format(d.item_code)) if ( not selling_negative_rate_allowed and self.doctype in ["Sales Order", "Sales Invoice", "Delivery Note"] ) or ( not buying_negative_rate_allowed and self.doctype in ["Purchase Order", "Purchase Invoice", "Purchase Receipt"] ): if hasattr(d, "item_code") and hasattr(d, "rate") and flt(d.rate) < 0: frappe.throw( _( "For item {0}, rate must be a positive number. To Allow negative rates, enable {1} in {2}" ).format( frappe.bold(d.item_code), frappe.bold(_("`Allow Negative rates for Items`")), get_link_to_form( "Selling Settings" if self.doctype in ["Sales Invoice", "Delivery Note"] else "Buying Settings" ), ), ) if d.doctype == args["source_dt"] and d.get(args["join_field"]): items_to_validate.append( frappe._dict( { "name": d.get(args["join_field"]), "production_plan_sub_assembly_item": d.get( "production_plan_sub_assembly_item" ), "idx": d.idx, "child_doc": d, } ) ) if items_to_validate: pp_sub_assembly_items = [ item.production_plan_sub_assembly_item for item in items_to_validate if item.production_plan_sub_assembly_item ] pp_subcontract_items = [] if pp_sub_assembly_items: pp_subcontract_items = frappe.db.get_all( "Production Plan Sub Assembly Item", filters={ "name": ("in", pp_sub_assembly_items), "type_of_manufacturing": "Subcontract", }, pluck="name", ) regular_items = [] pp_items = [] for item in items_to_validate: if item.production_plan_sub_assembly_item in pp_subcontract_items: pp_items.append(item.name) else: regular_items.append(item.name) item_details = [] # Query regular items with item_code field if regular_items: item_details.extend(self.fetch_items_with_pending_qty(args, "item_code", regular_items)) # Query production plan items with production_item field if pp_items and args.get("target_dt") in ["Production Plan Sub Assembly Item"]: item_details.extend(self.fetch_items_with_pending_qty(args, "production_item", pp_items)) item_lookup = {item.name: item for item in item_details} for child_item in items_to_validate: item = item_lookup.get(child_item.name) if item: item["idx"] = child_item.idx item["target_ref_field"] = args["target_ref_field"].replace("_", " ") # if not item[args['target_ref_field']]: # msgprint(_("Note: System will not check over-delivery and over-booking for Item {0} as quantity or amount is 0").format(item.item_code)) if args.get("no_allowance"): item["reduce_by"] = item[args["target_field"]] - item[args["target_ref_field"]] if item["reduce_by"] > 0.01: self.limits_crossed_error(args, item, "qty") elif item[args["target_ref_field"]]: self.check_overflow_with_allowance(item, args) def fetch_items_with_pending_qty(self, args, item_field, items): doctype = frappe.qb.DocType(args["target_dt"]) item_field_col = doctype[item_field] target_ref_field = doctype[args["target_ref_field"]] target_field = doctype[args["target_field"]] is_qty_check = "qty" in args["target_ref_field"] query = ( frappe.qb.from_(doctype) .select( doctype.name, item_field_col.as_("item_code"), target_ref_field, target_field, doctype.parenttype, doctype.parent, ) .where(target_ref_field < target_field) .where(doctype.name.isin(items)) .where(doctype.docstatus == 1) ) if is_qty_check: item_table = frappe.qb.DocType("Item") query = ( query.join(item_table) .on(item_table.name == item_field_col) .where(item_table.is_stock_item == 1) ) return query.run(as_dict=True) def check_overflow_with_allowance(self, item, args): """ Checks if there is overflow considering a relaxation allowance. """ qty_or_amount = "qty" if "qty" in args["target_ref_field"] else "amount" global_qty_allowance_field = args.get("global_allowance_field", "over_delivery_receipt_allowance") global_qty_allowance_doctype = args.get("global_allowance_doctype", "Stock Settings") item_qty_allowance_field = args.get("item_allowance_field", "over_delivery_receipt_allowance") # check if overflow is within allowance ( allowance, self.item_allowance, self.global_qty_allowance, self.global_amount_allowance, ) = ( get_allowance_for( item["item_code"], self.item_allowance, self.global_qty_allowance, self.global_amount_allowance, qty_or_amount, global_qty_allowance_field, global_qty_allowance_doctype, item_qty_allowance_field, ) if args["source_dt"] != "Pick List Item" else (0, {}, None, None) ) role = None if qty_or_amount == "qty": if args.get("overflow_type") in ("delivery", "receipt"): role = frappe.get_single_value("Stock Settings", "role_allowed_to_over_deliver_receive") else: role = frappe.get_single_value("Accounts Settings", "role_allowed_to_over_bill") overflow_percent = ( (item[args["target_field"]] - item[args["target_ref_field"]]) / item[args["target_ref_field"]] ) * 100 if overflow_percent - allowance > 0.01: item["max_allowed"] = flt(item[args["target_ref_field"]] * (100 + allowance) / 100) item["reduce_by"] = item[args["target_field"]] - item["max_allowed"] if role not in frappe.get_roles(): self.limits_crossed_error(args, item, qty_or_amount) else: self.warn_about_bypassing_with_role(item, qty_or_amount, role) def limits_crossed_error(self, args, item, qty_or_amount): """Raise exception for limits crossed""" if ( self.doctype in ["Sales Invoice", "Delivery Note"] and qty_or_amount == "amount" and self.is_internal_customer ): return elif ( self.doctype in ["Purchase Invoice", "Purchase Receipt"] and qty_or_amount == "amount" and self.is_internal_supplier ): return if args["source_dt"] != "Pick List Item" and args["target_dt"] not in [ "Quotation Item", "Packed Item", ]: if args.get("target_dt") == "Material Request Item": action_msg = _('To allow over ordering, update "Over Order Allowance" in Buying Settings.') elif qty_or_amount == "qty": action_msg = _( 'To allow over receipt / delivery, update "Over Receipt/Delivery Allowance" in Stock Settings or the Item.' ) else: action_msg = _( 'To allow over billing, update "Over Billing Allowance" in Accounts Settings or the Item.' ) else: action_msg = None frappe.throw( _( "This document is over limit by {0} {1} for item {4}. Are you making another {3} against the same {2}?" ).format( frappe.bold(_(item["target_ref_field"].title())), frappe.bold(item["reduce_by"]), frappe.bold(_(args.get("target_dt"))), frappe.bold(_(self.doctype)), frappe.bold(item.get("item_code")), ) + ("

" + action_msg if action_msg else ""), OverAllowanceError, title=_("Limit Crossed"), ) def warn_about_bypassing_with_role(self, item, qty_or_amount, role): if qty_or_amount == "qty": msg = _("Over Receipt/Delivery of {0} {1} ignored for item {2} because you have {3} role.") else: msg = _("Overbilling of {0} {1} ignored for item {2} because you have {3} role.") frappe.msgprint( msg.format( _(item["target_ref_field"].title()), frappe.bold(item["reduce_by"]), frappe.bold(item.get("item_code")), role, ), indicator="orange", alert=True, ) def update_qty(self, update_modified=True): """Updates qty or amount at row level :param update_modified: If true, updates `modified` and `modified_by` for target parent doc """ for args in self.status_updater: # condition to include current record (if submit or no if cancel) if self.docstatus == 1: args["cond"] = " or parent=%s" % frappe.db.escape(self.name) else: args["cond"] = " and parent!=%s" % frappe.db.escape(self.name) self._update_children(args, update_modified) if "percent_join_field" in args or "percent_join_field_parent" in args: self._update_percent_field_in_targets(args, update_modified) def _update_children(self, args, update_modified): """Update quantities or amount in child table""" for d in self.get_all_children(): if d.doctype != args["source_dt"]: continue self._update_modified(args, update_modified) # updates qty in the child table args["detail_id"] = d.get(args["join_field"]) args["second_source_condition"] = "" if ( args.get("second_source_dt") and args.get("second_source_field") and args.get("second_join_field") ): if not args.get("second_source_extra_cond"): args["second_source_extra_cond"] = "" args["second_source_condition"] = frappe.db.sql( """ select ifnull((select sum({second_source_field}) from `tab{second_source_dt}` where `{second_join_field}`=%(detail_id)s and (`tab{second_source_dt}`.docstatus=1) {second_source_extra_cond}), 0) """.format(**args), {"detail_id": args["detail_id"]}, )[0][0] if args["detail_id"]: if not args.get("extra_cond"): args["extra_cond"] = "" args["source_dt_value"] = ( frappe.db.sql( """ (select ifnull(sum({source_field}), 0) from `tab{source_dt}` where `{join_field}`=%(detail_id)s and (docstatus=1 {cond}) {extra_cond}) """.format(**args), {"detail_id": args["detail_id"]}, )[0][0] or 0.0 ) if args["second_source_condition"]: args["source_dt_value"] += flt(args["second_source_condition"]) frappe.db.sql( """update `tab{target_dt}` set {target_field} = {source_dt_value} {update_modified} where name=%(detail_id)s""".format(**args), {"detail_id": args["detail_id"]}, ) @staticmethod def _calculate_target_parent_percentage( name, target_parent_dt, target_dt, target_ref_field, target_field ): child_records = frappe.get_all( target_dt, filters={"parent": name, "parenttype": target_parent_dt}, fields=[target_ref_field, target_field], ) # For operator dicts, the alias is in the "as" key; for strings, use the field name directly ref_key = target_ref_field.get("as") if isinstance(target_ref_field, dict) else target_ref_field sum_ref = sum(abs(record[ref_key]) for record in child_records) if sum_ref > 0: percentage = round( sum(min(abs(record[target_field]), abs(record[ref_key])) for record in child_records) / sum_ref * 100, 6, ) else: percentage = 0 return percentage @staticmethod def _determine_status(percentage, keyword): if percentage < 0.001: return f"Not {keyword}" elif percentage >= 99.999999: return f"Fully {keyword}" else: return f"Partly {keyword}" def _update_percent_field_in_targets(self, args, update_modified=True): """Update percent field in parent transaction""" if args.get("percent_join_field_parent"): # if reference to target doc where % is to be updated, is # in source doc's parent form, consider percent_join_field_parent args["name"] = self.get(args["percent_join_field_parent"]) self._update_percent_field(args, update_modified) else: distinct_transactions = set( d.get(args["percent_join_field"]) for d in self.get_all_children(args["source_dt"]) ) for name in distinct_transactions: if name: args["name"] = name self._update_percent_field(args, update_modified) def _update_percent_field(self, args, update_modified=True): """Update percent field in parent transaction""" update_data = {} if args.get("target_parent_field"): update_data[args.get("target_parent_field")] = self._calculate_target_parent_percentage( args["name"], args["target_parent_dt"], args["target_dt"], args["target_ref_field"], args["target_field"], ) # update field if args.get("status_field"): update_data[args.get("status_field")] = self._determine_status( update_data[args.get("target_parent_field")], args["keyword"] ) if update_data: target = frappe.get_lazy_doc(args["target_parent_dt"], args["name"]) target.update(update_data) # status calculus might depend on it status = target.get_status() if status.get("status"): update_data.update(status) target.db_set(update_data, update_modified=update_modified, notify=True) def _update_modified(self, args, update_modified): if not update_modified: args["update_modified"] = "" return args["update_modified"] = ", modified = {}, modified_by = {}".format( frappe.db.escape(now()), frappe.db.escape(frappe.session.user) ) def update_billing_status_for_zero_amount_refdoc(self, ref_dt): ref_fieldname = frappe.scrub(ref_dt) ref_docs = [item.get(ref_fieldname) for item in (self.get("items") or []) if item.get(ref_fieldname)] if not ref_docs: return zero_amount_refdocs = frappe.db.sql_list( f""" SELECT name from `tab{ref_dt}` where docstatus = 1 and base_net_total = 0 and name in %(ref_docs)s """, {"ref_docs": ref_docs}, ) if zero_amount_refdocs: self.update_billing_status(zero_amount_refdocs, ref_dt, ref_fieldname) def update_billing_status(self, zero_amount_refdoc, ref_dt, ref_fieldname): for ref_dn in zero_amount_refdoc: ref_doc_qty = flt( frappe.db.sql( """select ifnull(sum(qty), 0) from `tab{} Item` where parent={}""".format(ref_dt, "%s"), (ref_dn), )[0][0] ) billed_qty = flt( frappe.db.sql( """select ifnull(sum(qty), 0) from `tab{} Item` where {}={} and docstatus=1""".format(self.doctype, ref_fieldname, "%s"), (ref_dn), )[0][0] ) per_billed = safe_div(min(ref_doc_qty, billed_qty), ref_doc_qty) * 100 ref_doc = frappe.get_lazy_doc(ref_dt, ref_dn) ref_doc.db_set("per_billed", per_billed) # set billling status if hasattr(ref_doc, "billing_status"): if ref_doc.per_billed < 0.001: ref_doc.db_set("billing_status", "Not Billed") elif ref_doc.per_billed > 99.999999: ref_doc.db_set("billing_status", "Fully Billed") else: ref_doc.db_set("billing_status", "Partly Billed") ref_doc.set_status(update=True) def get_allowance_for( item_code, item_allowance=None, global_qty_allowance=None, global_amount_allowance=None, qty_or_amount="qty", global_qty_allowance_field="over_delivery_receipt_allowance", global_qty_allowance_doctype="Stock Settings", item_qty_allowance_field="over_delivery_receipt_allowance", ): """ Returns the allowance for the item, if not set, returns global allowance. Args: item_code: The item to get allowance for. item_allowance: Cached per-item allowances from a previous call. global_qty_allowance: Cached global qty allowance from a previous call. global_amount_allowance: Cached global amount allowance from a previous call. qty_or_amount: Whether to return qty or amount allowance. global_qty_allowance_field: The field name on the settings doctype to use for the global qty allowance. global_qty_allowance_doctype: The settings doctype to read the global qty allowance from. item_qty_allowance_field: The field name on the Item doctype to use for the item-level qty allowance override. """ if item_allowance is None: item_allowance = {} if qty_or_amount == "qty": if item_allowance.get(item_code, frappe._dict()).get("qty"): return ( item_allowance[item_code].qty, item_allowance, global_qty_allowance, global_amount_allowance, ) else: if item_allowance.get(item_code, frappe._dict()).get("amount"): return ( item_allowance[item_code].amount, item_allowance, global_qty_allowance, global_amount_allowance, ) qty_allowance, over_billing_allowance = frappe.get_cached_value( "Item", item_code, [item_qty_allowance_field, "over_billing_allowance"] ) if qty_or_amount == "qty" and not qty_allowance: if global_qty_allowance is None: global_qty_allowance = flt( frappe.get_single_value(global_qty_allowance_doctype, global_qty_allowance_field) ) qty_allowance = global_qty_allowance elif qty_or_amount == "amount" and not over_billing_allowance: if global_amount_allowance is None: global_amount_allowance = flt( frappe.get_cached_value("Accounts Settings", None, "over_billing_allowance") ) over_billing_allowance = global_amount_allowance if qty_or_amount == "qty": allowance = qty_allowance item_allowance.setdefault(item_code, frappe._dict()).setdefault("qty", qty_allowance) else: allowance = over_billing_allowance item_allowance.setdefault(item_code, frappe._dict()).setdefault("amount", over_billing_allowance) return allowance, item_allowance, global_qty_allowance, global_amount_allowance