# Copyright (c) 2022, Frappe Technologies Pvt. Ltd. and Contributors # License: GNU General Public License v3. See license.txt import copy import gzip import json from collections import deque from contextlib import nullcontext import frappe from frappe import _, bold, scrub from frappe.model.meta import get_field_precision from frappe.query_builder import Order from frappe.query_builder.functions import Lower, NullIf, Sum from frappe.utils import ( cint, flt, format_date, get_datetime, get_link_to_form, getdate, now, nowdate, nowtime, parse_json, ) import erpnext from erpnext.stock.doctype.bin.bin import update_qty_from_sle from erpnext.stock.doctype.inventory_dimension.inventory_dimension import get_inventory_dimensions from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import ( get_auto_batch_nos, ) from erpnext.stock.doctype.stock_reservation_entry.stock_reservation_entry import ( get_sre_reserved_batch_nos_details, get_sre_reserved_serial_nos_details, ) from erpnext.stock.utils import ( get_combine_datetime, get_incoming_outgoing_rate_for_cancel, get_or_make_bin, get_serial_nos_data, get_stock_balance, get_valuation_method, ) from erpnext.stock.valuation import FIFOValuation, LIFOValuation, round_off_if_near_zero class NegativeStockError(frappe.ValidationError): pass class SerialNoExistsInFutureTransaction(frappe.ValidationError): pass def validate_standard_cost_posting_date(sl_entries): """R2: a Standard Cost item's stock transaction cannot be dated before the latest Item Standard Cost effective date. A backdated entry would slip in behind the standard-rate revaluation, making its on-hand snapshot stale and forcing a repost — which Standard Cost deliberately avoids. Enforced here so every stock voucher is covered uniformly.""" from erpnext.stock.utils import get_valuation_method checked = {} for sle in sl_entries: item_code = sle.get("item_code") company = sle.get("company") posting_date = sle.get("posting_date") if not item_code or not company or not posting_date: continue key = (item_code, company) if key not in checked: latest_isc = None if get_valuation_method(item_code, company) == "Standard Cost": latest_isc = frappe.db.get_value( "Item Standard Cost", {"item_code": item_code, "company": company, "docstatus": 1}, ["name", "effective_date"], order_by="effective_date desc", as_dict=True, ) checked[key] = latest_isc latest_isc = checked[key] if latest_isc and getdate(posting_date) < getdate(latest_isc.effective_date): effective_date = frappe.bold(frappe.format(latest_isc.effective_date, "Date")) frappe.throw( _( "Cannot post Standard Cost item {0} on {1}: it is before {2}, the effective date of its latest Standard Valuation Rate {3}." ).format( get_link_to_form("Item", item_code), frappe.bold(frappe.format(posting_date, "Date")), effective_date, get_link_to_form("Item Standard Cost", latest_isc.name), ) + "

" + _("Post this entry on or after {0}.").format(effective_date), title=_("Backdated Entry Not Allowed"), ) def validate_stock_frozen_by_closing_entry(sl_entries): from erpnext.stock.doctype.stock_closing_entry.stock_closing_entry import ( get_closing_entry_for_closed_period, ) company = sl_entries[0].get("company") if not company: company = frappe.get_cached_value("Warehouse", sl_entries[0].get("warehouse"), "company") closing_entry = get_closing_entry_for_closed_period(company) if not closing_entry: return for sle in sl_entries: if sle.get("posting_date") and getdate(sle.get("posting_date")) <= getdate(closing_entry.to_date): frappe.throw( _( "Stock transactions dated on or before {0} are frozen because the period is closed and the Stock Closing Entry {1} has been generated. To make changes, cancel the Period Closing Voucher first." ).format( frappe.bold(format_date(closing_entry.to_date)), get_link_to_form("Stock Closing Entry", closing_entry.name), ), title=_("Stock Frozen"), ) def make_sl_entries(sl_entries, allow_negative_stock=False, via_landed_cost_voucher=False): """Create SL entries from SL entry dicts args: - allow_negative_stock: disable negative stock valiations if true - via_landed_cost_voucher: landed cost voucher cancels and reposts entries of purchase document. This flag is used to identify if cancellation and repost is happening via landed cost voucher, in such cases certain validations need to be ignored (like negative stock) """ from erpnext.controllers.stock_controller import future_sle_exists, invalidate_future_sle_cache if sl_entries: # Sorted so two vouchers touching the same pairs can't take the gates in opposite order. for pair in sorted({(d.get("item_code"), d.get("warehouse")) for d in sl_entries}): sle_processing_gate(*pair) validate_stock_frozen_by_closing_entry(sl_entries) cancelled = sl_entries[0].get("is_cancelled") if cancelled: validate_cancellation(sl_entries) set_as_cancel(sl_entries[0].get("voucher_type"), sl_entries[0].get("voucher_no")) else: validate_standard_cost_posting_date(sl_entries) args = get_args_for_future_sle(sl_entries[0]) future_sle_exists(args, sl_entries) for sle in sl_entries: if cancelled: sle["actual_qty"] = -flt(sle.get("actual_qty")) if sle["actual_qty"] < 0 and not sle.get("outgoing_rate"): sle["outgoing_rate"] = get_incoming_outgoing_rate_for_cancel( sle.item_code, sle.voucher_type, sle.voucher_no, sle.voucher_detail_no ) sle["incoming_rate"] = 0.0 if sle["actual_qty"] > 0 and not sle.get("incoming_rate"): sle["incoming_rate"] = get_incoming_outgoing_rate_for_cancel( sle.item_code, sle.voucher_type, sle.voucher_no, sle.voucher_detail_no ) sle["outgoing_rate"] = 0.0 if not (sle.get("actual_qty") or sle.get("voucher_type") == "Stock Reconciliation"): continue sle_doc = make_entry(sle, allow_negative_stock, via_landed_cost_voucher) args = sle_doc.as_dict() args["posting_datetime"] = get_combine_datetime(args.posting_date, args.posting_time) if sle.get("voucher_type") == "Stock Reconciliation": # preserve previous_qty_after_transaction for qty reposting args.previous_qty_after_transaction = sle.get("previous_qty_after_transaction") is_stock_item = frappe.get_cached_value("Item", args.get("item_code"), "is_stock_item") if is_stock_item: bin_name = get_or_make_bin(args.get("item_code"), args.get("warehouse")) args.reserved_stock = flt(frappe.db.get_value("Bin", bin_name, "reserved_stock")) repost_current_voucher( args, allow_negative_stock, via_landed_cost_voucher, cancelled=cancelled ) update_qty_from_sle(bin_name, args) else: frappe.msgprint( _("Item {0} ignored since it is not a stock item").format(args.get("item_code")) ) invalidate_future_sle_cache(sl_entries[0].get("voucher_type"), sl_entries[0].get("voucher_no")) def repost_current_voucher(args, allow_negative_stock=False, via_landed_cost_voucher=False, cancelled=False): if args.get("actual_qty") or args.get("voucher_type") == "Stock Reconciliation": if not args.get("posting_date"): args["posting_date"] = nowdate() if not (args.get("is_cancelled") and via_landed_cost_voucher): # Reposts only current voucher SL Entries # Updates valuation rate, stock value, stock queue for current transaction update_entries_after( { "item_code": args.get("item_code"), "warehouse": args.get("warehouse"), "posting_date": args.get("posting_date"), "posting_time": args.get("posting_time"), "voucher_type": args.get("voucher_type"), "voucher_no": args.get("voucher_no"), "sle_id": args.get("name"), "creation": args.get("creation"), "reserved_stock": args.get("reserved_stock"), "cancelled": cancelled, }, allow_negative_stock=allow_negative_stock, via_landed_cost_voucher=via_landed_cost_voucher, ) # update qty in future sle and Validate negative qty # For LCV: update future balances with -ve LCV SLE, which will be balanced by +ve LCV SLE update_qty_in_future_sle(args, allow_negative_stock) def get_args_for_future_sle(row): return frappe._dict( { "voucher_type": row.get("voucher_type"), "voucher_no": row.get("voucher_no"), "posting_date": row.get("posting_date"), "posting_time": row.get("posting_time"), } ) def validate_cancellation(kargs): if kargs[0].get("is_cancelled"): repost_entry = frappe.db.get_value( "Repost Item Valuation", { "voucher_type": kargs[0].voucher_type, "voucher_no": kargs[0].voucher_no, "docstatus": 1, "recreate_stock_ledgers": 0, }, ["name", "status"], as_dict=1, ) if repost_entry: if repost_entry.status == "In Progress": frappe.throw( _( "Cannot cancel the transaction. Reposting of item valuation on submission is not completed yet." ) ) if repost_entry.status == "Queued": doc = frappe.get_doc("Repost Item Valuation", repost_entry.name) doc.status = "Skipped" doc.flags.ignore_permissions = True doc.cancel() def set_as_cancel(voucher_type, voucher_no): sle = frappe.qb.DocType("Stock Ledger Entry") ( frappe.qb.update(sle) .set(sle.is_cancelled, 1) .set(sle.modified, now()) .set(sle.modified_by, frappe.session.user) .where((sle.voucher_type == voucher_type) & (sle.voucher_no == voucher_no) & (sle.is_cancelled == 0)) ).run() def make_entry(args, allow_negative_stock=False, via_landed_cost_voucher=False): args["doctype"] = "Stock Ledger Entry" sle = frappe.get_doc(args) sle.flags.ignore_permissions = 1 sle.allow_negative_stock = allow_negative_stock sle.via_landed_cost_voucher = via_landed_cost_voucher if args.get("is_cancelled"): sle.flags.ignore_links = True sle.submit() # Added to handle the case when the stock ledger entry is created from the repostig if args.get("creation_time") and args.get("voucher_type") == "Stock Reconciliation": sle.db_set("creation", args.get("creation_time")) return sle # A repost waits this long for another repost's per-(item, warehouse) gate before giving up. Kept # well under the 1800s repost job timeout so a wait can't burn the whole budget, and short enough # that a contended worker re-queues (recoverable QueryTimeoutError) and frees the slot for other # items instead of pinning it. REPOST_LOCK_TIMEOUT = 300 def repost_gate(item_code, warehouse): """Serialize concurrent background reposts of the same (item, warehouse) with a session-level advisory lock taken before the inner `... for update` row locks, so they take turns instead of racing into a lock-order deadlock. Row locks still enforce correctness; this only cuts the deadlock/retry churn. Scope is repost-vs-repost only -- the synchronous repost_current_voucher submit path is deliberately not gated (blocking a submit behind a background repost would be a worse regression) and keeps relying on the existing deadlock retry. Postgres only: MariaDB keeps the plain deadlock-retry path.""" # hasattr keeps this a graceful opt-in: on an ERPNext predating frappe.db.advisory_lock, fall # back to no gate rather than raising and marking the Repost Item Valuation permanently Failed. if frappe.db.db_type == "postgres" and hasattr(frappe.db, "advisory_lock"): # Tuple key: a colon in item_code/warehouse can't collide two distinct pairs onto one lock. return frappe.db.advisory_lock(("stock_repost", item_code, warehouse), timeout=REPOST_LOCK_TIMEOUT) return nullcontext() def sle_processing_gate(item_code, warehouse): """Serialize all stock writes for an (item, warehouse) on postgres. MariaDB gets this from the gap locks its previous-SLE locking reads take (which also block, then reveal, concurrent inserts); postgres locking reads never see rows another transaction is inserting, so without this gate two concurrent writers compute from the same stale previous SLE and the loser's Bin write is lost. Txn-scoped and re-entrant; released at commit/rollback. hasattr keeps a frappe predating transaction_advisory_lock on the status quo (serialization-failure retries) instead of breaking every stock submission.""" if frappe.db.db_type == "postgres" and hasattr(frappe.db, "transaction_advisory_lock"): frappe.db.transaction_advisory_lock(("stock-sle", item_code, warehouse), timeout=REPOST_LOCK_TIMEOUT) def repost_future_sle( items_to_be_repost=None, voucher_type=None, voucher_no=None, allow_negative_stock=None, via_landed_cost_voucher=False, doc=None, ): reposting_data = {} if not items_to_be_repost: items_to_be_repost = get_items_to_be_repost( voucher_type=voucher_type, voucher_no=voucher_no, doc=doc, reposting_data=reposting_data ) if doc and doc.reposting_data_file: reposting_data = get_reposting_data(doc.reposting_data_file) repost_affected_transaction = get_affected_transactions(doc, reposting_data) or set() resume_item_wh_wise_last_posted_sle = ( get_item_wh_wise_last_posted_sle_from_reposting_data(doc, reposting_data) or {} ) item_wh_first_reposted = get_item_wh_first_reposted_from_reposting_data(doc, reposting_data) or {} if not items_to_be_repost: return index = get_current_index(doc) or 0 while index < len(items_to_be_repost): validate_item_warehouse(items_to_be_repost[index]) item_code = items_to_be_repost[index].get("item_code") warehouse = items_to_be_repost[index].get("warehouse") with repost_gate(item_code, warehouse): obj = update_entries_after( { "item_code": item_code, "warehouse": warehouse, "posting_date": items_to_be_repost[index].get("posting_date"), "posting_time": items_to_be_repost[index].get("posting_time"), "creation": items_to_be_repost[index].get("creation"), "current_idx": index, "items_to_be_repost": items_to_be_repost, "repost_doc": doc, "repost_affected_transaction": repost_affected_transaction, "item_wh_wise_last_posted_sle": resume_item_wh_wise_last_posted_sle, "item_wh_first_reposted": item_wh_first_reposted, }, allow_negative_stock=allow_negative_stock, via_landed_cost_voucher=via_landed_cost_voucher, ) index += 1 resume_item_wh_wise_last_posted_sle = {} repost_affected_transaction.update(obj.repost_affected_transaction) item_wh_first_reposted = obj.item_wh_first_reposted update_args_in_repost_item_valuation( doc, index, items_to_be_repost, repost_affected_transaction, item_wh_first_reposted=item_wh_first_reposted, ) def update_args_in_repost_item_valuation( doc, index, items_to_be_repost, repost_affected_transaction, item_wh_wise_last_posted_sle=None, item_wh_first_reposted=None, ): file_name = "" if not item_wh_wise_last_posted_sle: item_wh_wise_last_posted_sle = {} if not item_wh_first_reposted: item_wh_first_reposted = {} if doc.reposting_data_file: file_name = get_reposting_file_name(doc.doctype, doc.name) # frappe.delete_doc("File", file_name, ignore_permissions=True, delete_permanently=True) doc.reposting_data_file = create_json_gz_file( { "repost_affected_transaction": repost_affected_transaction, "item_wh_wise_last_posted_sle": {str(k): v for k, v in item_wh_wise_last_posted_sle.items()} or {}, "item_wh_first_reposted": {str(k): v for k, v in item_wh_first_reposted.items()}, }, doc, file_name, ) doc.db_set( { "current_index": index, "items_to_be_repost": frappe.as_json(items_to_be_repost), "total_reposting_count": len(items_to_be_repost), "reposting_data_file": doc.reposting_data_file, } ) if not frappe.in_test: frappe.db.commit() frappe.publish_realtime( "item_reposting_progress", { "name": doc.name, "current_index": index, "total_reposting_count": len(items_to_be_repost), }, doctype=doc.doctype, docname=doc.name, ) def get_reposting_file_name(dt, dn): return frappe.db.get_value( "File", { "attached_to_doctype": dt, "attached_to_name": dn, "attached_to_field": "reposting_data_file", }, "name", ) def create_json_gz_file(data, doc, file_name=None) -> str: encoded_content = frappe.safe_encode(frappe.as_json(data)) compressed_content = gzip.compress(encoded_content) if not file_name: return create_file(doc, compressed_content) else: file_doc = frappe.get_doc("File", file_name) if "/frappe_s3_attachment." in file_doc.file_url: file_doc.delete() return create_file(doc, compressed_content) path = file_doc.get_full_path() with open(path, "wb") as f: f.write(compressed_content) return doc.reposting_data_file def create_file(doc, compressed_content): json_filename = f"{scrub(doc.doctype)}-{scrub(doc.name)}.json.gz" _file = frappe.get_doc( { "doctype": "File", "file_name": json_filename, "attached_to_doctype": doc.doctype, "attached_to_name": doc.name, "attached_to_field": "reposting_data_file", "content": compressed_content, "is_private": 1, } ) _file.save(ignore_permissions=True) return _file.file_url def validate_item_warehouse(args): for field in ["item_code", "warehouse", "posting_date", "posting_time"]: if args.get(field) in [None, ""]: frappe.throw(_("The field {0} is required for reposting").format(frappe.unscrub(field))) def get_items_to_be_repost(voucher_type=None, voucher_no=None, doc=None, reposting_data=None): if reposting_data and reposting_data.items_to_be_repost: return reposting_data.items_to_be_repost items_to_be_repost = [] if doc and doc.items_to_be_repost: items_to_be_repost = json.loads(doc.items_to_be_repost) if not items_to_be_repost and voucher_type and voucher_no: items_to_be_repost = frappe.db.get_all( "Stock Ledger Entry", filters={"voucher_type": voucher_type, "voucher_no": voucher_no}, fields=[ "item_code", "warehouse", # aggregate the non-grouped columns (earliest row per item+warehouse) so the GROUP BY # is valid on Postgres; a single voucher's entries share posting_date/time per group {"MIN": "posting_date", "as": "posting_date"}, {"MIN": "posting_time", "as": "posting_time"}, {"MIN": "creation", "as": "creation"}, {"MIN": "posting_datetime", "as": "posting_datetime"}, ], order_by="creation asc", group_by="item_code, warehouse", ) return items_to_be_repost or [] def get_affected_transactions(doc, reposting_data=None) -> set[tuple[str, str]]: if not reposting_data and doc and doc.reposting_data_file: reposting_data = get_reposting_data(doc.reposting_data_file) if reposting_data and reposting_data.repost_affected_transaction: return {tuple(transaction) for transaction in reposting_data.repost_affected_transaction} return set() def get_item_wh_wise_last_posted_sle_from_reposting_data(doc, reposting_data=None): if not reposting_data and doc and doc.reposting_data_file: reposting_data = get_reposting_data(doc.reposting_data_file) if reposting_data and reposting_data.item_wh_wise_last_posted_sle: return frappe._dict(reposting_data.item_wh_wise_last_posted_sle) return frappe._dict() def get_item_wh_first_reposted_from_reposting_data(doc, reposting_data=None): if not reposting_data and doc and doc.reposting_data_file: reposting_data = get_reposting_data(doc.reposting_data_file) if not reposting_data or not reposting_data.get("item_wh_first_reposted"): return {} return {frappe.safe_eval(key): value for key, value in reposting_data.item_wh_first_reposted.items()} def get_reposting_data(file_path) -> dict: file_name = frappe.db.get_value( "File", { "file_url": file_path, "attached_to_field": "reposting_data_file", }, "name", ) if not file_name: return frappe._dict() attached_file = frappe.get_doc("File", file_name) content = attached_file.get_content() if isinstance(content, str): content = content.encode("utf-8") try: data = gzip.decompress(content) except Exception: return frappe._dict() data = json.loads(data.decode("utf-8")) return parse_json(data) def get_current_index(doc=None): if doc and doc.current_index: return doc.current_index class update_entries_after: """ update valution rate and qty after transaction from the current time-bucket onwards :param args: args as dict args = { "item_code": "ABC", "warehouse": "XYZ", "posting_date": "2012-12-12", "posting_time": "12:00" } """ def __init__( self, args, allow_zero_rate=False, allow_negative_stock=None, via_landed_cost_voucher=False, verbose=1, ): self.exceptions = {} self.verbose = verbose self.allow_zero_rate = allow_zero_rate self.via_landed_cost_voucher = via_landed_cost_voucher self.item_code = args.get("item_code") self.stock_ledgers_to_repost = [] self.current_idx = args.get("current_idx", 0) self.repost_doc = args.get("repost_doc") or None self.items_to_be_repost = args.get("items_to_be_repost") or None self.allow_negative_stock = allow_negative_stock or is_negative_stock_allowed( item_code=self.item_code ) self.args = frappe._dict(args) if self.args.sle_id: self.args["name"] = self.args.sle_id sle_processing_gate(self.item_code, self.args.warehouse) self.prev_sle_dict = frappe._dict({}) self.company = frappe.get_cached_value("Warehouse", self.args.warehouse, "company") self.set_precision() self.valuation_method = get_valuation_method(self.item_code, self.company) self.repost_affected_transaction = args.get("repost_affected_transaction") or set() self.new_items_found = False self.reserved_stock = self.get_reserved_stock() self.data = frappe._dict() if (not self.repost_doc or not self.args.get("item_wh_wise_last_posted_sle")) and not self.args.get( "cancelled" ): self.initialize_previous_data(self.args) self.build() def get_reserved_stock(self): sre = frappe.qb.DocType("Stock Reservation Entry") posting_datetime = get_combine_datetime(self.args.posting_date, self.args.posting_time) query = ( frappe.qb.from_(sre) .select( Sum(sre.reserved_qty) - (Sum(sre.delivered_qty) + Sum(sre.transferred_qty) + Sum(sre.consumed_qty)) ) .where( (sre.item_code == self.item_code) & (sre.warehouse == self.args.warehouse) & (sre.docstatus == 1) & (sre.creation <= posting_datetime) ) ).run() return flt(query[0][0]) if query else 0.0 def set_precision(self): self.flt_precision = cint(frappe.db.get_default("float_precision")) or 2 self.currency_precision = get_field_precision( frappe.get_meta("Stock Ledger Entry").get_field("stock_value") ) def initialize_previous_data(self, args): """ Get previous sl entries for current item for each related warehouse and assigns into self.data dict :Data Structure: self.data = { warehouse1: { 'previus_sle': {}, 'qty_after_transaction': 10, 'valuation_rate': 100, 'stock_value': 1000, 'prev_stock_value': 1000, 'stock_queue': '[[10, 100]]', 'stock_value_difference': 1000 } } """ self.data.setdefault(args.warehouse, frappe._dict()) warehouse_dict = self.data[args.warehouse] if self.stock_ledgers_to_repost: return previous_sle = get_previous_sle_of_current_voucher(args) if previous_sle: self.prev_sle_dict[(args.get("item_code"), args.get("warehouse"))] = previous_sle warehouse_dict.previous_sle = previous_sle for key in ("qty_after_transaction", "valuation_rate", "stock_value"): setattr(warehouse_dict, key, flt(previous_sle.get(key))) warehouse_dict.update( { "prev_stock_value": previous_sle.stock_value or 0.0, "stock_queue": json.loads(previous_sle.stock_queue or "[]"), "stock_value_difference": 0.0, } ) def build(self): from erpnext.controllers.stock_controller import future_sle_exists if self.args.get("sle_id"): self.process_sle_against_current_timestamp() if not future_sle_exists(self.args): self.update_bin() else: self.item_wh_wise_last_posted_sle = self.get_item_wh_wise_last_posted_sle() item_wh_sles = self.sort_sles(self.item_wh_wise_last_posted_sle.values()) self.initialize_reposting() self.repost_stock_ledgers(item_wh_sles) self.update_bin() self.reset_vouchers_and_idx() self.update_data_in_repost() if self.exceptions: self.raise_exceptions() def initialize_reposting(self): self._sles = [] self.distinct_sles = set() self.distinct_dependant_item_wh = set() self.prev_sle_dict = frappe._dict({}) self.item_wh_first_reposted = dict(self.args.get("item_wh_first_reposted") or {}) def get_item_wh_wise_last_posted_sle(self): if self.args and self.args.get("item_wh_wise_last_posted_sle"): _sles = {} for key, sle in self.args.get("item_wh_wise_last_posted_sle").items(): _sles[frappe.safe_eval(key)] = frappe._dict(sle) return _sles return { (self.args.item_code, self.args.warehouse): frappe._dict( { "item_code": self.args.item_code, "warehouse": self.args.warehouse, "posting_datetime": get_combine_datetime(self.args.posting_date, self.args.posting_time), "posting_date": self.args.posting_date, "posting_time": self.args.posting_time, "creation": self.args.creation, } ) } def _get_future_entries_to_repost(self, item_wh_sles): sles = [] for sle in item_wh_sles: if (sle.item_code, sle.warehouse) not in self.distinct_dependant_item_wh: self.distinct_dependant_item_wh.add((sle.item_code, sle.warehouse)) sles.extend(self.get_future_entries_to_repost(sle)) return self.sort_sles(sles) def repost_stock_ledgers(self, item_wh_sles=None): self._sles = self._get_future_entries_to_repost(item_wh_sles) if not isinstance(self._sles, deque): self._sles = deque(self._sles) i = 0 while self._sles: sle = self._sles.popleft() if (sle.item_code, sle.warehouse) not in self.distinct_dependant_item_wh: self.distinct_dependant_item_wh.add((sle.item_code, sle.warehouse)) if sle.name in self.distinct_sles: continue i += 1 item_wh_key = (sle.item_code, sle.warehouse) sle_datetime = sle.posting_datetime or get_combine_datetime(sle.posting_date, sle.posting_time) existing_datetime = self.item_wh_first_reposted.get(item_wh_key) if not existing_datetime or get_datetime(sle_datetime) < get_datetime(existing_datetime): self.item_wh_first_reposted[item_wh_key] = sle_datetime if item_wh_key not in self.prev_sle_dict: self.prev_sle_dict[item_wh_key] = get_previous_sle_of_current_voucher(sle) self.repost_stock_ledger_entry(sle) # To avoid duplicate reposting of same sle in case of multiple dependant sle self.distinct_sles.add(sle.name) if sle.dependant_sle_voucher_detail_no: self.include_dependant_sle_in_reposting(sle) self.update_item_wh_wise_last_posted_sle(sle) if i % 2000 == 0: self.update_data_in_repost(len(self._sles), i) def sort_sles(self, sles): return sorted( sles, key=lambda d: ( get_datetime(d.posting_datetime), get_datetime(d.creation), ), ) def include_dependant_sle_in_reposting(self, sle): repost_dependant_sle = False if sle.voucher_type == "Stock Entry" and is_repack_entry(sle.voucher_no): repack_sles = self.get_sles_for_repack(sle) for repack_sle in repack_sles: if (repack_sle.item_code, repack_sle.warehouse) in self.distinct_dependant_item_wh: continue repost_dependant_sle = True self.distinct_dependant_item_wh.add((repack_sle.item_code, repack_sle.warehouse)) self._sles.extend(self.get_future_entries_to_repost(repack_sle)) else: dependant_sles = get_sle_by_voucher_detail_no(sle.dependant_sle_voucher_detail_no) for depend_sle in dependant_sles: if (depend_sle.item_code, depend_sle.warehouse) in self.distinct_dependant_item_wh: continue repost_dependant_sle = True self.distinct_dependant_item_wh.add((depend_sle.item_code, depend_sle.warehouse)) self._sles.extend(self.get_future_entries_to_repost(depend_sle)) if repost_dependant_sle: self._sles = deque(self.sort_sles(self._sles)) def repost_stock_ledger_entry(self, sle): if isinstance(sle, dict): sle = frappe._dict(sle) self.process_sle(sle) self.update_item_wh_wise_last_posted_sle(sle) def update_item_wh_wise_last_posted_sle(self, sle): if not self._sles: self.item_wh_wise_last_posted_sle = frappe._dict() return self.item_wh_wise_last_posted_sle[(sle.item_code, sle.warehouse)] = frappe._dict( { "item_code": sle.item_code, "warehouse": sle.warehouse, "posting_date": sle.posting_date, "posting_time": sle.posting_time, "posting_datetime": sle.posting_datetime or get_combine_datetime(sle.posting_date, sle.posting_time), "creation": sle.creation, } ) def reset_vouchers_and_idx(self): self.stock_ledgers_to_repost = [] self.prev_sle_dict = frappe._dict() self.item_wh_wise_last_posted_sle = frappe._dict() def update_data_in_repost(self, total_sles=None, index=None): if not self.repost_doc: return values_to_update = { "total_vouchers": cint(total_sles) + cint(index), "vouchers_posted": index or 0, } self.repost_doc.db_set(values_to_update) update_args_in_repost_item_valuation( self.repost_doc, self.current_idx, self.items_to_be_repost, self.repost_affected_transaction, self.item_wh_wise_last_posted_sle, self.item_wh_first_reposted, ) if not frappe.in_test: # To maintain the state of the reposting, so if timeout happens, it can be resumed from the last posted voucher frappe.db.commit() # nosemgrep self.publish_real_time_progress(total_sles=total_sles, index=index) def publish_real_time_progress(self, total_sles=None, index=None): frappe.publish_realtime( "item_reposting_progress", { "name": self.repost_doc.name, "total_vouchers": cint(total_sles) + cint(index), "vouchers_posted": index or 0, }, doctype=self.repost_doc.doctype, docname=self.repost_doc.name, ) def get_future_entries_to_repost(self, kwargs): return get_stock_ledger_entries(kwargs, ">=", "asc", for_update=True, check_serial_no=False) def get_sles_for_repack(self, sle): return ( frappe.get_all( "Stock Ledger Entry", filters={ "voucher_type": "Stock Entry", "voucher_no": sle.voucher_no, "actual_qty": (">", 0), "is_cancelled": 0, "dependant_sle_voucher_detail_no": ("!=", sle.dependant_sle_voucher_detail_no), }, fields=[ "item_code", "warehouse", "posting_date", "posting_time", "posting_datetime", "creation", ], ) or [] ) def has_stock_reco_with_serial_batch(self, sle): if ( sle.voucher_type == "Stock Reconciliation" and frappe.db.get_value(sle.voucher_type, sle.voucher_no, "set_posting_time") == 1 ): return not (sle.batch_no or sle.serial_no or sle.serial_and_batch_bundle) return False def process_sle_against_current_timestamp(self): sl_entries = get_sle_against_current_voucher(self.args) if self.args.get("cancelled") and sl_entries: self.seed_previous_sle_for_cancellation(sl_entries[0]) for sle in sl_entries: sle["timestamp"] = sle.posting_datetime self.process_sle(sle) def seed_previous_sle_for_cancellation(self, anchor_sle): key = (anchor_sle.item_code, anchor_sle.warehouse) if key in self.prev_sle_dict: return args = frappe._dict(anchor_sle) args["sle_id"] = args.name prev_sle = get_previous_sle_of_current_voucher(args) if prev_sle: self.prev_sle_dict[key] = prev_sle def get_future_entries_to_fix(self): # includes current entry! args = self.data[self.args.warehouse].previous_sle or frappe._dict( {"item_code": self.item_code, "warehouse": self.args.warehouse} ) return list(self.get_sle_after_datetime(args)) def validate_previous_sle_qty(self, sle): previous_sle = self.prev_sle_dict.get((sle.item_code, sle.warehouse)) if previous_sle and previous_sle.get("qty_after_transaction") < 0 and sle.get("actual_qty") > 0: frappe.msgprint( _( "The stock for the item {0} in the {1} warehouse was negative on the {2}. You should create a positive entry {3} before the date {4} and time {5} to post the correct valuation rate. For more details, please read the documentation." ).format( bold(sle.item_code), bold(sle.warehouse), bold(format_date(previous_sle.posting_date)), sle.voucher_no, bold(format_date(previous_sle.posting_date)), bold(previous_sle.posting_time), ), title=_("Warning on Negative Stock"), indicator="blue", ) def process_standard_cost(self, sle): from erpnext.stock.doctype.item_standard_cost.item_standard_cost import get_item_standard_rate rate = get_item_standard_rate(sle.item_code, self.company, sle.posting_date) if rate is None: frappe.throw( _( "No Standard Valuation Rate found for Item {0} in Company {1} as on {2}. Please create an Item Standard Cost record." ).format(bold(sle.item_code), bold(self.company), bold(sle.posting_date)) ) if sle.voucher_type == "Stock Reconciliation" and sle.get("qty_after_transaction") is not None: self.wh_data.qty_after_transaction = flt(sle.qty_after_transaction) else: self.wh_data.qty_after_transaction += flt(sle.actual_qty) self.wh_data.valuation_rate = rate self.wh_data.stock_value = flt(self.wh_data.qty_after_transaction) * flt(rate) self.wh_data.stock_queue = [[self.wh_data.qty_after_transaction, rate]] if flt(sle.actual_qty) > 0: sle.incoming_rate = rate def process_sle(self, sle): # previous sle data for this warehouse key = (sle.item_code, sle.warehouse) if key not in self.prev_sle_dict: prev_sle = get_previous_sle_of_current_voucher(sle) if prev_sle: self.prev_sle_dict[key] = prev_sle if not self.prev_sle_dict.get(key): self.prev_sle_dict[key] = frappe._dict( { "qty_after_transaction": 0.0, "valuation_rate": 0.0, "stock_value": 0.0, "prev_stock_value": 0.0, "stock_queue": [], } ) self.wh_data = self.prev_sle_dict.get(key) if self.wh_data.stock_queue and isinstance(self.wh_data.stock_queue, str): self.wh_data.stock_queue = json.loads(self.wh_data.stock_queue) if not self.wh_data.prev_stock_value: self.wh_data.prev_stock_value = self.wh_data.stock_value self.validate_previous_sle_qty(sle) if (sle.serial_no and not self.via_landed_cost_voucher) or not cint(self.allow_negative_stock): # validate negative stock for serialized items, fifo valuation # or when negative stock is not allowed for moving average if not self.validate_negative_stock(sle): self.wh_data.qty_after_transaction += flt(sle.actual_qty) return # Get dynamic incoming/outgoing rate if not self.args.get("sle_id"): self.get_dynamic_incoming_outgoing_rate(sle) if ( sle.voucher_type in ["Purchase Receipt", "Purchase Invoice"] and sle.voucher_detail_no and is_internal_transfer(sle) ): # Anchor both legs of an internal-transfer PR/PI to the DN/SI incoming_rate; # otherwise an inward SLE that inherits a stale PR.valuation_rate leaks the # gap to COGS via divisional_loss. rate = get_incoming_rate_for_inter_company_transfer(sle) if sle.actual_qty < 0: sle.outgoing_rate = rate elif rate: sle.incoming_rate = rate dimensions = get_inventory_dimensions() has_dimensions = False if dimensions: for dimension in dimensions: if sle.get(dimension.get("fieldname")): has_dimensions = True if self.valuation_method == "Standard Cost": # Inventory is always carried at the standard rate effective on the posting date; # FIFO/Moving Average/serial-batch valuation is bypassed entirely. self.process_standard_cost(sle) elif sle.serial_and_batch_bundle: self.calculate_valuation_for_serial_batch_bundle(sle) elif sle.serial_no and not self.args.get("sle_id"): # Only run in reposting self.get_serialized_values(sle) self.wh_data.qty_after_transaction += flt(sle.actual_qty) if sle.voucher_type == "Stock Reconciliation" and not sle.batch_no and has_correct_data(sle): self.wh_data.qty_after_transaction = sle.qty_after_transaction self.wh_data.stock_value = flt(self.wh_data.qty_after_transaction) * flt( self.wh_data.valuation_rate ) elif ( sle.batch_no and frappe.db.get_value("Batch", sle.batch_no, "use_batchwise_valuation", cache=True) and not self.args.get("sle_id") ): # Only run in reposting self.update_batched_values(sle) else: if ( sle.voucher_type == "Stock Reconciliation" and not sle.batch_no and not sle.has_batch_no and not has_dimensions ): # assert if ( sle.voucher_detail_no and self.repost_doc and self.repost_doc.get("recalculate_valuation_rate") ): source_rate = frappe.get_cached_value( "Stock Reconciliation Item", sle.voucher_detail_no, "valuation_rate" ) if source_rate: sle.valuation_rate = source_rate self.wh_data.valuation_rate = sle.valuation_rate self.wh_data.qty_after_transaction = sle.qty_after_transaction self.wh_data.stock_value = flt(self.wh_data.qty_after_transaction) * flt( self.wh_data.valuation_rate ) if self.valuation_method != "Moving Average": self.wh_data.stock_queue = [ [self.wh_data.qty_after_transaction, self.wh_data.valuation_rate] ] else: if self.valuation_method == "Moving Average": self.get_moving_average_values(sle) self.wh_data.qty_after_transaction += flt(sle.actual_qty) self.wh_data.stock_value = flt(self.wh_data.qty_after_transaction) * flt( self.wh_data.valuation_rate ) if flt(self.wh_data.qty_after_transaction, self.flt_precision) != 0: self.wh_data.valuation_rate = flt( self.wh_data.stock_value, self.currency_precision ) / flt(self.wh_data.qty_after_transaction, self.flt_precision) else: self.update_queue_values(sle) # rounding as per precision self.wh_data.stock_value = flt(self.wh_data.stock_value, self.currency_precision) if not self.wh_data.qty_after_transaction: self.wh_data.stock_value = 0.0 if sle.actual_qty < 0: sle.incoming_rate = 0 stock_value_difference = self.wh_data.stock_value - self.wh_data.prev_stock_value self.wh_data.prev_stock_value = self.wh_data.stock_value # update current sle sle.qty_after_transaction = flt(self.wh_data.qty_after_transaction, self.flt_precision) sle.valuation_rate = self.wh_data.valuation_rate sle.stock_value = self.wh_data.stock_value sle.stock_queue = json.dumps(self.wh_data.stock_queue) old_stock_value_difference = sle.stock_value_difference sle.stock_value_difference = stock_value_difference if ( sle.is_adjustment_entry and flt(sle.qty_after_transaction, self.flt_precision) == 0 and ( flt(sle.stock_value, self.currency_precision) != 0 or flt(sle.stock_value_difference, self.currency_precision) == 0 ) ): sle.stock_value_difference = ( get_stock_value_difference( sle.item_code, sle.warehouse, sle.posting_date, sle.posting_time, voucher_detail_no=sle.voucher_detail_no, creation=sle.creation, ) * -1 ) sle.doctype = "Stock Ledger Entry" sle.modified = now() frappe.get_doc(sle).db_update() self.prev_sle_dict[key] = sle if not self.args.get("sle_id") or ( sle.serial_and_batch_bundle and sle.auto_created_serial_and_batch_bundle ): self.update_outgoing_rate_on_transaction(sle) if flt(old_stock_value_difference, self.currency_precision) == flt( sle.stock_value_difference, self.currency_precision ): return if not cint(erpnext.is_perpetual_inventory_enabled(sle.company)): return if self.args.item_code != sle.item_code or self.args.warehouse != sle.warehouse: self.repost_affected_transaction.add((sle.voucher_type, sle.voucher_no)) def get_serialized_values(self, sle): from erpnext.stock.serial_batch_bundle import SerialNoValuation incoming_rate = flt(sle.incoming_rate) actual_qty = flt(sle.actual_qty) if incoming_rate < 0: # wrong incoming rate incoming_rate = self.wh_data.valuation_rate stock_value_change = 0 if actual_qty > 0: stock_value_change = actual_qty * incoming_rate else: # In case of delivery/stock issue, get average purchase rate # of serial nos of current entry if not sle.is_cancelled: new_sle = copy.deepcopy(sle) new_sle.qty = new_sle.actual_qty new_sle.serial_nos = get_serial_nos_data(new_sle.get("serial_no")) sn_obj = SerialNoValuation( sle=new_sle, warehouse=new_sle.get("warehouse"), item_code=new_sle.get("item_code") ) outgoing_value = sn_obj.get_incoming_rate() stock_value_change = actual_qty * outgoing_value else: stock_value_change = actual_qty * sle.outgoing_rate new_stock_qty = self.wh_data.qty_after_transaction + actual_qty if new_stock_qty > 0: new_stock_value = ( self.wh_data.qty_after_transaction * self.wh_data.valuation_rate ) + stock_value_change if new_stock_value >= 0: # calculate new valuation rate only if stock value is positive # else it remains the same as that of previous entry self.wh_data.valuation_rate = new_stock_value / new_stock_qty if self.wh_data.valuation_rate is None and sle.voucher_detail_no: allow_zero_rate = self.check_if_allow_zero_valuation_rate(sle.voucher_type, sle.voucher_detail_no) if not allow_zero_rate: self.wh_data.valuation_rate = self.get_fallback_rate(sle) def calculate_valuation_for_serial_batch_bundle(self, sle): if not frappe.db.exists("Serial and Batch Bundle", sle.serial_and_batch_bundle): return if sle.actual_qty < 0 and ( sle.voucher_type in ["Stock Reconciliation", "Asset Capitalization"] or not frappe.db.get_value(sle.voucher_type, sle.voucher_no, "is_return") ): doc = frappe._dict({}) self.update_serial_batch_no_valuation(sle, doc, prev_sle=self.wh_data) else: doc = frappe.get_doc("Serial and Batch Bundle", sle.serial_and_batch_bundle) doc.set_incoming_rate( save=True, allow_negative_stock=self.allow_negative_stock, prev_sle=self.wh_data ) doc.calculate_qty_and_amount(save=True) if stock_queue := frappe.get_all( "Serial and Batch Entry", filters={"parent": sle.serial_and_batch_bundle, "stock_queue": ("is", "set")}, pluck="stock_queue", order_by="idx desc", limit=1, ): self.wh_data.stock_queue = json.loads(stock_queue[0]) if stock_queue else [] self.wh_data.stock_value = round_off_if_near_zero(self.wh_data.stock_value + doc.total_amount) # Replay the immutable qty recorded on the SLE at submission, not the bundle's recomputed # total_qty. A valuation repost must never rewrite physical quantities; if the bundle's child # rows were edited after submission, doc.total_qty would silently corrupt qty_after_transaction # (and every downstream balance). sle.actual_qty is the frozen movement for this entry. self.wh_data.qty_after_transaction += flt(sle.actual_qty, self.flt_precision) if flt(self.wh_data.qty_after_transaction, self.flt_precision): self.wh_data.valuation_rate = flt(self.wh_data.stock_value, self.flt_precision) / flt( self.wh_data.qty_after_transaction, self.flt_precision ) def update_serial_batch_no_valuation(self, sle, doc, prev_sle=None): from erpnext.stock.serial_batch_bundle import BatchNoValuation, SerialNoValuation sabb_data = get_serial_from_sabb(sle.serial_and_batch_bundle) if not sabb_data: doc.update({"total_amount": 0.0, "total_qty": 0.0, "avg_rate": 0.0}) return serial_nos = [d.serial_no for d in sabb_data if d.serial_no] if serial_nos: sle["serial_nos"] = get_serial_nos_data(",".join(serial_nos)) sn_obj = SerialNoValuation( sle=sle, item_code=self.item_code, warehouse=sle.warehouse, ) else: sle["batch_nos"] = {row.batch_no: row for row in sabb_data if row.batch_no} sn_obj = BatchNoValuation( sle=sle, item_code=self.item_code, warehouse=sle.warehouse, prev_sle=prev_sle, ) tot_amt = 0.0 total_qty = 0.0 avg_rate = 0.0 for d in sabb_data: incoming_rate = get_incoming_rate_for_serial_and_batch(self.item_code, d, sn_obj, self.company) amount = incoming_rate * flt(d.qty) tot_amt += flt(amount) total_qty += flt(d.qty) if flt(incoming_rate, self.currency_precision) == flt( d.incoming_rate, self.currency_precision ) and not getattr(d, "stock_queue", None): continue values_to_update = { "incoming_rate": incoming_rate, "stock_value_difference": amount, } if d.stock_queue: values_to_update["stock_queue"] = d.stock_queue frappe.db.set_value( "Serial and Batch Entry", d.name, values_to_update, update_modified=False, ) if total_qty: avg_rate = tot_amt / total_qty doc.update( { "total_amount": tot_amt, "total_qty": total_qty, "avg_rate": avg_rate, } ) frappe.db.set_value( "Serial and Batch Bundle", sle.serial_and_batch_bundle, { "total_qty": total_qty, "avg_rate": avg_rate, "total_amount": tot_amt, }, update_modified=False, ) for key in ("serial_nos", "batch_nos"): if key in sle: del sle[key] def get_outgoing_rate_for_batched_item(self, sle): if self.wh_data.qty_after_transaction == 0: return 0 return flt(self.wh_data.stock_value) / flt(self.wh_data.qty_after_transaction) def validate_negative_stock(self, sle): """ validate negative stock for entries current datetime onwards will not consider cancelled entries """ diff = self.wh_data.qty_after_transaction + flt(sle.actual_qty) - flt(self.reserved_stock) diff = flt(diff, self.flt_precision) # respect system precision diff_threshold = 0.0001 if self.flt_precision > 4: diff_threshold = 10 ** (-1 * self.flt_precision) if diff < 0 and abs(diff) > diff_threshold: # negative stock! exc = sle.copy().update({"diff": diff}) self.exceptions.setdefault(sle.warehouse, []).append(exc) return False else: return True def get_dynamic_incoming_outgoing_rate(self, sle): # Get updated incoming/outgoing rate from transaction if ( sle.recalculate_rate or self.has_landed_cost_based_on_pi(sle) or (sle.voucher_type == "Stock Entry" and sle.actual_qty > 0 and is_repack_entry(sle.voucher_no)) or (self.repost_doc and self.repost_doc.get("recalculate_valuation_rate")) ): rate = self.get_incoming_outgoing_rate_from_transaction(sle) if flt(sle.actual_qty) >= 0: sle.incoming_rate = rate else: sle.outgoing_rate = rate def has_landed_cost_based_on_pi(self, sle): if sle.voucher_type == "Purchase Receipt" and frappe.db.get_single_value( "Buying Settings", "set_landed_cost_based_on_purchase_invoice_rate" ): return True return False def get_incoming_outgoing_rate_from_transaction(self, sle): rate = 0 # Material Transfer, Repack, Manufacturing if sle.voucher_type == "Stock Entry": self.recalculate_amounts_in_stock_entry(sle.voucher_no, sle.voucher_detail_no) rate = frappe.db.get_value("Stock Entry Detail", sle.voucher_detail_no, "valuation_rate") # Sales and Purchase Return elif sle.voucher_type in ( "Purchase Receipt", "Purchase Invoice", "Delivery Note", "Sales Invoice", "Subcontracting Receipt", ): if frappe.get_cached_value(sle.voucher_type, sle.voucher_no, "is_return"): from erpnext.controllers.sales_and_purchase_return import ( get_rate_for_return, # don't move this import to top ) if ( self.valuation_method == "Moving Average" and not sle.get("serial_no") and not sle.get("batch_no") and not sle.get("serial_and_batch_bundle") ): rate = self.get_moving_average_rate_for_return(sle) if not rate and sle.voucher_type in ["Delivery Note", "Sales Invoice"]: rate = get_rate_for_return( sle.voucher_type, sle.voucher_no, sle.item_code, voucher_detail_no=sle.voucher_detail_no, sle=sle, ) else: rate = get_rate_for_return( sle.voucher_type, sle.voucher_no, sle.item_code, voucher_detail_no=sle.voucher_detail_no, sle=sle, ) if ( sle.get("serial_and_batch_bundle") and rate > 0 and sle.voucher_type in ["Delivery Note", "Sales Invoice"] ): frappe.db.set_value( sle.voucher_type + " Item", sle.voucher_detail_no, "incoming_rate", rate, ) elif ( sle.voucher_type in ["Purchase Receipt", "Purchase Invoice"] and sle.voucher_detail_no and is_internal_transfer(sle) ): rate = get_incoming_rate_for_inter_company_transfer(sle) else: if sle.voucher_type in ("Purchase Receipt", "Purchase Invoice"): rate_field = "valuation_rate" elif sle.voucher_type == "Subcontracting Receipt": rate_field = "rate" else: rate_field = "incoming_rate" # check in item table item_code, incoming_rate = frappe.db.get_value( sle.voucher_type + " Item", sle.voucher_detail_no, ["item_code", rate_field] ) if item_code == sle.item_code: rate = incoming_rate else: if sle.voucher_type in ("Delivery Note", "Sales Invoice"): ref_doctype = "Packed Item" elif sle.voucher_type == "Subcontracting Receipt": ref_doctype = "Subcontracting Receipt Supplied Item" else: ref_doctype = "Purchase Receipt Item Supplied" rate = frappe.db.get_value( ref_doctype, {"parent_detail_docname": sle.voucher_detail_no, "item_code": sle.item_code}, rate_field, ) return rate def get_moving_average_rate_for_return(self, sle): """Rate just before this entry, taken from the in-memory running state so a multi-line return never reads a sibling row of its own voucher.""" rate = flt(self.wh_data.valuation_rate) if rate: return rate previous_sle = get_previous_sle_of_current_voucher( frappe._dict( item_code=sle.item_code, warehouse=sle.warehouse, posting_date=sle.posting_date, posting_time=sle.posting_time, voucher_no=sle.voucher_no, ), exclude_current_voucher=True, ) rate = previous_sle.get("valuation_rate") if rate is None: rate = get_valuation_rate( sle.item_code, sle.warehouse, sle.voucher_type, sle.voucher_no, self.allow_zero_rate, currency=erpnext.get_company_currency(sle.company), company=sle.company, ) return flt(rate) def update_outgoing_rate_on_transaction(self, sle): """ Update outgoing rate in Stock Entry, Delivery Note, Sales Invoice and Sales Return In case of Stock Entry, also calculate FG Item rate and total incoming/outgoing amount """ if sle.voucher_type == "Stock Reconciliation": if flt(sle.actual_qty) <= 0 and not self.args.get("sle_id"): self.update_rate_on_stock_reconciliation(sle) return if sle.actual_qty and sle.voucher_detail_no: outgoing_rate = abs(flt(sle.stock_value_difference)) / abs(sle.actual_qty) if flt(sle.actual_qty) < 0 and sle.voucher_type == "Stock Entry": self.update_rate_on_stock_entry(sle, outgoing_rate) elif sle.voucher_type in ("Delivery Note", "Sales Invoice"): self.update_rate_on_delivery_and_sales_return(sle, outgoing_rate) elif flt(sle.actual_qty) < 0 and sle.voucher_type in ("Purchase Receipt", "Purchase Invoice"): self.update_rate_on_purchase_receipt(sle, outgoing_rate) elif flt(sle.actual_qty) < 0 and sle.voucher_type == "Subcontracting Receipt": self.update_rate_on_subcontracting_receipt(sle, outgoing_rate) def update_rate_on_stock_entry(self, sle, outgoing_rate): frappe.db.set_value("Stock Entry Detail", sle.voucher_detail_no, "basic_rate", outgoing_rate) # Update outgoing item's rate, recalculate FG Item's rate and total incoming/outgoing amount if not sle.dependant_sle_voucher_detail_no or self.is_manufacture_entry_with_sabb(sle): self.recalculate_amounts_in_stock_entry(sle.voucher_no, sle.voucher_detail_no) def is_manufacture_entry_with_sabb(self, sle): if ( self.args.get("sle_id") and sle.serial_and_batch_bundle and sle.auto_created_serial_and_batch_bundle ): purpose = frappe.get_cached_value("Stock Entry", sle.voucher_no, "purpose") if purpose in ["Manufacture", "Repack"]: return True return False def recalculate_amounts_in_stock_entry(self, voucher_no, voucher_detail_no): stock_entry = frappe.get_lazy_doc("Stock Entry", voucher_no, for_update=True) stock_entry.calculate_rate_and_amount(reset_outgoing_rate=False, raise_error_if_no_rate=False) stock_entry.db_update() for d in stock_entry.items: # Update only the row that matches the voucher_detail_no or the row containing the FG/Scrap Item. if ( d.name == voucher_detail_no or (not d.s_warehouse and d.t_warehouse) or stock_entry.purpose in ["Manufacture", "Repack"] ): d.db_update() def update_rate_on_delivery_and_sales_return(self, sle, outgoing_rate): # Update item's incoming rate on transaction item_code = frappe.db.get_value(sle.voucher_type + " Item", sle.voucher_detail_no, "item_code") if item_code == sle.item_code: frappe.db.set_value( sle.voucher_type + " Item", sle.voucher_detail_no, "incoming_rate", outgoing_rate ) else: # packed item frappe.db.set_value( "Packed Item", {"parent_detail_docname": sle.voucher_detail_no, "item_code": sle.item_code}, "incoming_rate", outgoing_rate, ) def update_rate_on_purchase_receipt(self, sle, outgoing_rate): if frappe.db.exists(sle.voucher_type + " Item", sle.voucher_detail_no): if sle.voucher_type in ["Purchase Receipt", "Purchase Invoice"]: details = frappe.get_cached_value( sle.voucher_type, sle.voucher_no, ["is_internal_supplier", "is_return", "return_against"], as_dict=True, ) if details.is_internal_supplier or (details.is_return and not details.return_against): rate = outgoing_rate if details.is_return else sle.outgoing_rate frappe.db.set_value( f"{sle.voucher_type} Item", sle.voucher_detail_no, "valuation_rate", rate ) else: frappe.db.set_value( "Purchase Receipt Item Supplied", sle.voucher_detail_no, "rate", outgoing_rate ) # Recalculate subcontracted item's rate in case of subcontracted purchase receipt/invoice if frappe.get_cached_value(sle.voucher_type, sle.voucher_no, "is_subcontracted"): doc = frappe.get_lazy_doc(sle.voucher_type, sle.voucher_no) doc.update_valuation_rate(reset_outgoing_rate=False) for d in doc.items + doc.supplied_items: d.db_update() def update_rate_on_subcontracting_receipt(self, sle, outgoing_rate): if frappe.db.exists("Subcontracting Receipt Item", sle.voucher_detail_no): frappe.db.set_value("Subcontracting Receipt Item", sle.voucher_detail_no, "rate", outgoing_rate) else: frappe.db.set_value( "Subcontracting Receipt Supplied Item", sle.voucher_detail_no, {"rate": outgoing_rate, "amount": abs(sle.actual_qty) * outgoing_rate}, ) scr = frappe.get_lazy_doc("Subcontracting Receipt", sle.voucher_no, for_update=True) scr.calculate_items_qty_and_amount() scr.db_update() for d in scr.items: d.db_update() def update_rate_on_stock_reconciliation(self, sle): # Refresh the reconciliation's difference amount and per-row current qty/rate from the reposted # ledger so the document keeps matching the GL entries. Handles serialized, batched and # non-serialized items uniformly (the document method reads the current bundle for serial/batch # rows and the pre-reconciliation ledger balance for non-serial rows). frappe.get_lazy_doc( "Stock Reconciliation", sle.voucher_no, for_update=True ).recalculate_difference_amount_from_ledger() @staticmethod def get_incoming_value_for_serial_nos(sle, serial_nos): # get rate from serial nos within same company all_serial_nos = frappe.get_all( "Serial No", fields=["purchase_rate", "name", "company"], filters={"name": ("in", serial_nos)} ) incoming_values = sum(flt(d.purchase_rate) for d in all_serial_nos if d.company == sle.company) # Get rate for serial nos which has been transferred to other company invalid_serial_nos = [d.name for d in all_serial_nos if d.company != sle.company] sle_entry = frappe.qb.DocType("Stock Ledger Entry") for serial_no in invalid_serial_nos: incoming_rate = ( frappe.qb.from_(sle_entry) .select(sle_entry.incoming_rate) .where( (sle_entry.company == sle.company) & (sle_entry.actual_qty > 0) & (sle_entry.is_cancelled == 0) & ( (Lower(sle_entry.serial_no) == serial_no.lower()) | Lower(sle_entry.serial_no).like((serial_no + "\n%").lower()) | Lower(sle_entry.serial_no).like(("%\n" + serial_no).lower()) | Lower(sle_entry.serial_no).like(("%\n" + serial_no + "\n%").lower()) ) ) .orderby(sle_entry.posting_date, order=frappe.qb.desc) .orderby(sle_entry.creation, order=frappe.qb.desc) .orderby(sle_entry.name, order=frappe.qb.desc) .limit(1) ).run() incoming_values += flt(incoming_rate[0][0]) if incoming_rate else 0 return incoming_values def get_moving_average_values(self, sle): actual_qty = flt(sle.actual_qty) new_stock_qty = flt(self.wh_data.qty_after_transaction) + actual_qty if new_stock_qty >= 0: if actual_qty > 0: if flt(self.wh_data.qty_after_transaction) <= 0: self.wh_data.valuation_rate = sle.incoming_rate else: new_stock_value = (self.wh_data.qty_after_transaction * self.wh_data.valuation_rate) + ( actual_qty * sle.incoming_rate ) self.wh_data.valuation_rate = new_stock_value / new_stock_qty elif sle.outgoing_rate: if new_stock_qty: new_stock_value = (self.wh_data.qty_after_transaction * self.wh_data.valuation_rate) + ( actual_qty * sle.outgoing_rate ) self.wh_data.valuation_rate = new_stock_value / new_stock_qty else: self.wh_data.valuation_rate = sle.outgoing_rate else: if flt(self.wh_data.qty_after_transaction) >= 0 and sle.outgoing_rate: self.wh_data.valuation_rate = sle.outgoing_rate if not self.wh_data.valuation_rate and actual_qty > 0: self.wh_data.valuation_rate = sle.incoming_rate # Get valuation rate from previous SLE or Item master, if item does not have the # allow zero valuration rate flag set if not self.wh_data.valuation_rate and sle.voucher_detail_no: allow_zero_valuation_rate = self.check_if_allow_zero_valuation_rate( sle.voucher_type, sle.voucher_detail_no ) if not allow_zero_valuation_rate: self.wh_data.valuation_rate = self.get_fallback_rate(sle) def update_queue_values(self, sle): incoming_rate = flt(sle.incoming_rate) actual_qty = flt(sle.actual_qty) outgoing_rate = flt(sle.outgoing_rate) self.wh_data.qty_after_transaction = round_off_if_near_zero( self.wh_data.qty_after_transaction + actual_qty ) if self.valuation_method == "LIFO": stock_queue = LIFOValuation(self.wh_data.stock_queue) else: stock_queue = FIFOValuation(self.wh_data.stock_queue) _prev_qty, prev_stock_value = stock_queue.get_total_stock_and_value() if actual_qty > 0: stock_queue.add_stock(qty=actual_qty, rate=incoming_rate) else: def rate_generator() -> float: allow_zero_valuation_rate = self.check_if_allow_zero_valuation_rate( sle.voucher_type, sle.voucher_detail_no ) if not allow_zero_valuation_rate: return self.get_fallback_rate(sle) else: return 0.0 stock_queue.remove_stock( qty=abs(actual_qty), outgoing_rate=outgoing_rate, rate_generator=rate_generator, is_return_purchase_entry=self.is_return_purchase_entry(sle), ) _qty, stock_value = stock_queue.get_total_stock_and_value() stock_value_difference = stock_value - prev_stock_value self.wh_data.stock_queue = stock_queue.state self.wh_data.stock_value = round_off_if_near_zero(self.wh_data.stock_value + stock_value_difference) if not self.wh_data.stock_queue: self.wh_data.stock_queue.append( [0, sle.incoming_rate or sle.outgoing_rate or self.wh_data.valuation_rate] ) if self.wh_data.qty_after_transaction: self.wh_data.valuation_rate = self.wh_data.stock_value / self.wh_data.qty_after_transaction def is_return_purchase_entry(self, sle): if sle.voucher_type in ["Purchase Invoice", "Purchase Receipt"]: return frappe.get_cached_value(sle.voucher_type, sle.voucher_no, "is_return") return False def update_batched_values(self, sle): from erpnext.stock.serial_batch_bundle import BatchNoValuation incoming_rate = flt(sle.incoming_rate) actual_qty = flt(sle.actual_qty) self.wh_data.qty_after_transaction = round_off_if_near_zero( self.wh_data.qty_after_transaction + actual_qty ) if actual_qty > 0: stock_value_difference = incoming_rate * actual_qty else: new_sle = copy.deepcopy(sle) new_sle.qty = new_sle.actual_qty new_sle.batch_nos = frappe._dict({new_sle.batch_no: new_sle}) batch_obj = BatchNoValuation( sle=new_sle, warehouse=new_sle.get("warehouse"), item_code=new_sle.get("item_code"), ) outgoing_rate = batch_obj.get_incoming_rate() if outgoing_rate is None: # This can *only* happen if qty available for the batch is zero. # in such case fall back various other rates. # future entries will correct the overall accounting as each # batch individually uses moving average rates. outgoing_rate = self.get_fallback_rate(sle) stock_value_difference = outgoing_rate * actual_qty self.wh_data.stock_value = round_off_if_near_zero(self.wh_data.stock_value + stock_value_difference) if self.wh_data.qty_after_transaction: self.wh_data.valuation_rate = self.wh_data.stock_value / self.wh_data.qty_after_transaction def check_if_allow_zero_valuation_rate(self, voucher_type, voucher_detail_no): ref_item_dt = "" if voucher_type == "Stock Entry": ref_item_dt = voucher_type + " Detail" elif voucher_type in ["Purchase Invoice", "Sales Invoice", "Delivery Note", "Purchase Receipt"]: ref_item_dt = voucher_type + " Item" if ref_item_dt: return frappe.db.get_value(ref_item_dt, voucher_detail_no, "allow_zero_valuation_rate") else: return 0 def get_fallback_rate(self, sle) -> float: """When exact incoming rate isn't available use any of other "average" rates as fallback. This should only get used for negative stock.""" return get_valuation_rate( sle.item_code, sle.warehouse, sle.voucher_type, sle.voucher_no, self.allow_zero_rate, currency=erpnext.get_company_currency(sle.company), company=sle.company, ) def get_sle_before_datetime(self, args): """get previous stock ledger entry before current time-bucket""" sle = get_stock_ledger_entries(args, "<", "desc", "limit 1", for_update=False) sle = sle[0] if sle else frappe._dict() return sle def get_sle_after_datetime(self, args): """get Stock Ledger Entries after a particular datetime, for reposting""" return get_stock_ledger_entries(args, ">", "asc", for_update=True, check_serial_no=False) def raise_exceptions(self): msg_list = [] for warehouse, exceptions in self.exceptions.items(): deficiency = min(e["diff"] for e in exceptions) if ( exceptions[0]["voucher_type"], exceptions[0]["voucher_no"], ) in frappe.local.flags.currently_saving: msg = _("{0} units of {1} needed in {2} to complete this transaction.").format( frappe.bold(abs(deficiency)), frappe.get_desk_link("Item", exceptions[0]["item_code"], show_title_with_name=True), frappe.get_desk_link("Warehouse", warehouse), ) else: msg = _( "{0} units of {1} needed in {2} on {3} {4} for {5} to complete this transaction." ).format( frappe.bold(abs(deficiency)), frappe.get_desk_link("Item", exceptions[0]["item_code"], show_title_with_name=True), frappe.get_desk_link("Warehouse", warehouse), exceptions[0]["posting_date"], exceptions[0]["posting_time"], frappe.get_desk_link(exceptions[0]["voucher_type"], exceptions[0]["voucher_no"]), ) if msg: if self.reserved_stock: allowed_qty = abs(exceptions[0]["actual_qty"]) - abs(exceptions[0]["diff"]) if allowed_qty > 0: msg = "{} As {} units are reserved for other sales orders, you are allowed to consume only {} units.".format( msg, frappe.bold(self.reserved_stock), frappe.bold(allowed_qty) ) else: msg = f"{msg} As the full stock is reserved for other transactions, you're not allowed to consume the stock." msg_list.append(msg) if msg_list: message = "\n\n".join(msg_list) if self.verbose: frappe.throw(message, NegativeStockError, title=_("Insufficient Stock")) else: raise NegativeStockError(message) def update_bin(self): # update bin for each warehouse for (item_code, warehouse), data in self.prev_sle_dict.items(): bin_name = get_or_make_bin(item_code, warehouse) updated_values = { "actual_qty": flt(data.qty_after_transaction), "stock_value": flt(data.stock_value), } if data.valuation_rate is not None: updated_values["valuation_rate"] = flt(data.valuation_rate) frappe.db.set_value("Bin", bin_name, updated_values, update_modified=True) self.reset_bin_without_stock_ledger_entries() def reset_bin_without_stock_ledger_entries(self): """Reset the bin when its ledger has no entries left, prev_sle_dict never covers that case.""" item_code, warehouse = self.args.get("item_code"), self.args.get("warehouse") if not item_code or not warehouse or (item_code, warehouse) in self.prev_sle_dict: return if frappe.db.exists( "Stock Ledger Entry", {"item_code": item_code, "warehouse": warehouse, "is_cancelled": 0} ): return bin_name = frappe.db.get_value("Bin", {"item_code": item_code, "warehouse": warehouse}) if not bin_name: return frappe.db.set_value( "Bin", bin_name, {"actual_qty": 0.0, "stock_value": 0.0, "valuation_rate": 0.0}, update_modified=True, ) def get_sle_against_current_voucher(kwargs): kwargs["posting_datetime"] = get_combine_datetime(kwargs.posting_date, kwargs.posting_time) doctype = frappe.qb.DocType("Stock Ledger Entry") query = ( frappe.qb.from_(doctype) .select("*") .where( (doctype.item_code == kwargs.item_code) & (doctype.warehouse == kwargs.warehouse) & (doctype.is_cancelled == 0) & (doctype.posting_datetime == kwargs.posting_datetime) ) .orderby(doctype.creation, order=Order.asc) .for_update() ) if not kwargs.get("cancelled"): query = query.where(doctype.creation == kwargs.creation) return query.run(as_dict=True) def get_previous_sle_of_current_voucher(args, operator="<", exclude_current_voucher=False): """get stock ledger entries filtered by specific posting datetime conditions""" if not args.get("posting_date"): args["posting_datetime"] = "1900-01-01 00:00:00" if not args.get("posting_datetime"): args["posting_datetime"] = get_combine_datetime(args["posting_date"], args["posting_time"]) voucher_condition = "" if exclude_current_voucher: voucher_no = args.get("voucher_no") voucher_condition = f"and voucher_no != '{voucher_no}'" elif args.get("creation") and args.get("sle_id") and not args.get("cancelled"): creation = args.get("creation") operator = "<=" voucher_condition = f"and creation < '{creation}'" sle = frappe.db.sql( # nosemgrep f""" select *, posting_datetime as "timestamp" from `tabStock Ledger Entry` where item_code = %(item_code)s and warehouse = %(warehouse)s and is_cancelled = 0 {voucher_condition} and ( posting_datetime {operator} %(posting_datetime)s ) order by posting_datetime desc, creation desc limit 1 for update""", { "item_code": args.get("item_code"), "warehouse": args.get("warehouse"), "posting_datetime": args.get("posting_datetime"), }, as_dict=1, ) return sle[0] if sle else frappe._dict() def get_previous_sle(args, for_update=False, extra_cond=None, for_report=False): """ get the last sle on or before the current time-bucket, to get actual qty before transaction, this function is called from various transaction like stock entry, reco etc args = { "item_code": "ABC", "warehouse": "XYZ", "posting_date": "2012-12-12", "posting_time": "12:00", "sle": "name of reference Stock Ledger Entry" } """ args["name"] = args.get("sle", None) or "" sle = get_stock_ledger_entries( args, "<=", "desc", "limit 1", for_update=for_update, extra_cond=extra_cond, for_report=for_report ) return sle and sle[0] or {} def get_stock_ledger_entries( previous_sle, operator=None, order="desc", limit=None, for_update=False, debug=False, check_serial_no=True, extra_cond=None, for_report=False, ): """get stock ledger entries filtered by specific posting datetime conditions""" conditions = f" and posting_datetime {operator} %(posting_datetime)s" if item_code := previous_sle.get("item_code"): if isinstance(item_code, list | tuple): conditions += " and item_code in %(item_code)s" else: conditions += " and item_code = %(item_code)s" if warehouse := previous_sle.get("warehouse"): if isinstance(warehouse, list | tuple): conditions += " and warehouse in %(warehouse)s" else: conditions += " and warehouse = %(warehouse)s" elif previous_sle.get("warehouse_condition"): conditions += " and " + previous_sle.get("warehouse_condition") if check_serial_no and previous_sle.get("serial_no"): # conditions += " and serial_no like {}".format(frappe.db.escape('%{0}%'.format(previous_sle.get("serial_no")))) serial_no = previous_sle.get("serial_no") # lower() both sides so the match is case-insensitive on postgres too (MariaDB's collation # already is); a no-op on MariaDB. The set is already narrowed by item_code/warehouse, so the # functional comparison does not cost an index here. conditions += ( """ and ( lower(serial_no) = lower({}) or lower(serial_no) like lower({}) or lower(serial_no) like lower({}) or lower(serial_no) like lower({}) ) """ ).format( frappe.db.escape(serial_no), frappe.db.escape(f"{serial_no}\n%"), frappe.db.escape(f"%\n{serial_no}"), frappe.db.escape(f"%\n{serial_no}\n%"), ) if not previous_sle.get("posting_date"): previous_sle["posting_datetime"] = "1900-01-01 00:00:00" else: posting_time = previous_sle.get("posting_time") if not posting_time: posting_time = "00:00:00" previous_sle["posting_datetime"] = get_combine_datetime(previous_sle["posting_date"], posting_time) if operator in (">", "<=") and previous_sle.get("name"): conditions += " and name!=%(name)s" if extra_cond: conditions += f"{extra_cond}" if for_report and previous_sle.get("project"): conditions += " and project = %(project)s" # nosemgrep return frappe.db.sql( """ select *, posting_datetime as "timestamp" from `tabStock Ledger Entry` where is_cancelled = 0 {conditions} order by posting_datetime {order}, creation {order} {limit} {for_update}""".format( conditions=conditions, limit=limit or "", for_update=for_update and "for update" or "", order=order, ), previous_sle, as_dict=1, debug=debug, ) def get_sle_by_voucher_detail_no(voucher_detail_no): return frappe.get_all( "Stock Ledger Entry", filters={ "voucher_detail_no": voucher_detail_no, "is_cancelled": 0, "dependant_sle_voucher_detail_no": ("is", "not set"), }, fields=["item_code", "warehouse", "posting_date", "posting_time", "posting_datetime", "creation"], ) def get_valuation_rate( item_code, warehouse, voucher_type, voucher_no, allow_zero_rate=False, currency=None, company=None, fallbacks=True, raise_error_if_no_rate=True, batch_no=None, serial_and_batch_bundle=None, ): from erpnext.stock.serial_batch_bundle import BatchNoValuation if not company: company = frappe.get_cached_value("Warehouse", warehouse, "company") if warehouse and batch_no and frappe.db.get_value("Batch", batch_no, "use_batchwise_valuation"): table = frappe.qb.DocType("Stock Ledger Entry") query = ( frappe.qb.from_(table) .select(Sum(table.stock_value_difference) / NullIf(Sum(table.actual_qty), 0)) .where( (table.item_code == item_code) & (table.warehouse == warehouse) & (table.batch_no == batch_no) & (table.is_cancelled == 0) & ((table.voucher_no != voucher_no) | (table.voucher_type != voucher_type)) ) ) last_valuation_rate = query.run() if last_valuation_rate and last_valuation_rate[0][0] is not None: return flt(last_valuation_rate[0][0]) # Get moving average rate of a specific batch number if warehouse and serial_and_batch_bundle: batch_obj = BatchNoValuation( sle=frappe._dict( { "item_code": item_code, "warehouse": warehouse, "actual_qty": -1, "serial_and_batch_bundle": serial_and_batch_bundle, "posting_datetime": frappe.get_value( "Serial and Batch Bundle", serial_and_batch_bundle, "posting_datetime" ), } ) ) return batch_obj.get_incoming_rate() # Get valuation rate from last sle for the same item and warehouse sle_entry = frappe.qb.DocType("Stock Ledger Entry") if last_valuation_rate := ( frappe.qb.from_(sle_entry) .select(sle_entry.valuation_rate) .where( (sle_entry.item_code == item_code) & (sle_entry.warehouse == warehouse) & (sle_entry.valuation_rate >= 0) & (sle_entry.is_cancelled == 0) & ~((sle_entry.voucher_no == voucher_no) & (sle_entry.voucher_type == voucher_type)) ) .orderby(sle_entry.posting_datetime, order=frappe.qb.desc) .orderby(sle_entry.creation, order=frappe.qb.desc) .limit(1) ).run(): return flt(last_valuation_rate[0][0]) if fallbacks: # If negative stock allowed, and item delivered without any incoming entry, # system does not found any SLE, then take valuation rate from Item if rate := ( frappe.db.get_value("Item", item_code, "valuation_rate") or frappe.db.get_value("Item", item_code, "standard_rate") or frappe.db.get_value( "Item Price", dict(item_code=item_code, buying=1, currency=currency), "price_list_rate" ) ): return flt(rate) if ( not allow_zero_rate and raise_error_if_no_rate and cint(erpnext.is_perpetual_inventory_enabled(company)) ): form_link = get_link_to_form("Item", item_code) message = _( "Valuation Rate for the Item {0}, is required to do accounting entries for {1} {2}." ).format(form_link, voucher_type, voucher_no) message += "

" + _("Here are the options to proceed:") solutions = ( "
  • " + _( "If the item is transacting as a Zero Valuation Rate item in this entry, please enable 'Allow Zero Valuation Rate' in the {0} Item table." ).format(voucher_type) + "
  • " ) solutions += ( "
  • " + _("If not, you can Cancel / Submit this entry") + " {} ".format(frappe.bold(_("after"))) + _("performing either one below:") + "
  • " ) sub_solutions = "" msg = message + solutions + sub_solutions + "" frappe.throw(msg=msg, title=_("Valuation Rate Missing")) def update_qty_in_future_sle(args, allow_negative_stock=False): """Recalculate Qty after Transaction in future SLEs based on current SLE.""" qty_shift = args.actual_qty posting_datetime = get_combine_datetime(args["posting_date"], args["posting_time"]) args["posting_datetime"] = posting_datetime # find difference/shift in qty caused by stock reconciliation if args.voucher_type == "Stock Reconciliation": qty_shift = get_stock_reco_qty_shift(args) sle = frappe.qb.DocType("Stock Ledger Entry") future_condition = sle.posting_datetime > posting_datetime if args.get("creation") and not args.get("is_cancelled"): future_condition = future_condition | ( (sle.posting_datetime == posting_datetime) & (sle.creation > args.get("creation")) ) query = frappe.qb.update(sle).where( (sle.item_code == args.get("item_code")) & (sle.warehouse == args.get("warehouse")) & (sle.is_cancelled == 0) & future_condition ) # find the next nearest stock reco so that we only recalculate SLEs till that point next_stock_reco_detail = get_next_stock_reco(args) if next_stock_reco_detail: query = query.where(get_datetime_limit_condition(sle, next_stock_reco_detail[0])) new_qty = sle.qty_after_transaction + qty_shift if get_valuation_method(args.get("item_code"), args.get("company")) == "Standard Cost": # Standard Cost inventory is always carried at the standard rate, so a backdated entry only # shifts future balances — no full repost is needed. Update qty and value in place: # stock_value = qty_after_transaction * standard rate, which is constant across this range # (a rate change posts a reconciliation that bounds it). stock_value_difference is unchanged # because every future balance shifts by the same amount. from erpnext.stock.doctype.item_standard_cost.item_standard_cost import get_item_standard_rate standard_rate = flt( get_item_standard_rate(args.get("item_code"), args.get("company"), args.get("posting_date")) ) # Set stock_value before qty_after_transaction: MariaDB evaluates SET left-to-right with the # already-updated values, so stock_value must be computed while qty still holds its pre-shift # value. (Postgres uses pre-update values throughout, so the result is the same either way.) query = query.set(sle.stock_value, new_qty * standard_rate) query = query.set(sle.qty_after_transaction, new_qty) query.run() validate_negative_qty_in_future_sle(args, allow_negative_stock) def get_stock_reco_qty_shift(args): stock_reco_qty_shift = 0 if args.get("is_cancelled"): if args.get("previous_qty_after_transaction"): if args.get("serial_and_batch_bundle"): return args.get("previous_qty_after_transaction") # get qty (balance) that was set at submission last_balance = args.get("previous_qty_after_transaction") stock_reco_qty_shift = flt(args.qty_after_transaction) - flt(last_balance) else: stock_reco_qty_shift = flt(args.actual_qty) elif args.get("serial_and_batch_bundle"): stock_reco_qty_shift = flt(args.actual_qty) else: # reco is being submitted last_balance = get_previous_sle_of_current_voucher(args, "<=", exclude_current_voucher=True).get( "qty_after_transaction" ) if last_balance is not None: stock_reco_qty_shift = flt(args.qty_after_transaction) - flt(last_balance) else: stock_reco_qty_shift = args.qty_after_transaction return stock_reco_qty_shift def get_next_reco_datetime_condition(sle, kwargs): current_datetime = get_combine_datetime(kwargs.get("posting_date"), kwargs.get("posting_time")) if kwargs.get("is_cancelled"): return sle.posting_datetime >= current_datetime return (sle.posting_datetime > current_datetime) | ( (sle.posting_datetime == current_datetime) & (sle.creation > kwargs.get("creation")) ) def get_next_stock_reco(kwargs): """Returns next nearest stock reconciliaton's details.""" sle = frappe.qb.DocType("Stock Ledger Entry") query = ( frappe.qb.from_(sle) .select( sle.name, sle.posting_date, sle.posting_time, sle.creation, sle.voucher_no, sle.item_code, sle.batch_no, sle.serial_and_batch_bundle, sle.actual_qty, sle.has_batch_no, ) .where( (sle.item_code == kwargs.get("item_code")) & (sle.warehouse == kwargs.get("warehouse")) & (sle.voucher_type == "Stock Reconciliation") & (sle.voucher_no != kwargs.get("voucher_no")) & (sle.is_cancelled == 0) & get_next_reco_datetime_condition(sle, kwargs) ) .orderby(sle.posting_datetime) .orderby(sle.creation) .limit(1) ) return query.run(as_dict=True) def get_datetime_limit_condition(sle, detail): posting_datetime = get_combine_datetime(detail.posting_date, detail.posting_time) return (sle.posting_datetime < posting_datetime) | ( (sle.posting_datetime == posting_datetime) & (sle.creation < detail.creation) ) def validate_negative_qty_in_future_sle(args, allow_negative_stock=False): if allow_negative_stock or is_negative_stock_allowed(item_code=args.item_code): return if ( args.voucher_type == "Stock Reconciliation" and args.actual_qty < 0 and args.get("serial_and_batch_bundle") and frappe.db.get_value("Stock Reconciliation Item", args.voucher_detail_no, "qty") > 0 ): return if args.actual_qty >= 0 and args.voucher_type != "Stock Reconciliation": return neg_sle = get_future_sle_with_negative_qty(args) if is_negative_with_precision(neg_sle): message = _("{0} units of {1} needed in {2} on {3} {4} for {5} to complete this transaction.").format( abs(neg_sle[0]["qty_after_transaction"]), frappe.get_desk_link("Item", args.item_code, show_title_with_name=True), frappe.get_desk_link("Warehouse", args.warehouse), neg_sle[0]["posting_date"], neg_sle[0]["posting_time"], frappe.get_desk_link(neg_sle[0]["voucher_type"], neg_sle[0]["voucher_no"]), ) frappe.throw(message, NegativeStockError, title=_("Insufficient Stock")) if args.batch_no: neg_batch_sle = get_future_sle_with_negative_batch_qty(args) if is_negative_with_precision(neg_batch_sle, is_batch=True): message = _( "{0} units of {1} needed in {2} on {3} {4} for {5} to complete this transaction." ).format( abs(neg_batch_sle[0]["cumulative_total"]), frappe.get_desk_link("Batch", args.batch_no), frappe.get_desk_link("Warehouse", args.warehouse), neg_batch_sle[0]["posting_date"], neg_batch_sle[0]["posting_time"], frappe.get_desk_link(neg_batch_sle[0]["voucher_type"], neg_batch_sle[0]["voucher_no"]), ) frappe.throw(message, NegativeStockError, title=_("Insufficient Stock for Batch")) if args.reserved_stock: validate_reserved_stock(args) def is_negative_with_precision(neg_sle, is_batch=False): """ Returns whether system precision rounded qty is insufficient. E.g: -0.0003 in precision 3 (0.000) is sufficient for the user. """ if not neg_sle: return False field = "cumulative_total" if is_batch else "qty_after_transaction" precision = cint(frappe.db.get_default("float_precision")) or 2 qty_deficit = flt(neg_sle[0][field], precision) return qty_deficit < 0 and abs(qty_deficit) > 0.0001 def get_future_sle_with_negative_qty(sle_args): sle = frappe.qb.DocType("Stock Ledger Entry") return ( frappe.qb.from_(sle) .select( sle.qty_after_transaction, sle.posting_date, sle.posting_time, sle.voucher_type, sle.voucher_no, ) .where( (sle.item_code == sle_args["item_code"]) & (sle.warehouse == sle_args["warehouse"]) & (sle.voucher_no != sle_args["voucher_no"]) & (sle.posting_datetime >= sle_args["posting_datetime"]) & (sle.is_cancelled == 0) & (sle.qty_after_transaction < 0) ) .orderby(sle.posting_datetime) .orderby(sle.creation) .limit(1) ).run(as_dict=1) def get_future_sle_with_negative_batch_qty(sle_args): return frappe.db.sql( # nosemgrep """ with batch_ledger as ( select posting_date, posting_time, posting_datetime, voucher_type, voucher_no, sum(actual_qty) over (order by posting_datetime, creation) as cumulative_total from `tabStock Ledger Entry` where item_code = %(item_code)s and warehouse = %(warehouse)s and batch_no=%(batch_no)s and is_cancelled = 0 order by posting_datetime, creation ) select * from batch_ledger where cumulative_total < 0.0 and posting_datetime >= %(posting_datetime)s limit 1 """, sle_args, as_dict=1, ) def validate_reserved_stock(kwargs): # Qty based validation for non-serial-batch items OR SRE with Reservation Based On Qty. precision = cint(frappe.db.get_default("float_precision")) or 2 balance_qty = get_stock_balance(kwargs.item_code, kwargs.warehouse) diff = flt(balance_qty - kwargs.get("reserved_stock", 0), precision) if diff < 0 and abs(diff) > 0.0001: msg = _("{0} units of {1} needed in {2} on {3} {4} to complete this transaction.").format( abs(diff), frappe.get_desk_link("Item", kwargs.item_code, show_title_with_name=True), frappe.get_desk_link("Warehouse", kwargs.warehouse), nowdate(), nowtime(), ) frappe.throw(msg, title=_("Reserved Stock")) def validate_reserved_serial_nos(item_code, warehouse, serial_nos): if reserved_serial_nos_details := get_sre_reserved_serial_nos_details(item_code, warehouse, serial_nos): if common_serial_nos := list(set(serial_nos).intersection(set(reserved_serial_nos_details.keys()))): msg = _( "Serial Nos are reserved in Stock Reservation Entries, you need to unreserve them before proceeding." ) msg += "
    " msg += _("Example: Serial No {0} reserved in {1}.").format( frappe.bold(common_serial_nos[0]), frappe.get_desk_link( "Stock Reservation Entry", reserved_serial_nos_details[common_serial_nos[0]] ), ) frappe.throw(msg, title=_("Reserved Serial No.")) def validate_reserved_batch_nos(item_code, warehouse, batch_nos): if reserved_batches_map := get_sre_reserved_batch_nos_details(item_code, warehouse, batch_nos): available_batches = get_auto_batch_nos( frappe._dict( { "item_code": item_code, "warehouse": warehouse, "posting_datetime": get_combine_datetime(nowdate(), nowtime()), } ) ) available_batches_map = {row.batch_no: row.qty for row in available_batches} precision = cint(frappe.db.get_default("float_precision")) or 2 for batch_no in batch_nos: diff = flt( available_batches_map.get(batch_no, 0) - reserved_batches_map.get(batch_no, 0), precision ) if diff < 0 and abs(diff) > 0.0001: msg = _("{0} units of {1} needed in {2} on {3} {4} to complete this transaction.").format( abs(diff), frappe.get_desk_link("Batch", batch_no), frappe.get_desk_link("Warehouse", warehouse), nowdate(), nowtime(), ) frappe.throw(msg, title=_("Reserved Stock for Batch")) def is_negative_stock_allowed(*, item_code: str | None = None) -> bool: if frappe.get_cached_doc("Stock Settings").allow_negative_stock: return True if item_code and cint(frappe.get_cached_value("Item", item_code, "allow_negative_stock")): return True return False def get_incoming_rate_for_inter_company_transfer(sle) -> float: """ For inter company transfer, incoming rate is the average of the outgoing rate """ rate = 0.0 lcv_rate = 0.0 field = "delivery_note_item" if sle.voucher_type == "Purchase Receipt" else "sales_invoice_item" doctype = "Delivery Note Item" if sle.voucher_type == "Purchase Receipt" else "Sales Invoice Item" reference_name = frappe.get_cached_value(sle.voucher_type + " Item", sle.voucher_detail_no, field) if reference_name: rate = frappe.get_cached_value( doctype, reference_name, "incoming_rate", ) # add lcv amount in incoming_rate lcv_amount = frappe.db.get_value( f"{sle.voucher_type} Item", sle.voucher_detail_no, "landed_cost_voucher_amount" ) if lcv_amount: lcv_rate = flt(lcv_amount / abs(sle.actual_qty)) return rate + lcv_rate def is_internal_transfer(sle): data = frappe.get_cached_value( sle.voucher_type, sle.voucher_no, ["is_internal_supplier", "represents_company", "company"], as_dict=True, ) if data.is_internal_supplier and data.represents_company == data.company: return True def get_stock_value_difference( item_code, warehouse, posting_date, posting_time, voucher_no=None, voucher_detail_no=None, creation=None ): table = frappe.qb.DocType("Stock Ledger Entry") posting_datetime = get_combine_datetime(posting_date, posting_time) query = ( frappe.qb.from_(table) .select(Sum(table.stock_value_difference).as_("value")) .where((table.is_cancelled == 0) & (table.item_code == item_code) & (table.warehouse == warehouse)) ) if voucher_detail_no: query = query.where( (table.voucher_detail_no != voucher_detail_no) | (table.voucher_detail_no.isnull()) ) elif voucher_no: query = query.where(table.voucher_no != voucher_no) if creation: query = query.where( (table.posting_datetime < posting_datetime) | ((table.posting_datetime == posting_datetime) & (table.creation < creation)) ) else: query = query.where(table.posting_datetime <= posting_datetime) difference_amount = query.run() return flt(difference_amount[0][0]) if difference_amount else 0 @frappe.request_cache def is_transfer_stock_entry(voucher_no): purpose = frappe.get_cached_value("Stock Entry", voucher_no, "purpose") return purpose in ["Material Transfer", "Material Transfer for Manufacture", "Send to Subcontractor"] @frappe.request_cache def get_serial_from_sabb(serial_and_batch_bundle): return frappe.get_all( "Serial and Batch Entry", filters={"parent": serial_and_batch_bundle}, fields=["serial_no", "batch_no", "name", "qty", "incoming_rate"], order_by="idx", ) def get_incoming_rate_for_serial_and_batch(item_code, row, sn_obj, company): if row.serial_no: return abs(sn_obj.serial_no_incoming_rate.get(row.serial_no, 0.0)) else: stock_queue = [] if hasattr(sn_obj, "stock_queue") and sn_obj.stock_queue: stock_queue = parse_json(sn_obj.stock_queue) val_method = get_valuation_method(item_code, company) actual_qty = row.qty if stock_queue and val_method == "FIFO" and row.batch_no in sn_obj.non_batchwise_valuation_batches: if actual_qty < 0: stock_queue = FIFOValuation(stock_queue) _prev_qty, prev_stock_value = stock_queue.get_total_stock_and_value() stock_queue.remove_stock(qty=abs(actual_qty)) _qty, stock_value = stock_queue.get_total_stock_and_value() stock_value_difference = stock_value - prev_stock_value incoming_rate = abs(flt(stock_value_difference) / abs(flt(actual_qty))) stock_queue = stock_queue.state else: incoming_rate = abs(flt(sn_obj.batch_avg_rate.get(row.batch_no))) stock_queue.append([row.qty, incoming_rate]) row.stock_queue = json.dumps(stock_queue) else: incoming_rate = abs(flt(sn_obj.batch_avg_rate.get(row.batch_no))) return incoming_rate @frappe.request_cache def is_repack_entry(stock_entry_id): return frappe.get_cached_value("Stock Entry", stock_entry_id, "purpose") == "Repack" def has_correct_data(sle): previous_sle = get_previous_sle( { "item_code": sle.item_code, "warehouse": sle.warehouse, "posting_date": sle.posting_date, "posting_time": sle.posting_time, "creation": sle.creation, "sle": sle.name, } ) if not previous_sle: return True previous_qty = previous_sle.get("qty_after_transaction") or 0 if previous_qty and not frappe.db.get_value( "Stock Ledger Entry", {"voucher_detail_no": sle.voucher_detail_no, "is_cancelled": 0, "actual_qty": ("<", 0)}, ): return False return True