Nabin Hait
1ffdfbe86e
Merge pull request #56539 from frappe/chore/test-delayed-order-report
...
test: Delayed Order Report report coverage
2026-06-26 14:58:10 +05:30
Nabin Hait
c3ae7a0b95
Merge pull request #56538 from frappe/chore/test-delayed-item-report
...
test: Delayed Item Report report coverage
2026-06-26 14:57:51 +05:30
Nabin Hait
0458446a06
test: cover search_sub_assemblies filter in BOM Search report
2026-06-26 14:57:26 +05:30
Nabin Hait
99e85bfd82
Merge pull request #56537 from frappe/chore/test-batch-item-expiry-status
...
test: Batch Item Expiry Status report coverage
2026-06-26 14:56:31 +05:30
Nabin Hait
dca5d2ca3a
Merge pull request #56523 from frappe/chore/test-stock-ledger-invariant-check
...
test: Stock Ledger Invariant Check report coverage
2026-06-26 14:38:21 +05:30
Nabin Hait
dc59ee8034
Merge pull request #56533 from frappe/chore/test-item-variant-details
...
test: Item Variant Details report coverage
2026-06-26 14:36:58 +05:30
Nabin Hait
76da65ab4c
Merge pull request #56531 from frappe/chore/test-item-price-stock
...
test: Item Price Stock report coverage
2026-06-26 14:36:25 +05:30
Nabin Hait
bde23492fb
Merge pull request #56528 from frappe/chore/test-serial-no-ledger
...
test: Serial No Ledger report coverage
2026-06-26 14:34:51 +05:30
Nabin Hait
d47bc64576
Merge pull request #56527 from frappe/chore/test-serial-and-batch-summary
...
test: Serial and Batch Summary report coverage
2026-06-26 14:33:55 +05:30
Nabin Hait
4ac863d653
Merge pull request #56515 from frappe/chore/test-batch-wise-balance-history
...
test: Batch-Wise Balance History report coverage
2026-06-26 14:29:30 +05:30
Nabin Hait
5fe84305fc
Merge pull request #56503 from frappe/chore/trial-balance-for-party-test-coverage
...
test: Trial Balance for Party report coverage
2026-06-26 14:28:04 +05:30
Nabin Hait
a001a15312
test: reuse BootStrapTestData master data in Stock Ledger & Stock Projected Qty report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:20 +05:30
Nabin Hait
7f01d6b24e
test: reuse BootStrapTestData master data in Stock Balance report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:13 +05:30
Nabin Hait
f474c10f89
test: reuse BootStrapTestData master data in General Ledger report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:06 +05:30
Nabin Hait
a797c31b57
test: reuse BootStrapTestData master data in Cash Flow report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:00 +05:30
Nabin Hait
1a820abe3c
test: reuse BootStrapTestData master data in Accounts Receivable/Payable report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:08:53 +05:30
Mihir Kandoi
a972ef313a
Merge pull request #56127 from harisansari008/fix/qip-allow-rename-develop
...
fix: allow rename for Quality Inspection Parameter
2026-06-26 13:43:40 +05:30
Nabin Hait
245925815e
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:36:26 +05:30
Nabin Hait
51bd2727a0
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:28:23 +05:30
Nabin Hait
5a62746dd3
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:28:19 +05:30
Nabin Hait
9cad192ccb
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:28:15 +05:30
Nabin Hait
7f5f2ccfa3
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:28:05 +05:30
Nabin Hait
dc4f5ce0ab
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:56 +05:30
Nabin Hait
db76533c16
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:52 +05:30
Nabin Hait
182ef8a8e8
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:48 +05:30
Nabin Hait
3398e05190
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:39 +05:30
Nabin Hait
286ac77a05
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:35 +05:30
Nabin Hait
3b23e039e4
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:31 +05:30
Nabin Hait
0b35d394c5
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:22 +05:30
Nabin Hait
b11a2c3e9f
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:19 +05:30
Nabin Hait
67ac8f64e8
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:14 +05:30
Nabin Hait
9158d5f893
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:04 +05:30
Nabin Hait
2aff857561
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:00 +05:30
Nabin Hait
0e6f50ca24
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:28 +05:30
Nabin Hait
6ceddd7a83
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:24 +05:30
Nabin Hait
364250467f
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:19 +05:30
Nabin Hait
f2d64d1a2a
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:14 +05:30
Nabin Hait
293ca4e96f
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:08 +05:30
Mihir Kandoi
05e44ca63a
Merge pull request #56546 from mihir-kandoi/pg-rawsql-to-orm
...
refactor: convert convertible raw frappe.db.sql to ORM
2026-06-26 12:21:25 +05:30
Mihir Kandoi
0583349ae4
test: convert aggregate/pluck/positional raw SQL to ORM
...
A deeper re-audit (with an adversarial skeptic) of the queries left raw
in the prior commit found more that have exact ORM equivalents:
- scalar SUM/MAX -> frappe.qb + Sum/Max .run()[0][0]
- SUM ... GROUP BY -> frappe.qb .groupby().select(Sum().as_()) run(as_dict)
- name IN (values) -> get_all(filters={'f': ['in', ...]})
- sql_list(select col) -> get_all(pluck='col')
- bulk UPDATE ... = NULL/value -> frappe.db.set_value(filters, field, val)
- positional as_list reads -> get_all(..., as_list=True) (+ sorted())
Note: get_value(dt, filters, 'sum(x)') and get_all(fields=['sum(x)'])
are rejected by frappe ('SQL functions are not allowed as strings'), so
aggregates go through frappe.qb. get_all(as_list=True) returns a tuple
(not a list), so consumers that mutate use sorted().
All affected test modules pass on MariaDB.
2026-06-26 11:34:31 +05:30
Mihir Kandoi
0776f7f7fa
test: convert trivially-equivalent raw SQL to ORM helpers
...
Convert test-only raw frappe.db.sql calls that have an exact ORM
equivalent: full-table/filtered deletes -> frappe.db.delete, count ->
frappe.db.count, row-existence assertions -> frappe.db.exists,
single-row scalar fetches -> frappe.db.get_value, and simple
equality/range-filter selects -> frappe.get_all. No behaviour change.
Raw SQL that genuinely needs it is left as-is (dynamic identifiers,
aggregates/group-by, positional as_list consumers, DB-catalog
introspection).
2026-06-26 10:44:17 +05:30
Mihir Kandoi
0e54e532ff
refactor(accounts): use frappe.get_all for trial balance account fetch
...
The Account metadata fetch in the DuckDB trial-balance path is a plain
static SELECT (fixed columns, single company filter, order by lft).
Convert it to frappe.get_all. Verified on Postgres: identical 98 rows,
same order and same dict payload as the raw query.
2026-06-26 10:44:05 +05:30
Nabin Hait
de45ab7fc9
test: add coverage for Incorrect Stock Value Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:40:32 +05:30
Nabin Hait
6e23e49f23
test: add coverage for Landed Cost Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:40:16 +05:30
Nabin Hait
6595a32d90
test: add coverage for COGS By Item Group report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:40:07 +05:30
Nabin Hait
5ad8ea3f17
test: add coverage for Item Where Used report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:39:59 +05:30
Nabin Hait
2092909f21
test: add coverage for Serial No and Batch Traceability report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:39:51 +05:30
Nabin Hait
b537e8b183
test: add coverage for Delayed Order Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:33:20 +05:30
Nabin Hait
ce5239132c
test: add coverage for Delayed Item Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:33:12 +05:30
Nabin Hait
8bef2b13a1
test: add coverage for Batch Item Expiry Status report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:33:05 +05:30