Akhil Narang
b087fb3d54
fix(treewide): manual ruff fixes
...
(cherry picked from commit f63396ef47 )
(cherry picked from commit 7828eee014 )
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-04-10 17:13:31 +05:30
Akhil Narang
4d34b1ead7
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-04-10 17:13:31 +05:30
Ankush Menat
4c629d31c6
style: format js files
2024-03-11 11:03:58 +05:30
Nihantra C. Patel
3c170b9805
fix: translatable columns in Sales Pipeline Analytics report
...
(cherry picked from commit c5050c935b )
2024-02-22 14:54:51 +00:00
Raffael Meyer
2c52f2ce13
chore: resolve conflicts
2023-12-14 13:51:47 +01:00
barredterra
1469ca7d0b
feat: set lead name from email
...
(cherry picked from commit ceeb724acc )
# Conflicts:
# erpnext/crm/doctype/lead/lead.json
2023-12-14 12:49:40 +00:00
Shariq Ansari
12d3cda2d9
fix: get dynamic link with parenttype contact
...
(cherry picked from commit 3d7ad71b22 )
2023-12-04 13:51:13 +00:00
Shariq Ansari
bb2aa904b2
fix: create contact if existing customer doesn't have contact
...
(cherry picked from commit 23b0b8ba36 )
2023-11-28 14:19:59 +00:00
Raffael Meyer
1773e31499
feat: new Report "Lost Quotations" ( #38309 )
...
(cherry picked from commit 477d9fa87e )
2023-11-24 21:27:50 +00:00
mergify[bot]
d1a8202624
chore: refetch item images on transaction save (backport #38095 ) ( #38098 )
...
* chore: refetch item images on transaction save (#38095 )
chore: re fetch item images on transaction save
(cherry picked from commit e93a19ffb5 )
# Conflicts:
# erpnext/accounts/doctype/pos_invoice_item/pos_invoice_item.json
# erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
# erpnext/selling/doctype/quotation_item/quotation_item.json
* chore: fix conflict in pos_invoice_item.json
* chore: fix conflict in sales_invoice_item.json
* chore: fix conflict in quotation_item.json
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-11-14 20:11:23 +05:30
mergify[bot]
24852e46c1
chore: rewrite query using query builder (backport #37310 ) ( #37415 )
...
* chore: rewrite query using query builder
(cherry picked from commit 25718f5cc7 )
* chore: fix shopping cart tests
(cherry picked from commit fb51cae88b )
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-10-09 20:56:43 +05:30
ruthra kumar
c1d40a6bfa
fix: fetch company details for Lead based quotation
...
(cherry picked from commit f388864fd5 )
2023-10-05 08:21:26 +00:00
mergify[bot]
cf2a3e2fc5
Contact Doctype don't have any field job_title. ( #36156 )
...
fix: Contact Doctype doesn't have any field called `job_title`
fix: Contact Doctype doesn't have any field called `job_title`
(cherry picked from commit 49be740736 )
Co-authored-by: Sumit Jain <59503001+sumitjain236@users.noreply.github.com >
2023-08-04 17:52:29 +05:30
mergify[bot]
29e079d5d6
refactor: use delete_contact_and_address ( #34497 )
...
refactor: use delete_contact_and_address (#34497 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 0dde4d4c69 )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-06-08 19:59:22 +05:30
mergify[bot]
841d2e4b2c
refactor: Workspace cleanup (backport #35409 ) ( #35505 )
...
* refactor: Workspace cleanup
(cherry picked from commit 243c49c550 )
# Conflicts:
# erpnext/accounts/workspace/accounting/accounting.json
# erpnext/assets/workspace/assets/assets.json
* fix: Delete Retail and Utilities worspaces amd hide default Settings and Integration workspaces
(cherry picked from commit 0b28f641ad )
* fix: Added pos links in Selling workspace
(cherry picked from commit 86f88817a9 )
* fix: removed duplicate links of manufacturing workspace
(cherry picked from commit 5cf4c8c8b7 )
* fix: Rearranged accounting module links
(cherry picked from commit e78a7de1e5 )
# Conflicts:
# erpnext/accounts/workspace/accounting/accounting.json
* chore: typo
(cherry picked from commit bb67cc03df )
* chore: conflicts
---------
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-05-31 16:51:54 +05:30
Nabin Hait
82c3d862ce
Merge branch 'version-14-hotfix' into mergify/bp/version-14-hotfix/pr-34627
2023-05-03 11:21:48 +05:30
mergify[bot]
665021270f
fix: Use set instead of db_set as it is called from validate ( #34967 )
...
fix: Use set instead of db_set as it is called from validate (#34967 )
(cherry picked from commit 72b5c1f70a )
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2023-04-25 20:04:28 +05:30
Komal-Saraf0609
5e98679f91
fix: enabling lead even after "Opportunity" created against it ( #34627 )
...
* fix: enabling lead even after "Opportunity" created against it
* chore: Linting Issues
---------
Co-authored-by: Komal Saraf <komal@frappe.io >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit ad11934d39 )
# Conflicts:
# erpnext/patches.txt
# erpnext/patches/v14_0/enable_all_leads.py
2023-03-30 02:34:48 +00:00
mergify[bot]
3e67994cc7
fix: lost opportunity report issue ( #34626 )
...
fix: lost opportunity report issue (#34626 )
* fix: lost opportunity report issue
* chore: Linting Issues
---------
Co-authored-by: Komal Saraf <komal@frappe.io >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit d0660ad222 )
Co-authored-by: Komal-Saraf0609 <81952590+Komal-Saraf0609@users.noreply.github.com >
2023-03-29 17:04:00 +05:30
mergify[bot]
c64836d3d6
fix: Set contact filter link in Opportunity ( #34325 )
...
fix: Set contact filter link in Opportunity (#34325 )
Co-authored-by: Nihantra C. Patel <n.patel.serpentcs@gmail.com >
(cherry picked from commit 71de72bdd0 )
Co-authored-by: Solufyin <34390782+Solufyin@users.noreply.github.com >
2023-03-11 19:05:26 +05:30
Raffael Meyer
d117de7813
feat: translate fixtures during runtime, not installation ( #33996 )
...
feat: install untranslated fixtures from files
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 770369e5c1 )
2023-02-14 04:00:23 +00:00
mergify[bot]
44692e9b57
fix: Lead to customer creation ( #33859 )
...
fix: Lead to customer creation (#33859 )
(cherry picked from commit faecf3ee40 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-01-31 09:20:10 +05:30
mergify[bot]
0fcf364aaa
fix: double salutation on quotation print ( #33834 )
...
fix: double salutation on quotation print (#33834 )
'lead_name' always has salutation.
(cherry picked from commit f270880735 )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-01-29 17:08:30 +05:30
mergify[bot]
6ef7eaf82e
fix: remove unnecessary permissions from Appointment and Appointment Booking Settings ( #33358 ) ( #33395 )
2022-12-20 18:23:47 +05:30
ruthra kumar
3af2b9b423
fix: type error on Sales Pipeline Analytics
...
(cherry picked from commit 4856e750f9 )
2022-12-02 04:41:21 +00:00
mergify[bot]
0ba2a4d084
fix: opportunity list doesn't show assigned user (backport #33110 ) ( #33131 )
...
fix: opportunity list doesn't show assigned user (#33110 )
Because `db_update` is performed `_assign` property is not updated and
hence lead -> opportunity conversion makes it disappear from list view.
Steps to reproduce:
1. Create lead
2. Assign anyone
3. Create opportunity from lead.
4. Form view shows assigned user, list view wont.
(cherry picked from commit 63b9795d41 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-11-28 11:19:32 +05:30
mergify[bot]
f8b7cfa6dd
refactor: Remove usage of deprecated methods (backport #32914 ) ( #32915 )
...
* refactor: Remove usage of deprecated methods (#32914 )
Warn: Just used regex to replace all usage.
```regex
s/frappe.db.set(\(.*\),\(.*\),\(.*\))/\1.db_set(\2, \3)/g
```
Required after: https://github.com/frappe/frappe/pull/18815
(cherry picked from commit 7e1742956c )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/sales_invoice.py
* chore: conflicts
* style: black
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-11-10 11:09:13 +05:30
Nabin Hait
dac5989d72
fix: Renamed Dashboard tab label to Connections
...
(cherry picked from commit f561d8f689 )
2022-10-15 12:13:35 +00:00
Nabin Hait
9e94dd9203
fix: Renamed Notes section to Comments
...
(cherry picked from commit 56a4a77398 )
2022-10-15 12:13:35 +00:00
Ernesto Ruiz
a403e729d6
fix: typo on opportunity summary by sales stage report
...
(cherry picked from commit c4919cf5ec )
2022-09-26 11:08:18 +00:00
Sagar Vora
b7e8fbe43f
test: dont create lead manually, add coverage for notes
...
(cherry picked from commit 875ff15109 )
2022-09-05 06:56:48 +00:00
Sagar Vora
00a73c7a57
fix(Appointment): create lead notes as child table
...
(cherry picked from commit 58e553151e )
2022-09-05 06:56:47 +00:00
Nabin Hait
735a60807a
fix: limited options for no-of-employees in crm
...
(cherry picked from commit 7ecd67605f )
2022-08-09 15:18:25 +00:00
Nabin Hait
29b8715205
fix: mentions in notes, workspace links, no-of-employees field type and report fixes
2022-07-22 15:33:39 +05:30
Nabin Hait
925b9d985e
fix: open lead and opportunities based on today's event
2022-06-27 22:13:09 +05:30
Nabin Hait
7921a1a605
fix: Restored city, state and country fields
2022-06-27 22:13:09 +05:30
Nabin Hait
2d226be3c4
fix: Made no of employees a select field
2022-06-25 11:40:23 +05:30
Nabin Hait
6a0d0a338d
fix: Test cases removed related to copying comments from opportunity to quotation
2022-06-25 11:40:23 +05:30
Nabin Hait
82bf59e2a3
fix: test case
2022-06-25 11:40:23 +05:30
Nabin Hait
d8163f3e47
fix: set exchange rate
2022-06-25 11:40:23 +05:30
Nabin Hait
f904ac599e
fix: merge conflicts and sider issues
2022-06-25 11:40:23 +05:30
Conor
b8f728a40a
refactor: use CURRENT_DATE instead of CURDATE() ( #31356 )
...
* refactor: use CURRENT_DATE instead of CURDATE()
* style: reformat to black spec
* refactor: use QB for auto_close queries
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-06-15 12:07:33 +05:30
Wolfram Schmidt
c4a2778359
chore: added RFQ Link to Opportunity Dashboard ( #30894 )
...
added Link to Dashboard
added backlink to Request for Quotation in the Quotation dashboard for transparency and ease of navigation.
2022-05-13 12:01:52 +05:30
Rohit Waghchaure
3f41cb762d
fix: allow to use formatting for the field to_discuss in opportunity
2022-05-10 11:47:01 +05:30
Rushabh Mehta
548afba8bb
fix(minor): update frappe.error_log to new API ( #30864 )
...
* fix(minor): update frappe.error_log to new API
* refactor: changes for updated log_error api
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-05-02 15:04:26 +05:30
Ankush Menat
0fdfc1e76e
fix: only query fields that exist
2022-04-26 11:03:32 +05:30
Sagar Vora
fa4f57f470
fix: dont reassign mutable (list) to a different field
2022-04-07 16:51:27 +05:30
Ankush Menat
ba42c87687
refactor: don't use pandas for basic reports ( #30597 )
2022-04-06 15:40:41 +05:30
Ankush Menat
a896895a9e
fix: bulk fix (~330) missing translations
2022-04-04 13:59:51 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30