rohitwaghchaure
341a07dffa
fix: restrict state-changing whitelisted endpoints to POST ( #56858 )
...
Add methods=["POST"] to 50 whitelisted functions that create or modify
documents (get_doc followed by insert/save/submit), so they can no
longer be invoked via GET requests.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com >
2026-07-03 18:47:13 +05:30
Mihir Kandoi
a36065931d
fix(telephony): scope link_existing_conversations rollback to a savepoint (review)
...
link_existing_conversations is the Contact after_insert hook; a full frappe.db.rollback() on a failed call_log.save() would discard the triggering Contact insert itself (and, in test mode, the whole unit of work). Savepoint the hook's DB work and roll back only to it.
2026-06-30 12:17:39 +05:30
Mihir Kandoi
01811ccf85
fix(telephony): rollback before logging in call_log link_existing_conversations (Postgres)
...
The hook saves Call Logs in a loop; on failure the except calls frappe.log_error (INSERT) with no rollback, raising InFailedSqlTransaction on Postgres (it runs on every Contact create/update). Full frappe.db.rollback() before log_error. No-op on MariaDB.
2026-06-29 22:42:48 +05:30
Mihir Kandoi
928bbf22d2
refactor(postgres): port call_log link_existing_conversations to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-19 21:10:00 +05:30
ruthra kumar
ed76d6699a
refactor(test): move commits inside test guard clause
2026-03-24 11:57:02 +05:30
ruthra kumar
33f4791698
refactor: replace IntegrationTestCase with ERPNextTestCase repo-wide
...
- import ERPNextTestSuite
- use it on test class
2026-03-18 20:59:35 +05:30
diptanilsaha
decd9343ee
refactor(call_log): type annotations for whitelisted methods
2026-03-07 15:00:34 +05:30
ljain112
e8510287e3
chore: remove unused imports
2026-01-17 14:45:57 +05:30
Nishka Gosalia
41a7e64772
feat: Adding support for discarding document ( #51316 )
...
Co-authored-by: Nishka Gosalia <nishkagosalia@Nishkas-MacBook-Air.local >
2025-12-29 08:49:46 +00:00
Ankush Menat
7bddd64771
perf: Skip fetching non-existing call log ( #47930 )
2025-06-06 07:13:44 +00:00
HarryPaulo
87de5c7450
fix: prevent unnecessary db.commit for contact insert [Linters]
2025-01-16 17:51:22 -03:00
HarryPaulo
5f15b0b65b
fix: prevent unnecessary db.commit
2025-01-16 17:40:54 -03:00
David
58c49dc9d2
refactor: Use IntegrationTestCase in multiple files
...
Signed-off-by: David <dgx.arnold@gmail.com >
2024-10-08 02:13:00 +02:00
Akhil Narang
3effaf21ef
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-03-27 16:06:04 +05:30
Ankush Menat
dfde490c02
refactor!: switch to creation sort ( #40699 )
2024-03-27 13:45:34 +05:30
Ankush Menat
ec74a5e566
style: format js files
2024-03-10 19:45:40 +05:30
Ankush Menat
63313eef6f
feat: enable automatic type annotations ( #38452 )
2023-11-30 08:23:48 +00:00
Suraj Shetty
e0bc437ddb
refactor: Simplify call log code
2022-05-08 16:05:04 +05:30
Suraj Shetty
77599fe443
fix: Set correct options for link field
...
issue introduced via https://github.com/frappe/erpnext/pull/30711
2022-04-14 12:32:31 +05:30
Suraj Shetty
c272170b86
fix(call log): Convert Data to Link for type_of_call
...
Convert `Data` to `Link` for type_of_call,
employee_user_id and call_received_by fields
2022-04-14 09:51:54 +05:30
Suraj Shetty
ff41b8da4e
fix: Update received_by if "to" is changed
2022-04-13 20:12:08 +05:30
Suraj Shetty
cfee53eb55
fix: Handle exception where no employee is returned
2022-04-04 07:38:15 +05:30
Suraj Shetty
39abfae5fe
chore: Remove unused code
...
- and simplify get_call_log
2022-04-04 07:28:41 +05:30
Subin Tom
e57e7bb02c
fix: added tests(fixed)
2022-04-02 17:16:56 +05:30
Ankush Menat
7ef54809be
Merge branch 'develop' into exotel-fixes
2022-03-28 19:55:39 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Subin Tom
b19305aa83
fix: used get_employees_with_number, strip_number methods
2022-03-22 16:22:09 +05:30
Subin Tom
1ab5b7a811
fix: linter, sider fixes
2022-02-28 12:47:05 +05:30
Subin Tom
5b79496f05
fix: call type doctype, fixes
2022-02-25 16:52:25 +05:30
Subin Tom
00b0f10100
fix: added type of call select field, additional status for agent rejecting call
2022-02-25 13:38:57 +05:30
Subin Tom
fd20713bd7
fix: added field to show called group, user_id
2022-02-25 12:01:53 +05:30
Subin Tom
006606c437
fix: added employee name to call log
2022-02-23 18:45:50 +05:30
Ankush Menat
6098e92ba9
chore: remove utf-8 compat code
2021-11-05 11:16:29 +05:30
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
4551d7d602
chore: mass trailing whitespace and EOF fixes
2021-08-19 13:43:28 +05:30
Dany Robert
ba288274f2
fix: ignore permission to update call log
2021-06-19 12:31:12 +05:30
Suraj Shetty
ba26020a82
fix: Show audio interface in call log which has recording URL
...
- Also, remove unneccesary column & section break in call log doctype
2021-02-08 18:45:55 +05:30
Suraj Shetty
723e6dd73f
fix: Update style of call log shown in timeline
2021-02-08 18:43:26 +05:30
leela
3234df5581
feat: improved call log doctype
...
* Added links and some more fields into Call Log Doctype
* Display call info in the call log link pages
2021-01-28 18:34:58 +05:30
Leela vadlamudi
29778e2fba
feat: Voice Call Settings doctype added ( #24126 )
2020-12-15 21:23:17 +05:30
Leela vadlamudi
a3845a95ed
feat: Introducing telephony module ( #24032 )
2020-12-01 13:04:53 +05:30
