- Multiple Item Variants creation fails due to extra spaces in attributes from popup. Clean them before passing to server side
- Mention explicit method to build variants cache to avoid ambiguity between old method path (pre-refactor)
(cherry picked from commit a64228741d)
(cherry picked from commit ca8986028d)
- If the number of variants are large (almost 2lakhs), the query to get variants and attribute data takes time
- If the no.of disabled attributes is large as well, the list comprehension weeding out disabled variants takes forever
- We dont need to loop over the variants data so many times
- Avoid any `if a in list(b)` is best when the iterables have tremendous data
(cherry picked from commit 26bd3053d1)
(cherry picked from commit 251656ab52)
- Multiple Item Variants creation fails due to extra spaces in attributes from popup. Clean them before passing to server side
- Mention explicit method to build variants cache to avoid ambiguity between old method path (pre-refactor)
(cherry picked from commit a64228741d)
- If the number of variants are large (almost 2lakhs), the query to get variants and attribute data takes time
- If the no.of disabled attributes is large as well, the list comprehension weeding out disabled variants takes forever
- We dont need to loop over the variants data so many times
- Avoid any `if a in list(b)` is best when the iterables have tremendous data
(cherry picked from commit 26bd3053d1)
This causes other triggers and unnecessary changes (e.g. price list)
(cherry picked from commit f89a64db48)
Co-authored-by: Ankush Menat <ankush@frappe.io>
This causes other triggers and unnecessary changes (e.g. price list)
(cherry picked from commit f89a64db48)
Co-authored-by: Ankush Menat <ankush@frappe.io>
- Back to back stock recos cause incorrect qty calculation across warehouses
- Hard to differentiate how much of the qty is reset by the reco
- Maintain Queue and balances warehouse wise and later aggregate for accurate values
(cherry picked from commit f62b3207ff)
- Two tests to check impact on pending qty: From SO and independent Prod Plan
- Added docstring to each test case for brief summary
- Changed helper function args to fallback to 0 instead of 1 if no arg is passed
- Removed unnecessary `get_doc()`
- Made helper function actions optional depending on args passed
(cherry picked from commit 86ca41b14a)
- Rows that are not fetched from MR or SO, had pending qty 0 throughout
- Initialise pending qty on save only.
- After submit this field will be updated by work order/stock entry
- Bring functions in `validate()` closer to the top
(cherry picked from commit eaccef6116)
* Revert "Merge pull request #29290 from s-aga-r/fix/delivery-note/billed-amount"
This reverts commit 038f949550, reversing
changes made to c7b4918434.
* fix: linter
