Commit Graph

59 Commits

Author SHA1 Message Date
Mihir Kandoi
a3e3e1b32c ci: optimize install helper setup
Cc: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 16:50:50 +05:30
Diptanil Saha
3b44419a7f ci: configure upstream fetch refspec so git fetch creates tracking refs (#55422)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 16:16:43 +00:00
Diptanil Saha
1ae46b54b2 ci: split sync into orchestrator + per-branch runners, generalise for any app (#55414)
* ci: re-fetch before push to avoid force-push on translations_hotfix

If upstream/translations_hotfix moved forward while the script was
running (e.g., a concurrent run or manual push), git push would fail
with "behind remote". Re-fetch right before pushing and merge any new
remote commits with -X ours so our .po changes and the main.pot from
${HOTFIX_BRANCH} (set by the initial -X theirs merge) are preserved
without needing a force-push.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: define HOTFIX_BRANCH once as job env; pass it to sync script

version-16-hotfix is now declared as env.HOTFIX_BRANCH at the job level
so the checkout ref and the script argument both derive from the same
value. Quoting the GITHUB_WORKSPACE path guards against spaces on
self-hosted runners.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: define HOTFIX_BRANCH as job env and pass to sync script via env

Declares version-16-hotfix once as env.HOTFIX_BRANCH at the job level
so the checkout ref and the script both derive from the same value.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: read HOTFIX_BRANCH from env instead of hardcoding in script

Removes the hardcoded branch name from the script; reads it from the
HOTFIX_BRANCH env var set by the workflow. Fails immediately with a
clear message if the var is not set.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: use ls-remote to check branch existence instead of swallowing fetch errors

Replace `git fetch ... 2>/dev/null || true` + `git rev-parse --verify`
with `git ls-remote --exit-code --heads upstream translations_hotfix`.
ls-remote queries the remote directly so the check is never based on
stale local state, and real failures (auth, network) propagate through
set -e instead of being silently ignored. Applied to both the initial
branch setup and the pre-push re-fetch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: rewrite orchestrator to dispatch runner per hotfix branch via matrix

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: add per-branch runner workflow for hotfix translation sync

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: generalise sync script to use APP_NAME and GITHUB_REPOSITORY

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: remove push trigger from runner workflow

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: rename working branch to sync_translations_{hotfix_branch}

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 20:13:45 +05:30
Diptanil Saha
621c1c595a ci: fix branch base and per-language commits in sync-hotfix-translations (#55405)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:48:03 +05:30
Diptanil Saha
7561ad4666 ci: sync translations from develop to version-16-hotfix (#55348)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-27 20:50:03 +05:30
Faris Ansari
495bf4b765 chore: set correct payments app branch 2025-06-21 16:50:59 +05:30
Sagar Vora
25623325ce ci: use mysqlclient in tests 2025-03-15 09:48:40 +05:30
Nabin Hait
febdf4c61e fix: added docs.frappe.io in documentation_url (#44776) 2024-12-18 11:58:22 +00:00
ruthra kumar
eb1e36ca22 fix: broken CI
- always install wkhtmltopdf
- remove specific version on mariadb-client
2024-12-16 16:27:13 +05:30
David
2f747a274f ci: trigger ci runs from upstream fix 2024-10-24 14:26:55 +02:00
barredterra
89c458e229 chore: set PR reviewer for translations 2024-07-24 09:59:46 +02:00
barredterra
1f74439b16 ci: explicitly stage pot file
Avoid accidentally adding any other changed files, like yarn.lock, to the commit.
2024-06-27 19:43:46 +02:00
Akhil Narang
3effaf21ef refactor(treewide): formatting and ruff fixes, + manually enabled F401
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-27 16:06:04 +05:30
Raffael Meyer
f44a841af7 ci: auto-generate potfile (#40288) 2024-03-05 18:06:31 +05:30
Akhil Narang
4a6108e912 fix: use mariadb instead of mysql
Drop mysql-client in favour of mariadb-client

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-11 11:17:47 +05:30
Ankush Menat
2f7b3bbfad ci: fix patch test (#37079)
* ci: fix patch test

* ci: use v13 DB as starting point for patch

* ci: remove payments from patch test

* ci: print bench logs after tests

* ci: restart bench on each update

* ci: patch test v13db > v14 > develop

and when v15 is out v13db > v14 > v15 > develop
2023-09-14 14:46:45 +05:30
mergify[bot]
bd2dd7dfac ci: use version specific payments repo (backport #34468) (#34470)
ci: use version specific payments repo (#34468)

ci: use version-14 branch of payments repo for v14 erpnext
(cherry picked from commit befd1a0f91)

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2023-03-16 16:20:21 +05:30
Raffael Meyer
d155042edd ci: documentation helper (#33757)
refactor: documentation helper
2023-01-24 11:42:44 +05:30
Ankush Menat
64f7f3a12a chore: ignore b028
Very high false positive count. 

[skip ci]
2023-01-17 10:56:55 +05:30
Raffael Meyer
a4cb0313dd chore: test with wkhtmltopdf 12.6 (#33554)
* chore: test with latest wkhtmltopdf

* chore: check ubuntu version

* ci: check exit code of wk install

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-09 14:27:34 +05:30
Ankush Menat
0b86b1baca refactor: make payments app a soft dependency (#33245)
refactor: make payment app a soft dependency
2022-12-08 16:40:13 +05:30
Ankush Menat
d23b5d8f2f ci: use mariadb 10.6 (#33220)
https://github.com/frappe/frappe/pull/19116

[skip ci]
2022-12-06 12:58:07 +05:30
Suraj Shetty
273c6ff598 Merge pull request #31690 from phot0n/fix-payments-stuff 2022-07-27 14:37:15 +05:30
phot0n
76493e928f ci: update install script and patch workflow to accomodate payments app 2022-07-27 12:21:48 +05:30
Gavin D'souza
b07dd1083a ci: Check for conflicts & valid python in early separate step 2022-07-25 11:54:49 +05:30
Ankush Menat
42761a315a chore: ignore late binding warnings
Most are false positives

[skip ci]
2022-07-04 13:19:18 +05:30
Ankush Menat
c7efa3b44d ci: stale apt cache (#31217) 2022-06-02 12:27:11 +05:30
Ankush Menat
3ae9fa98c4 ci: failfast when merge conflict exists (#30823)
[skip ci]
2022-04-27 14:33:26 +05:30
Ankush Menat
229db14b7e ci: move some tasks to background
- wkhtml download
- asset building
2022-02-17 16:16:53 +05:30
Ankush Menat
6f2c9c692c ci: workflow dispatch options (#29611) 2022-02-03 17:30:42 +05:30
Conor
d2074b16db ci: postgres unittests configurations (#28952)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-01-02 23:33:10 +05:30
Ankush Menat
cc1baae5eb ci: move semgrep rules out of repo (#28067)
Moving semgrep rules out of repos as it's unnecessary to maintain
same ruleset for different repos and different branches.
2021-10-22 21:43:50 +05:30
Ankush Menat
92c0dcc3ea ci: install dev requirements in CI 2021-10-20 19:09:57 +05:30
gavin
9916b87767 ci: Rule Added for using frappe.qb over db.sql* (#28000)
ERPNext port of https://github.com/frappe/frappe/pull/14481


Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: abhishek <as7122000@gmail.com>
2021-10-19 14:20:09 +05:30
Ankush Menat
06b426e9c3 ci: rule to fail PRs that add a new manual commit (#27928)
Manual commits are frequent source of bugs, confusions or undefined
behaviour.

All new manual commits should be explcitly ignored with explanation on
why it's added. This will only fail for new additions. Existing ones
need to be cleaned up manually.
2021-10-12 23:01:37 +05:30
ChillarAnand
4dc17a856e fix(CI): Use bugbear instead of flake8-mutable 2021-10-11 11:17:55 +05:30
Chillar Anand
772d4753e7 refactor: Clean up mutable defaults and add CI check (#27828)
* refactor: Clean up mutable defaults and add CI check
2021-10-06 16:58:48 +00:00
Dany Robert
fa819f2fb0 fix: General Ledger translation issues (#27298)
* fix: remove translations from GL report options

Options need not be translated, their display label gets translated
client side.

* fix: make group by options translatable

* ci: semgrep rule for translated options in report

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-09-08 16:28:05 +05:30
Ankush Menat
5596988c94 ci: fix docs checker for wiki based docs (#27380) 2021-09-07 14:53:30 +05:30
Chillar Anand
915b34391c chore: Clean up imports (#27302)
* chore: Added isort to pre-commit config

* chore: Sort imports with isort

* chore: Clean up imports with pycln

* chore: Sort imports with isort

* chore: Fix import issues

* chore: Clean up sider issues

* chore: Remove import errors from flake8 ignore list

* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
65279c2471 ci: add strict config for flake8 2021-09-01 16:57:21 +05:30
Alan
72ece75b11 ci(semgrep): add translation checks for report labels (#27280)
* ci(semgrep): add translation checks for report labels

* refactor: shift report tests to it's own yml

path can't be applied on a test id basis

* ci: ignore regional report in translation checks

[skip ci]
2021-09-01 14:19:39 +05:30
Ankush Menat
e5e00700e5 ci: use node action instead of apt (#27220) 2021-08-30 12:07:11 +05:30
Ankush Menat
8bbec42fa0 fix: undo changes to patch (#26983)
* fix: undo changes to patch

* ci: ignore empty body / head
2021-08-17 15:14:13 +05:30
Ankush Menat
2a43fe1a22 ci: ignore backports while checking docs (#26962)
[skip ci]
2021-08-16 18:03:21 +05:30
Ankush Menat
28d52c4a95 chore: remove warning rules
semgrep-action doesn't consider severity, hence ignoring these rules for now.
2021-07-21 19:54:06 +05:30
Ankush
1b5f3cf605 ci: make semgrep ignore existing errors (#26516) 2021-07-15 19:30:05 +05:30
Ankush Menat
203c2b2292 ci: show bench logs if ui test fails 2021-07-12 10:09:50 +05:30
Suraj Shetty
e8e4841e5e ci: Build frappe assets
- Build frappe assets since it is used for print views
2021-06-17 20:23:18 +05:30
Ankush Menat
073dcf7e42 ci(semgrep): fix false positives (#25823) 2021-05-25 14:06:10 +05:30