Khushi Rawat
1121c6663f
fix: link Purchase Invoice and Receipt Items to Asset
2024-09-05 14:31:05 +05:30
Khushi Rawat
88e5ed7998
chore: test case failing issue
...
(cherry picked from commit 0bdffdfa98 )
2024-09-02 22:09:22 +00:00
Khushi Rawat
f3c60ea0a7
fix(capitalization): debit cwip account instead of fixed asset account ( #42857 )
...
* fix(capitalization): debit cwip account instead of fixed asset account
* fix: post entries for capitalized asset through background jobs
* chore: run pre-commit
* fix: correct GL entries posting for composite assets
* fix(minor): resolve failing check
* chore: update gl entry check logic
* chore: handle none values
(cherry picked from commit 5d99f17583 )
2024-08-29 11:01:03 +00:00
Khushi Rawat
a833010d2b
fix: don't allow capitalizing only service item for new composite asset
...
(cherry picked from commit f1d2138258 )
2024-08-28 20:43:15 +00:00
Khushi Rawat
fa85482662
fix: calculation correction for annual depreciation
...
(cherry picked from commit f440243b75 )
2024-08-22 05:48:09 +00:00
Khushi Rawat
1040198ce1
perf: asset creation from purchase receipt
...
(cherry picked from commit 6e84fc5143 )
2024-08-20 08:12:48 +00:00
barredterra
4914481105
fix: translatability of boldened text
...
(cherry picked from commit af0ae930ca )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2024-08-17 00:21:05 +00:00
Khushi Rawat
ecf0d0b388
chore: linters check
...
(cherry picked from commit 0d42793397 )
2024-08-14 09:07:38 +00:00
Khushi Rawat
b84ca04975
fix: removed extra filter condition
...
(cherry picked from commit 6fa29376a0 )
2024-08-14 09:07:38 +00:00
Khushi Rawat
abb88662c1
fix: set up filters for dimensions
...
(cherry picked from commit 2fd8de2f76 )
2024-08-14 09:07:37 +00:00
Khushi Rawat
d890d02b5c
test: new depreciation after cancelling asset repair
...
(cherry picked from commit 88a5824e31 )
2024-08-13 19:01:02 +00:00
Khushi Rawat
defd5541b0
fix: resolved conflict
...
(cherry picked from commit c085b6159b )
2024-08-13 19:01:01 +00:00
Khushi Rawat
765c1104c4
fix: fetch months last date to avoid miscalculation
...
(cherry picked from commit 70ff4e7644 )
2024-08-13 08:42:33 +00:00
Khushi Rawat
a429f2f626
fix: cancel Journal Entry on cancellation of asset value adjustment
...
(cherry picked from commit 4b7f1f2d67 )
2024-08-12 20:43:30 +00:00
Khushi Rawat
2d644ac066
fix: disable primary action button only when there are no active capitalization
...
(cherry picked from commit bb877f4a6b )
2024-08-06 13:43:27 +00:00
mergify[bot]
2de86eb0f4
fix: use get_last_day to get the correct date (backport #42564 ) ( #42598 )
...
fix: use get_last_day to get the correct date (#42564 )
(cherry picked from commit 5d58eb67a6 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-08-02 17:10:37 +05:30
Khushi Rawat
1390c86fc4
fix(tests): added tests for usecase
...
(cherry picked from commit f0768010d9 )
2024-07-30 13:35:18 +00:00
Khushi Rawat
9d2ef4d3e8
fix: Adjust initial month's depreciation to end of depreciation period
...
(cherry picked from commit cbb749a3a5 )
2024-07-30 13:35:17 +00:00
Khushi Rawat
ffacf4222b
fix: correct validation for depreciation posting date
...
(cherry picked from commit da4ed90a3e )
2024-07-23 09:54:44 +00:00
Khushi Rawat
29fc975fb8
fix: set filter to show only submitted asset
...
(cherry picked from commit 69b8e10e20 )
2024-07-19 13:47:45 +00:00
Khushi Rawat
cfab956811
chore: resolved conflicts
2024-07-16 22:46:54 +05:30
Khushi Rawat
2ffe7d5838
fix: service item capitalization ( #42188 )
...
* feat: capitalize with service expenses only
* chore: added test
* refactor: removed Capitalized In field from asset doc
(cherry picked from commit 81e0b96c30 )
# Conflicts:
# erpnext/assets/doctype/asset/asset.py
2024-07-16 12:16:47 +00:00
Khushi Rawat
ddd1ca7f7c
feat: configurable depreciation calculation via accounts settings ( #42276 )
...
* feat: configurable depreciation calculation via accounts settings
* refactor: code optimization
* style: changes in description and label
(cherry picked from commit b04da63aad )
2024-07-12 08:57:11 +00:00
Khushi Rawat
19ed6d1081
fix: added filter to show only submitted assets
...
(cherry picked from commit cd3a900495 )
2024-07-09 11:12:01 +00:00
Khushi Rawat
317cc0358c
fix: add auto-update for overdue status ( #42105 )
...
* fix: auto-update for overdue status
* chore: use qb.update
(cherry picked from commit c5e474f4f5 )
2024-07-01 11:27:02 +00:00
mergify[bot]
97c49b93b6
fix: refactor Asset Repair and Stock Entry linkage to resolve amendme… (backport #41919 ) ( #42058 )
...
* fix: refactor Asset Repair and Stock Entry linkage to resolve amendme… (#41919 )
* fix: refactor Asset Repair and Stock Entry linkage to resolve amendment issues
* chore: added missing patch to patches.txt
* chore: fixing previous changes
* chore: fixing minor issues
* fix: code changes to enhance efficiency
* chore: replaced frappe.qb with db.sql because of conflict
* fix: minor changes
(cherry picked from commit ba79e68190 )
# Conflicts:
# erpnext/assets/doctype/asset_repair/asset_repair.json
# erpnext/assets/doctype/asset_repair_consumed_item/asset_repair_consumed_item.json
# erpnext/patches.txt
# erpnext/stock/doctype/stock_entry/stock_entry.json
* chore: fixed conflicts
* fix: removed unmerged patches
* fix: use f-string instead of format call
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-07-01 16:53:29 +05:30
mergify[bot]
482832f3c2
fix: unhide serial no field (backport #42045 ) ( #42047 )
...
* fix: unhide serial no field (#42045 )
(cherry picked from commit 80c6981cfa )
# Conflicts:
# erpnext/assets/doctype/asset_capitalization_stock_item/asset_capitalization_stock_item.json
* fix: resolved conflicts
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 18:01:33 +05:30
mergify[bot]
cf4d4ba3e9
fix: incorrect time period in asset depreciation schedule (backport #41805 ) ( #42043 )
...
fix: incorrect time period in asset depreciation schedule (#41805 )
* fix(wip): depreciation calculation for existing asset
* fix(wip): added validation for incorrect depreciation period
* fix: depreciation schedule time period issue for existing asset
* chore: run pre-commit checks and apply fixes
* style: apply formatting changes
* style: made some necessary changes
* chore: modified test
(cherry picked from commit 625f16dee0 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 16:51:16 +05:30
mergify[bot]
f2feeaf264
fix: fixed asset value in Fixed Asset Register (backport #41930 ) ( #42027 )
...
fix: fixed asset value in Fixed Asset Register (#41930 )
(cherry picked from commit 1c643a0ead )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 16:49:55 +05:30
Khushi Rawat
ca343f12d8
refactor: renamed number of depreciations booked to opening booked de… ( #41515 )
...
* refactor: renamed number of depreciations booked to opening booked depreciations
* feat: introduced new field for showing total number of booked depreciations
2024-06-21 19:53:46 +05:30
mergify[bot]
03bf48032e
fix: Copy depreciation schedule on asset split only if it exists (backport #41775 ) ( #41784 )
...
fix: Copy depreciation schedule on asset split only if it exists (#41775 )
(cherry picked from commit 689e1cfc23 )
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2024-06-04 22:25:40 +05:30
mergify[bot]
a67fa6863e
fix(minor): corrected wrong filter condition (backport #41755 ) ( #41762 )
...
* fix(minor): corrected wrong filter condition (#41755 )
(cherry picked from commit 60eb03a6c6 )
# Conflicts:
# erpnext/assets/report/fixed_asset_register/fixed_asset_register.py
* fix: resolved conflict
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2024-06-04 21:53:28 +05:30
mergify[bot]
97b1b7f842
fix: filtered out data having none values in date field (backport #41457 ) ( #41765 )
...
* fix: filtered out data having none values in date field
(cherry picked from commit 3bd455ac85 )
* style: code optimization
(cherry picked from commit a36b7fb95a )
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-04 12:21:16 +05:30
mergify[bot]
89ba7a22fb
fix: added validation message for low gross purchase amount (backport #41502 ) ( #41553 )
...
fix: added validation message for low gross purchase amount
(cherry picked from commit 8a30701893 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-05-20 18:36:26 +05:30
Nabin Hait
2569b244e2
Merge pull request #41473 from frappe/mergify/bp/version-15-hotfix/pr-41235
...
Depreciation based on daily prorata (backport #41235 )
2024-05-15 09:10:56 +05:30
Nabin Hait
fd3efd53be
style: linter issue
2024-05-15 09:09:16 +05:30
Nabin Hait
6d43d840db
style: new line before function
...
(cherry picked from commit 7d86881579 )
2024-05-15 03:11:37 +00:00
Khushi Rawat
955ce9b670
fix: removed same named function
...
(cherry picked from commit d22df324ec )
2024-05-15 03:11:37 +00:00
Khushi Rawat
b57919e2ce
refactor: code optimization
...
(cherry picked from commit 7b264e5e11 )
2024-05-15 03:11:37 +00:00
Khushi Rawat
72f3fb2a2c
fix: pro rata based depreciation with opening accumulated depreciation
...
(cherry picked from commit c0c8c1bb02 )
2024-05-15 03:11:37 +00:00
Khushi Rawat
12f383f252
test: made minor change in existing test
...
(cherry picked from commit d40b55468c )
2024-05-15 03:11:37 +00:00
Khushi Rawat
01b25b5821
fix: incorrect total days calculation
...
(cherry picked from commit fccd37d32d )
2024-05-15 03:11:36 +00:00
Khushi Rawat
c335c2c85a
fix: daily prorata based depreciation bug in wdv method
...
(cherry picked from commit b8a98a273b )
2024-05-15 03:11:36 +00:00
Khushi Rawat
1016ec2a14
fix(wip): daily depreciation bug
...
(cherry picked from commit f337392f3e )
2024-05-15 03:11:36 +00:00
Nabin Hait
230cff583f
Merge pull request #41461 from frappe/mergify/bp/version-15-hotfix/pr-41089
...
Refactor: Rename purchase receipt amount field to purchase amount (backport #41089 )
2024-05-14 19:58:15 +05:30
Nabin Hait
3a72f4bd30
fix: resolved conflict
2024-05-14 19:34:29 +05:30
Nabin Hait
8cca74d5ef
fix: resolved conflict
2024-05-14 19:29:23 +05:30
Khushi Rawat
ce2c6c3165
fix(minor): removed extra parameter
...
(cherry picked from commit 98e7dfe97f )
2024-05-14 13:56:25 +00:00
Khushi Rawat
0b21026eef
refactor: removed code duplicacies
...
(cherry picked from commit 6b24143f72 )
2024-05-14 13:56:25 +00:00
Khushi Rawat
3eff9c9779
fix(wip): depreciation calculation after asset value adjustment
...
(cherry picked from commit d3200fb67f )
2024-05-14 13:56:24 +00:00