using mutable python defaults, and especially function calls, inside
function definitions causes bugs that can be really hard to debug
sometimes. please refrain from using such defaults.
instead, using None is almost always a sane default. the values can
then be manipulated inside the function instead.
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
(cherry picked from commit 0d147b011e)
using mutable python defaults, and especially function calls, inside
function definitions causes bugs that can be really hard to debug
sometimes. please refrain from using such defaults.
instead, using None is almost always a sane default. the values can
then be manipulated inside the function instead.
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Changed error message if expense account not set for item in Delivery Note.
Earlier: Expense or Difference account is mandatory for Item IT - 6 as it impacts overall stock value
After fix: Expense Account not set for Item IT - 6. Please set an Expense Account for the item in the Items table
* fix: set customer and supplier details using sql
instead of slowing down the query with get_doc and save()
we can just use sql to update the required values for
customer and supplier
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
* chore: remove extra quote
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
* fix: update sql query to include tabPrice List
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
Changed error message if expense account not set for item in Delivery Note.
Earlier: Expense or Difference account is mandatory for Item IT - 6 as it impacts overall stock value
After fix: Expense Account not set for Item IT - 6. Please set an Expense Account for the item in the Items table
* fix: set customer and supplier details using sql
instead of slowing down the query with get_doc and save()
we can just use sql to update the required values for
customer and supplier
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
* chore: remove extra quote
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
* fix: update sql query to include tabPrice List
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
