Vimal
0aabe4fd1e
fix: change shipping address fetching condition
...
(cherry picked from commit 0b4add2f2b )
2025-05-06 05:29:00 +00:00
marination
f94a14c06a
fix: Headline rendered twice on first save
...
- `refresh` gets triggered twice and that renders the note twice
- Remove any existing note before rendering
(cherry picked from commit bf62f9ad57 )
2025-05-05 16:59:18 +00:00
marination
d9636018f5
fix: Treat rows as Unit Price rows only until the qty is 0
...
- The unit price check should depend on the row qty being 0
- Once the row ceases to be 0, it is treated as an ordinary row
- test: PO, SO and Quotation
(cherry picked from commit 0447c7be0a )
# Conflicts:
# erpnext/selling/doctype/quotation/test_quotation.py
# erpnext/selling/doctype/sales_order/test_sales_order.py
2025-05-05 16:59:17 +00:00
marination
2d96a62530
test: Sales Order + fix: Mapping of Items from Quotation & SO
...
(cherry picked from commit 55981c8358 )
# Conflicts:
# erpnext/selling/doctype/sales_order/test_sales_order.py
2025-05-05 16:59:17 +00:00
marination
eba73df88e
test: Purchase Order with Unit Price Items
...
- chore: Fix error message in accounts controller
(cherry picked from commit eea758f5b2 )
# Conflicts:
# erpnext/buying/doctype/purchase_order/test_purchase_order.py
# erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py
2025-05-05 16:59:16 +00:00
marination
c19065e675
test: Zero Qty in RFQ and Supplier Quotation
...
(cherry picked from commit 8f96c0b546 )
# Conflicts:
# erpnext/buying/doctype/request_for_quotation/test_request_for_quotation.py
# erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py
2025-05-05 16:59:16 +00:00
marination
f8fa775af3
feat: Unit Price Items in Buying (RFQ, SQ, PO)
...
- chore: Extract `set_unit_price_items_note` into a util
(cherry picked from commit e403d3f153 )
# Conflicts:
# erpnext/buying/doctype/buying_settings/buying_settings.json
# erpnext/buying/doctype/purchase_order/purchase_order.json
# erpnext/buying/doctype/request_for_quotation/request_for_quotation.json
# erpnext/selling/doctype/quotation/quotation.json
# erpnext/selling/doctype/selling_settings/selling_settings.json
2025-05-05 16:59:16 +00:00
marination
91e167fe72
fix: Linters
...
(cherry picked from commit 71f65bab5e )
# Conflicts:
# erpnext/selling/doctype/sales_order/sales_order.py
2025-05-05 16:59:15 +00:00
marination
33366fce6c
feat: Unit Price Contract
...
(cherry picked from commit c1e4e7af28 )
# Conflicts:
# erpnext/controllers/accounts_controller.py
# erpnext/selling/doctype/quotation/quotation.json
# erpnext/selling/doctype/sales_order/sales_order.py
# erpnext/selling/doctype/selling_settings/selling_settings.json
2025-05-05 16:59:15 +00:00
mergify[bot]
8d1e855dc8
fix: rename unchanged group_by filter related to general ledger report (backport #47366 ) ( #47405 )
...
fix: rename unchanged group_by filter related to general ledger report (#47366 )
(cherry picked from commit 3de249dcba )
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2025-05-05 18:01:51 +05:30
mergify[bot]
0e5c709f7b
fix: backward compatibility for renamed group_by filter on reports (backport #47362 ) ( #47403 )
...
fix: backward compatibility for renamed group_by filter on reports (#47362 )
* fix: backward compatibility for renamed group_by filter in general ledger report
* fix: backward compatibility for renamed group_by filter in supplier quotation comparison report
(cherry picked from commit d4ffa54136 )
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2025-05-05 18:01:29 +05:30
mergify[bot]
21612fc230
fix: 'time to resolve: failed' on issue (backport #47406 ) ( #47407 )
...
fix: 'time to resolve: failed' on issue (#47406 )
* fix: 'time to resolve: failed' on issue
* fix: sla_resolution_date
(cherry picked from commit 45393d51a2 )
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2025-05-05 17:50:36 +05:30
mergify[bot]
afb44a677c
fix: update accounts on change of mode of payment in sales invoice payment (backport #47381 ) ( #47400 )
...
* fix: update accounts on change of mode of payment in sales invoice payment (#47381 )
* fix: update accounts on change of mode of payment in sales invoice payment
* test: fixed tests
(cherry picked from commit 8067799692 )
# Conflicts:
# erpnext/accounts/doctype/mode_of_payment/test_mode_of_payment.py
# erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
* chore: resolve conflict
* chore: remove unused library
* chore: resolve conflict
* chore: resolve conflict
* chore: resolve linter issue
---------
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2025-05-05 16:35:31 +05:30
ruthra kumar
4f6aee3f22
Merge pull request #47399 from frappe/mergify/bp/version-15-hotfix/pr-47145
...
refactor: make AR / AP report more memory efficient (backport #47145 )
2025-05-05 16:03:36 +05:30
ruthra kumar
fc1b1ca5e2
chore: resolve conflict
2025-05-05 15:47:39 +05:30
ruthra kumar
f69b8d7e2d
refactor: set default for fetch methods
...
(cherry picked from commit ca1e81e1b5 )
2025-05-05 10:14:49 +00:00
ruthra kumar
2147441e64
refactor: use fetch method based on configuration
...
(cherry picked from commit b5bb6f3508 )
2025-05-05 10:14:49 +00:00
ruthra kumar
5e5cf68b32
refactor: configurable fetch method for AR / AP report
...
(cherry picked from commit 66fd639b52 )
# Conflicts:
# erpnext/accounts/doctype/accounts_settings/accounts_settings.json
2025-05-05 10:14:49 +00:00
ruthra kumar
7c8245d299
refactor: use unbuffered cursor for fetching
...
(cherry picked from commit 08903459c2 )
2025-05-05 10:14:48 +00:00
rohitwaghchaure
a4c9707fdf
Merge pull request #47390 from frappe/mergify/bp/version-15-hotfix/pr-47376
...
fix: validation for difference account (backport #47376 )
2025-05-05 14:11:07 +05:30
Rohit Waghchaure
f4a43d07b0
fix: validation for difference account
...
(cherry picked from commit fb819c558e )
2025-05-03 07:52:58 +00:00
Frappe PR Bot
c1ed750bcb
chore(release): Bumped to Version 15.60.1
...
## [15.60.1](https://github.com/frappe/erpnext/compare/v15.60.0...v15.60.1 ) (2025-05-02)
### Bug Fixes
* not able to submit the stock entry ([#47383 ](https://github.com/frappe/erpnext/issues/47383 )) ([73a418a ](73a418a2bd ))
v15.60.1
2025-05-02 13:44:13 +00:00
rohitwaghchaure
1d139eb94a
Merge pull request #47384 from frappe/mergify/bp/version-15/pr-47383
...
fix: not able to submit the stock entry (backport #47383 )
2025-05-02 19:12:43 +05:30
rohitwaghchaure
73a418a2bd
fix: not able to submit the stock entry ( #47383 )
...
(cherry picked from commit 035394ae6a )
2025-05-02 13:06:32 +00:00
rohitwaghchaure
035394ae6a
fix: not able to submit the stock entry ( #47383 )
2025-05-02 18:34:47 +05:30
mergify[bot]
1ef7da837f
fix: completed transactions showing in the list (backport #47374 ) ( #47379 )
...
fix: completed transactions showing in the list (#47374 )
(cherry picked from commit 97db9da10e )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2025-05-02 15:28:45 +05:30
mergify[bot]
85a8adf804
fix: renaming group by fieldname and value in reports (backport #47352 ) ( #47360 )
...
* fix: renaming group by fieldname and value in reports (#47352 )
* fix: renaming in general ledger report
* fix: renaming in supplier quotation comparison report
* fix: renaming group by to categorize by in process statement of accounts
* fix: added patch
* fix: patch update to all documents
* chore: added patches to patch.txt
* chore: removing patch from v14
(cherry picked from commit 13a84e7f82 )
# Conflicts:
# erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json
* chore: resolve conflict
---------
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2025-04-30 17:19:43 +05:30
Mihir Kandoi
d3445b3079
Merge pull request #47357 from frappe/mergify/bp/version-15-hotfix/pr-47336
...
refactor: portal query in timesheet.py (backport #47336 )
2025-04-30 16:35:11 +05:30
Mihir Kandoi
ada7821a49
refactor: portal query in timesheet.py ( #47336 )
...
* refactor: portal query in timesheet.py
* fix: use criterion.any to fix query
(cherry picked from commit 4fc7a8b71d )
2025-04-30 10:45:02 +00:00
Nihantra C. Patel
3f7dcedf3d
Merge pull request #47354 from frappe/mergify/bp/version-15-hotfix/pr-47351
...
fix: party name in Ledger Summary (backport #47351 )
2025-04-30 14:05:47 +05:30
Nihantra Patel
4fc14b3097
fix: party name in Ledger Summary
...
(cherry picked from commit 70bc86a4c6 )
2025-04-30 08:13:52 +00:00
mergify[bot]
4ef2b77973
fix: warning message before changing the valuation method (backport #47340 ) ( #47342 )
...
fix: warning message before changing the valuation method (#47340 )
(cherry picked from commit ffdc4347e8 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2025-04-30 08:45:39 +05:30
Frappe PR Bot
96996bd8a9
chore(release): Bumped to Version 15.60.0
...
# [15.60.0](https://github.com/frappe/erpnext/compare/v15.59.0...v15.60.0 ) (2025-04-29)
### Bug Fixes
* add transaction_date in field_no_map when creating PO from SQ (backport [#47257 ](https://github.com/frappe/erpnext/issues/47257 )) ([#47313 ](https://github.com/frappe/erpnext/issues/47313 )) ([afb67f1 ](afb67f1f0c ))
* allow selling asset at zero rate (backport [#47326 ](https://github.com/frappe/erpnext/issues/47326 )) ([#47332 ](https://github.com/frappe/erpnext/issues/47332 )) ([171b687 ](171b687611 ))
* allow to change valuation method from FIFO to Moving Average ([b2294ed ](b2294ed6e3 ))
* allow to make quality inspection after Purchase / Delivery ([e0cea49 ](e0cea49236 ))
* cancel pos closing entry failure for return pos invoices (backport [#47248 ](https://github.com/frappe/erpnext/issues/47248 )) ([#47249 ](https://github.com/frappe/erpnext/issues/47249 )) ([10d843e ](10d843e490 ))
* commas in rfq portal js ([954fec1 ](954fec16f4 ))
* compare total debit/credit with precision for Inter Company Journal Entry ([0927155 ](0927155171 ))
* consolidating pos invoices on the basis of accounting dimensions (backport [#46961 ](https://github.com/frappe/erpnext/issues/46961 )) ([#47265 ](https://github.com/frappe/erpnext/issues/47265 )) ([f8da159 ](f8da1599bb ))
* correct query for dispatch_address; remove unnecessary code; increase reusability; ([ac3b2ba ](ac3b2ba003 ))
* do not check for permission if values are not changed in employee doctype ([#47238 ](https://github.com/frappe/erpnext/issues/47238 )) ([0caba9f ](0caba9f70d ))
* enable use serial / batch fields on batch selection ([925cc40 ](925cc40efa ))
* enhance dispatch address query logic and add supplier address query ([290f0b9 ](290f0b94e5 ))
* fix sub assembly qty calculation in production plan when bom level >= 1 (backport [#47296 ](https://github.com/frappe/erpnext/issues/47296 )) ([#47315 ](https://github.com/frappe/erpnext/issues/47315 )) ([d15b7ca ](d15b7ca9af ))
* make asset quantity and amount editable (backport [#47226 ](https://github.com/frappe/erpnext/issues/47226 )) ([#47227 ](https://github.com/frappe/erpnext/issues/47227 )) ([c140fd0 ](c140fd0f12 ))
* map dispatch address correctly for inter company transactions ([d8c0e71 ](d8c0e7156e ))
* missing else statement ([8a30a31 ](8a30a31302 ))
* **payment request:** get advance amount based on transaction currency ([c2235e2 ](c2235e2d17 ))
* **PE:** Set account types in get_payment_entry (backport [#47246 ](https://github.com/frappe/erpnext/issues/47246 )) ([#47266 ](https://github.com/frappe/erpnext/issues/47266 )) ([3e733f6 ](3e733f6ba1 ))
* prevent cancellation of last asset movement (backport [#47291 ](https://github.com/frappe/erpnext/issues/47291 )) ([#47312 ](https://github.com/frappe/erpnext/issues/47312 )) ([2edd12b ](2edd12b26d ))
* price currency in supplier quotation comparison ([6b1b30a ](6b1b30a4a6 ))
* prohibit consolidated sales invoice return (backport [#47251 ](https://github.com/frappe/erpnext/issues/47251 )) ([#47252 ](https://github.com/frappe/erpnext/issues/47252 )) ([4bcea55 ](4bcea55563 ))
* QI reference not set if 'Action If Quality Inspection Is Not Sub… (backport [#47294 ](https://github.com/frappe/erpnext/issues/47294 )) ([#47295 ](https://github.com/frappe/erpnext/issues/47295 )) ([b0399fe ](b0399fe948 ))
* Re-insert missing "Serial No Warranty Expiry" Report ([727c32d ](727c32d789 ))
* remove invalid email account creation (backport [#47318 ](https://github.com/frappe/erpnext/issues/47318 )) ([#47323 ](https://github.com/frappe/erpnext/issues/47323 )) ([fc8a8b5 ](fc8a8b5433 ))
* remove use of cur_frm ([5c300b8 ](5c300b893b ))
* **Rename Tool:** allow more than 500 rows (backport [#47117 ](https://github.com/frappe/erpnext/issues/47117 )) ([#47225 ](https://github.com/frappe/erpnext/issues/47225 )) ([c0ae133 ](c0ae1336f4 ))
* require email OR phone in shipment doctype not both (backport [#47300 ](https://github.com/frappe/erpnext/issues/47300 )) ([#47330 ](https://github.com/frappe/erpnext/issues/47330 )) ([0056fb1 ](0056fb1d0f ))
* set billing hours to hours ([0763a8d ](0763a8d42d ))
* set billing hours to hours in timesheet (backport [#47289 ](https://github.com/frappe/erpnext/issues/47289 )) ([#47290 ](https://github.com/frappe/erpnext/issues/47290 )) ([74bdc82 ](74bdc82bfa ))
* update additional cost and total asset cost after asset repair (backport [#47233 ](https://github.com/frappe/erpnext/issues/47233 )) ([#47235 ](https://github.com/frappe/erpnext/issues/47235 )) ([4a29a54 ](4a29a54804 ))
* update billing hours when hours is changed ([a9df1f5 ](a9df1f5f6b ))
* update quantity validation using asset quantity field instead of… (backport [#46731 ](https://github.com/frappe/erpnext/issues/46731 )) ([#47284 ](https://github.com/frappe/erpnext/issues/47284 )) ([2e6112f ](2e6112f21b ))
* validate if from and to time are present on submission of job card ([#47325 ](https://github.com/frappe/erpnext/issues/47325 )) ([d640c79 ](d640c79c1c ))
* validation if no stock ledger entries against stock reco (backport [#47292 ](https://github.com/frappe/erpnext/issues/47292 )) ([#47293 ](https://github.com/frappe/erpnext/issues/47293 )) ([91bcefe ](91bcefef8c ))
### Features
* add dispatch address fields to purchase doctypes ([5f101e7 ](5f101e7635 ))
* add dispatch address support in party details and controllers ([1fe1563 ](1fe1563dab ))
* add display dispatch address when dispatch address is selected ([93ea2f9 ](93ea2f93b6 ))
* change sabb qty automatically incase of internal transfer PR if sabb only has 1 batch ([#47256 ](https://github.com/frappe/erpnext/issues/47256 )) ([9495a2a ](9495a2ac9d ))
v15.60.0
2025-04-29 13:12:18 +00:00
ruthra kumar
a9e40bc0d8
Merge pull request #47328 from frappe/version-15-hotfix
...
chore: release v15
2025-04-29 18:40:46 +05:30
mergify[bot]
d15b7ca9af
fix: fix sub assembly qty calculation in production plan when bom level >= 1 (backport #47296 ) ( #47315 )
...
* fix: fix sub assembly qty calculation in production plan when bom level >= 1
(cherry picked from commit bfc4ce1d5d )
* fix: logical error
(cherry picked from commit ee10afc074 )
---------
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com >
2025-04-29 18:12:36 +05:30
mergify[bot]
171b687611
fix: allow selling asset at zero rate (backport #47326 ) ( #47332 )
...
fix: allow selling asset at zero rate (#47326 )
(cherry picked from commit 05afad78fc )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2025-04-29 17:12:51 +05:30
ruthra kumar
cc8418b7e4
Merge pull request #47329 from frappe/mergify/bp/version-15-hotfix/pr-47325
...
fix: validate if from and to time are present on submission of job card (backport #47325 )
2025-04-29 16:46:34 +05:30
mergify[bot]
0056fb1d0f
fix: require email OR phone in shipment doctype not both (backport #47300 ) ( #47330 )
...
fix: require email OR phone in shipment doctype not both (#47300 )
(cherry picked from commit fc02a6510e )
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com >
2025-04-29 16:27:56 +05:30
Mihir Kandoi
d640c79c1c
fix: validate if from and to time are present on submission of job card ( #47325 )
...
(cherry picked from commit 7499c25a3c )
2025-04-29 10:52:56 +00:00
mergify[bot]
2edd12b26d
fix: prevent cancellation of last asset movement (backport #47291 ) ( #47312 )
...
fix: prevent cancellation of last asset movement (#47291 )
* fix: prevent cancellation of last asset movement
* test: movement cancellation
* fix: allow cancellation of asset movement when cancelling asset
(cherry picked from commit 9dee4ac891 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2025-04-29 12:51:18 +05:30
ruthra kumar
71482261c7
Merge pull request #47324 from frappe/mergify/bp/version-15-hotfix/pr-47241
...
fix: compare total debit/credit with precision for Inter Company Journal Entry (backport #47241 )
2025-04-29 12:43:42 +05:30
Mihir Kandoi
9df5727ea4
Merge pull request #47317 from frappe/mergify/bp/version-15-hotfix/pr-47256
...
feat: change sabb qty automatically incase of internal transfer PR if… (backport #47256 )
2025-04-29 12:40:53 +05:30
mergify[bot]
fc8a8b5433
fix: remove invalid email account creation (backport #47318 ) ( #47323 )
...
fix: remove invalid email account creation (#47318 )
(cherry picked from commit 7423e4187f )
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2025-04-29 12:40:45 +05:30
Mihir Kandoi
409831183b
Merge pull request #47314 from frappe/mergify/bp/version-15-hotfix/pr-47234
...
fix: price currency in supplier quotation comparison (backport #47234 )
2025-04-29 12:40:31 +05:30
mergify[bot]
afb67f1f0c
fix: add transaction_date in field_no_map when creating PO from SQ (backport #47257 ) ( #47313 )
...
* fix: add transaction_date in field_no_map when creating PO from SQ
(cherry picked from commit 3790c6c551 )
* fix: test case
(cherry picked from commit acd1529780 )
# Conflicts:
# erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py
* fix: remove unused import
(cherry picked from commit 9e640341fd )
# Conflicts:
# erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py
* chore: fix conflicts
* chore: remove unused imports
---------
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com >
2025-04-29 12:40:10 +05:30
ruthra kumar
7bc39349b0
Merge pull request #47321 from frappe/mergify/bp/version-15-hotfix/pr-47231
...
fix(payment request): get advance amount based on transaction currency (backport #47231 )
2025-04-29 12:25:54 +05:30
ljain112
0927155171
fix: compare total debit/credit with precision for Inter Company Journal Entry
...
(cherry picked from commit 5fe247557e )
2025-04-29 06:48:08 +00:00
venkat102
c2235e2d17
fix(payment request): get advance amount based on transaction currency
...
(cherry picked from commit b570d97b4d )
2025-04-29 06:37:54 +00:00
Mihir Kandoi
9495a2ac9d
feat: change sabb qty automatically incase of internal transfer PR if sabb only has 1 batch ( #47256 )
...
* feat: change sabb qty automatically incase of internal transfer PR if sabb only has 1 batch
* fix: prevent creation of SABB on every save
* perf: optimize code
* fix: remove unnecessary conditon
* refactor: change if to elif
* fix: remove dn_item_qty and set to item.qty
* test: added test
(cherry picked from commit 47927b38a9 )
2025-04-29 06:17:04 +00:00
Mihir Kandoi
cb61e0bd18
Merge pull request #47316 from frappe/mergify/bp/version-15-hotfix/pr-47302
...
fix: commas in rfq portal js (backport #47302 )
2025-04-29 11:46:31 +05:30