Fawaz Alhafiz
0ec30a1cea
fix: SQL operator precedence in Project query customer filter
...
Added explicit parentheses around customer OR conditions in get_project_name()
to ensure proper grouping with AND filters. Without these parentheses, SQL
operator precedence caused the status filter to be bypassed when a customer
filter was applied, resulting in completed and cancelled projects appearing
in link field dropdowns.
Before:
WHERE customer='X' OR customer IS NULL OR customer='' AND status NOT IN (...)
was interpreted as:
WHERE customer='X' OR customer IS NULL OR (customer='' AND status NOT IN (...))
After:
WHERE (customer='X' OR customer IS NULL OR customer='') AND status NOT IN (...)
Fixes: Completed/cancelled projects showing in Project link fields
Affected: Any doctype using Project link fields with customer filters
2025-10-02 14:24:51 +03:00
diptanilsaha
1db135262d
fix: use query builder instead of raw SQL in get_blanket_orders
2025-08-16 23:07:12 +05:30
diptanilsaha
6320f7290f
fix: formatted string for disabled filter in get_income_account
2025-08-16 23:07:11 +05:30
mithili
7c8dd86a35
fix: add condition to fetch active accounts
2025-08-07 11:10:43 +05:30
mithili
c3111db6e2
fix(purchase invoice): filter only enabled account
2025-08-07 11:10:42 +05:30
Thomas antony
de56faf862
chore: add missing key value
2025-07-12 10:18:34 +05:30
Thomas antony
75a00928b5
chore: included value in "key" for search condition
2025-07-12 09:48:08 +05:30
thomasantony12
09541c52e1
fix: employee search based on the fields mentioned in the doctype searchfields
2025-07-06 11:22:24 +05:30
Rohit Waghchaure
338256b799
fix: batch page length
2025-06-11 16:52:58 +05:30
Ankush Menat
765c7c2bcc
refactor: rename get_settings -> get_single_value ( #47961 )
2025-06-09 04:40:02 +00:00
Ankush Menat
ea5c2c454b
perf: use cached stock settings ( #47945 )
2025-06-06 18:54:49 +05:30
Ankush Menat
958cc6f8f8
perf: use estimated count on item table
2025-06-05 22:31:36 +05:30
ruthra kumar
7e0681c4a4
Merge pull request #46717 from ljain112/fix-search
...
fix: respect field "ignore_user_permissions" property in employee query
2025-04-22 15:41:34 +05:30
ljain112
4be975f87c
chore: added test case for employee query with user permissions
2025-04-22 13:00:37 +05:30
Rohit Waghchaure
3745825052
fix: disbaled UOM showing in the list
2025-04-21 21:24:58 +05:30
ljain112
91d7bc55be
fix: respect field "ignore_user_permissions" property in employee query
2025-04-21 14:21:56 +05:30
Rohit Waghchaure
b1dfbbe85e
feat: allow UOMs to select for which converstion rate defined in item master
2025-03-31 15:53:55 +05:30
Ninad Parikh
d01367eefe
fix: base_net_rate Required to Check Valid Range ( #46332 )
...
fix: base_net_rate required to check valid range
2025-03-06 17:34:25 +05:30
Bhavan23
4dd37ba033
fix: filter the item tax template using the input text
2025-01-29 22:19:30 +05:30
venkat102
b92f8bc514
fix: include company in filter condition
2024-12-30 14:18:55 +05:30
David Arnold
9673bf85ec
refactor: pass typed arguments to get_item_details methods ( #44230 )
...
* refactor: pass proper types to get_item_details methods
* chore: excempt previous commit from git blame
2024-11-20 02:31:03 +01:00
rohitwaghchaure
8805e74784
fix: not able to reconcile expired batches ( #44012 )
2024-11-12 15:48:28 +05:30
rohitwaghchaure
c13a147df1
fix: disabled batches showing in the list ( #43024 )
2024-09-05 15:39:15 +05:30
Rohit Waghchaure
eb426c69fe
fix: batch qty in the dropdown field
2024-06-12 12:12:58 +05:30
rohitwaghchaure
968120d0eb
fix: batch selection issue ( #41692 )
2024-05-30 18:06:29 +05:30
Akhil Narang
3effaf21ef
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-03-27 16:06:04 +05:30
Rohit Waghchaure
662cf21afb
fix: existing batch from different warehouse not showing in the dropdown
2024-03-26 14:31:18 +05:30
Deepesh Garg
2fadfd7cfc
Merge pull request #40428 from deepeshgarg007/search_field_fix
...
chore: Remove custom party queries
2024-03-16 20:03:31 +05:30
Deepesh Garg
60ba25caf2
fix: Remove custom queries for customer
2024-03-16 19:47:39 +05:30
Deepesh Garg
c9623b6fd6
chore: Remove custom party queries
2024-03-13 11:59:43 +05:30
Rucha Mahabal
daf4ae2a6b
fix: conditionally apply is_group filter in accounting dimension query ( #40414 )
2024-03-12 14:46:59 +00:00
Deepesh Garg
4c6d28a299
Merge pull request #40323 from deepeshgarg007/project_sales_filter
...
fix: Filter for projects in Sales Cycle
2024-03-10 19:25:48 +05:30
Deepesh Garg
d0e0b66b2f
fix: Filter for projects in Sales Cycle
2024-03-07 09:14:56 +05:30
rohitwaghchaure
cef6291311
fix: use serial batch fields for subcontracting receipt ( #40311 )
2024-03-06 19:43:36 +05:30
s-aga-r
ee14faaa39
fix: show warehouse title field in sales docs
2024-02-05 22:08:59 +05:30
ruthra kumar
bfe42fdccb
refactor: better ordering of query result
2024-01-16 15:58:19 +05:30
ruthra kumar
3349dde5e2
fix(test): test case for project query
2024-01-16 14:28:09 +05:30
ruthra kumar
4eefb445a7
fix: project query controller logic
2024-01-16 13:38:53 +05:30
Rohit Waghchaure
114f2b4326
fix: batches not coming correctly in the batch selector
2024-01-14 23:27:29 +05:30
s-aga-r
d0ed8ef83b
Merge pull request #38558 from s-aga-r/ADD-ITEMS-STOCK-RESERVATION-DIALOG
...
feat: provision to add items in Stock Reservation dialog
2023-12-22 12:15:07 +05:30
barredterra
eb9ee3f79b
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:22:55 +01:00
s-aga-r
00261094c8
fix(ux): show row index and field label while selecting the Sales Order Item
2023-12-04 18:00:06 +05:30
ruthra kumar
6e3e094c95
refactor: ignore disabled account while selecting Income Accounts
2023-11-09 09:39:39 +05:30
ruthra kumar
662ccd467c
fix: allocation logic on 'Get Outstanding Invoices' btn in PE
...
1. fixed broken `payment_term` filter in Payment References section
2. Throw error if user fails to select 'Payment Term' for an invoice
with 'Payment Term based allocation' enabled.
2023-07-23 11:37:27 +05:30
mergify[bot]
b4db5e9561
fix: validate docs in closed accounting period on save ( #36157 )
...
fix: validate docs in closed accounting period on save (#36157 )
(cherry picked from commit 5985e02574anandbaburajan@gmail.com >
2023-07-18 17:40:49 +05:30
Rohit Waghchaure
acd12c5830
fix: get_query for batch number and incorrect batch qty
2023-06-04 16:09:01 +05:30
HarryPaulo
e12e3bb012
fix: allow search leads by doctype search fields
...
* fix: allow search leads by doctype search fields
* fix: allow search leads by doctype search fields, linters fix
2023-05-14 08:08:47 +05:30
Ankush Menat
6de71eb158
fix: pass reference_doctype in link queries ( #35038 )
2023-04-25 18:33:31 +05:30
Rohit Waghchaure
b0fc568c80
fix: not able to select customer / supplier
2022-11-03 11:24:58 +05:30
Rohit Waghchaure
5f84993bae
test: added test case to validate seachfields for customer, supplier
2022-10-24 16:10:47 +05:30
