Commit Graph

1813 Commits

Author SHA1 Message Date
mergify[bot]
623d32597d fix: misleading "Set Default X" fields after saving (#28798) (#28809)
* fix: misleading "Set Default X" fields after saving

* refactor: remove unncessary code and minor formatting

* fix: extend to more doctypes and correct fieldnames

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 6485ac4e59)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
2021-12-09 17:21:12 +05:30
Deepesh Garg
b09274bd49 Merge pull request #28641 from frappe/mergify/bp/version-13-hotfix/pr-28302
fix: Shipping Rule picking up old net_rate (backport #28302)
2021-12-03 15:20:09 +05:30
mergify[bot]
99dfa91f81 feat: Grant commission on certain items only (#28645)
Co-authored-by: Sagar Vora <sagar@resilient.tech>
(cherry picked from commit e10ab1626c)
2021-12-03 15:17:45 +05:30
Deepesh Garg
08b7c856b2 fix: Unable to search project by project name in Sales Invoice (#28648) 2021-11-30 18:36:56 +05:30
Subin Tom
9e1fd09a64 fix: fixed tests, separated a method for shipping charges
(cherry picked from commit a8e2c02e14)
2021-11-30 09:08:16 +00:00
Subin Tom
d2d8986553 fix: check if shipping rule value exists
(cherry picked from commit af1fce0419)
2021-11-30 09:08:16 +00:00
Subin Tom
e6d0103cf3 fix: calling shipping rule method during net_total calculation in taxes_adn_totals.py
(cherry picked from commit 18ae03d967)
2021-11-30 09:08:15 +00:00
mergify[bot]
3621ee234e fix(ux): allow translations (#28455) (#28590)
* Translation

* Translations

(cherry picked from commit cdaf0a04cf)

Co-authored-by: xdlumertz <alexandrelumertz@gmail.com>
2021-11-27 15:11:25 +00:00
Deepesh Garg
03449a09ce fix: Incorrect indentation
(cherry picked from commit 7f06c8ca57)
2021-11-26 08:59:30 +00:00
Deepesh Garg
125ce5dd6d fix: Add tests
(cherry picked from commit f07f010962)
2021-11-26 08:59:30 +00:00
Deepesh Garg
31f95bd5d1 fix(refactor): Advance tds allocation to purchase invoice
(cherry picked from commit 5ba3b28d69)
2021-11-26 08:59:30 +00:00
Deepesh Garg
e2956922dc fix: GL Entries on advance TDS allocation
(cherry picked from commit 25d208aa8a)
2021-11-26 08:59:29 +00:00
mergify[bot]
b9218b3c60 fix: over billing validation (#28573) 2021-11-26 12:46:49 +05:30
Ankush Menat
12e1d169d0 Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-28124 2021-11-25 17:48:37 +05:30
Ankush Menat
fbfaf75b66 chore: remove __future__ py2 compatibility imports 2021-11-25 17:42:24 +05:30
Ankush Menat
ccb8defc0b fix: ignore permissions while creating reposts
(cherry picked from commit 0a2964dc82)
2021-11-25 16:43:13 +05:30
Ankush Menat
7ae5bc8911 feat: option to select reposting method
In current implementation selecting Item-Warehouse based reposting is
better for few users, who don't use depenent SLEs but have frequent
transactions involving same items.

This change lets them switch to item-warehouse based reposting if
required.

Only use this if you understand technicalities of stock reposting. This
is experimental but will become mainstream in coming days.

(cherry picked from commit 45dd46be3d)
2021-11-25 11:08:10 +00:00
Ankush Menat
db22859b54 refactor: reuse get_items_to_be_repost function
(cherry picked from commit d220e08ba4)
2021-11-25 11:08:09 +00:00
Ankush Menat
876c85fbf7 test: item-wh repost creation
(cherry picked from commit a36c249d3d)
2021-11-25 11:08:09 +00:00
Ankush Menat
0032ee46be refactor: item-wh wise reposting by default
(cherry picked from commit 6dc9b822bc)
2021-11-25 11:08:08 +00:00
Ankush Menat
636a6fcae0 fix: ignore permissions while creating repost
If user reached this code then they already have permission to create
stock transaction, hence ignore permission checks while
creating/cancelling repost item valuation entries.

(cherry picked from commit aa024fc9da)
2021-11-22 13:08:21 +05:30
marination
7bc705fb3c fix: Sider, Linter and Server Side Test
- Fix Server side PR test
- linter: re-arrange imports
- sider: avoid single line multi statement
- Code cleanup: Improve code readability and avoid horizontal scroll in test_purchase_receipt
- Removed unused variables in test_purchase_receipt

(cherry picked from commit 293f6cbafd)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
2021-11-16 12:43:33 +00:00
marination
149da71f6d test: Purchase Receipt Received Qty
(cherry picked from commit 05ec7cce82)
2021-11-16 12:43:31 +00:00
marination
852b2e3af8 fix: Sider + Fields UX
- remove extra space (sider)
- PR: Bring rejected qty in grid view
- PI: Rename `Stock Qty` to `Accepted Qty in Stock UOM`
- PI: Move `Accepted Qty in Stock UOM` under Stock UOM

(cherry picked from commit afe1c45f7f)
2021-11-16 12:43:30 +00:00
marination
4441f4d93a refactor: (ux) Accepted/Rejected/Received Qty UX
(cherry picked from commit 5fb5a757cf)

# Conflicts:
#	erpnext/public/js/controllers/buying.js
2021-11-16 12:43:29 +00:00
Deepesh Garg
a9452f1277 fix: Default party account getting overriden in invoices
(cherry picked from commit 88648570d7)
2021-11-12 07:34:40 +00:00
mergify[bot]
178a883ecc fix: show full item name in search widget (#28283) (#28284)
(cherry picked from commit 34f5283c17)

Co-authored-by: Ankush Menat <ankush@frappe.io>
2021-11-09 12:15:09 +05:30
Rohit Waghchaure
f88c24155c fix: COGS account in purchase receipt
(cherry picked from commit 2a14f255cf)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
2021-11-01 07:25:46 +00:00
mergify[bot]
f16e0e17cc fix: POS consolidated invoice rounded total issue (#28146) 2021-10-29 18:05:49 +05:30
Deepesh Garg
7cbf577f1f fix: Accounting Dimension filters not honouring user permissions
(cherry picked from commit aa9e78bed1)
2021-10-29 09:10:50 +00:00
Deepesh Garg
a60ecb95b0 fix: Ignore PO on So cancel
(cherry picked from commit 051aaa708d)
2021-10-29 06:28:28 +00:00
GangaManoj
ed58f206fa fix: Remove unused imports
(cherry picked from commit d24cfff388)
2021-10-29 06:28:27 +00:00
GangaManoj
d47007adb2 fix: Remove print statements
(cherry picked from commit 8844fdbf23)
2021-10-29 06:28:26 +00:00
GangaManoj
7c42b8b702 fix: Unlink PO on cancelling SO
(cherry picked from commit e77534fe13)
2021-10-29 06:28:25 +00:00
GangaManoj
2fb18afea0 fix: Unlink PO on cancelling SO
(cherry picked from commit 8396f24e70)
2021-10-29 06:28:24 +00:00
Ankush Menat
aa210ba6c8 fix: don't show blocked supplier in autocomplete
(cherry picked from commit 2221c9ed89)
2021-10-27 19:49:00 +05:30
mergify[bot]
fb742476f8 fix: Payment Terms validation precision (#28104)
(cherry picked from commit 9c1705205f)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
2021-10-27 13:26:57 +05:30
mergify[bot]
019c5a338d fix(ux): overbiling message in SO->SI, PO->PI (bp #28088)
(cherry picked from commit 6ec047cba9)

Co-authored-by: Ankush Menat <ankush@frappe.io>
2021-10-27 11:08:23 +05:30
mergify[bot]
34e92ab229 fix: incorrect status being set in Invoices (backport #28019) (#28031)
* fix: incorrect status being set in Invoices (#28019)

Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
(cherry picked from commit 8d9d0987fe)

# Conflicts:
#	erpnext/patches.txt

* fix: merge conflict

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2021-10-20 19:31:47 +05:30
Marica
db9f56bee8 fix: Use strip instead of lstrip and rstrip
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
(cherry picked from commit 8cf188d9c0)
2021-10-14 14:48:24 +00:00
marination
2e9d08f8b1 fix: Retain space inside Serial no string while cleaning serial nos
(cherry picked from commit 41035b0330)
2021-10-14 14:48:24 +00:00
Deepesh Garg
10b239ec50 perf: Add indexes in stock queries and speed up bin updation #27758
perf: Add indexes in stock queries and speed up bin updation
(cherry picked from commit 6f107da165)
2021-10-12 14:46:26 +00:00
Ankush Menat
2cfafede44 fix(ux): use toast instead of popup 2021-10-05 14:27:09 +05:30
Ankush Menat
df1f8fddf6 fix: using DN for transfer w/o internal customer (#27798)
This used to be work before though not "advertised", since a lot of
users have started using it as feature, it can't be broken now.
2021-10-05 14:21:27 +05:30
Saqib Ansari
2108bf9f73 fix: cost center in exchange gain loss gl entry
(cherry picked from commit 78ad50efc2)
2021-09-27 07:36:14 +00:00
Saqib Ansari
af531372da fix: setting of gain/loss if party account is in company currency
(cherry picked from commit 64efe8bf15)
2021-09-27 07:36:13 +00:00
Frappe PR Bot
e5a062ceb6 feat: add Partly Paid status in Invoices (#27636)
(cherry picked from commit c8b9a55e96)

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2021-09-22 12:17:58 +05:30
mergify[bot]
10cffe81b0 fix: Webform Permission for custom doctype (backport #26232) (#27592)
* fix: Webform Permission for custom doctype (#26232)

* fix: Webform Permission for custom doctype

* fix: sider fix

* fix: app check condition for getting correct list_context

* chore: Better naming convention

* test: Added test case to check permission for webform of custom doctype

* chore: linting issue

* chore: linting issue

* fix: sider fix

* test: minor changes

* chore: linter and better naming method

* chore: linter fix

(cherry picked from commit 9aa6f52edd)

# Conflicts:
#	erpnext/hooks.py

* chore: Resolved Conflicts

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2021-09-20 20:28:29 +05:30
Ankush Menat
684ca451d3 fix(ux): better error message
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
(cherry picked from commit 21a955d20b)
2021-09-20 12:13:37 +00:00
Ankush Menat
8cdd6eacdd refactor: add guard clause in for loop
Reduce overly indented code/improve readability.

(cherry picked from commit 5e4fbba753)
2021-09-20 12:13:37 +00:00