Rohit Waghchaure
85796b3534
fix: validation for zero qty in SABB
...
(cherry picked from commit 497f560b4b )
2024-04-19 09:41:27 +00:00
Nabin Hait
5ba9fbcbdb
Merge pull request #40953 from frappe/mergify/bp/version-15-hotfix/pr-40916
...
fix: check if there is any existing depreciation schedule (backport #40916 )
2024-04-11 11:32:44 +05:30
Nabin Hait
dcb7e27a5e
fix: check if there is any existing depreciation schedule
...
(cherry picked from commit 433c8c450c )
2024-04-11 05:24:08 +00:00
mergify[bot]
0ec1f01b00
Merge branch 'version-15-hotfix' into mergify/bp/version-15-hotfix/pr-40584
2024-04-10 15:57:49 +00:00
Akhil Narang
960ef14b7a
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-04-10 14:15:58 +05:30
Nabin Hait
16a5475c0c
fix: pro-rata amount for straight line method
2024-04-07 15:21:46 +05:30
Nabin Hait
8247fd1727
fix:linter issue
2024-04-07 15:18:29 +05:30
Nabin Hait
350d53dbe1
fix: depr amount pro rata and related tests
2024-04-07 14:14:13 +05:30
Nabin Hait
1276855f40
fix: Get pro-rata amount based on correct days
2024-04-07 14:14:06 +05:30
Nabin Hait
79043894b2
fix: show currency symbol in base currency in fixed asset register report
...
(cherry picked from commit 8b6220efd8 )
2024-04-02 10:27:55 +00:00
Deepesh Garg
634054c07b
Merge pull request #40430 from frappe/mergify/bp/version-15-hotfix/pr-40385
...
fix: Book depreciation until the asset disposal date and remove unwanted commits (#40385 )
2024-03-26 09:05:20 +05:30
barredterra
f0e00daa1c
refactor: usage of in_list
...
(cherry picked from commit d238751e6b )
2024-03-19 11:13:02 +00:00
Nabin Hait
2d7ff5d4cf
fix: Book depreciation until the asset disposal date and removed unwanted commits
...
(cherry picked from commit dedae4fecf )
2024-03-13 07:48:27 +00:00
mergify[bot]
7d3d2eb928
ci: add prettier to pre-commit (backport #40206 ) ( #40362 )
...
* ci: add prettier to pre-commit
(cherry picked from commit 2c16036ef3 )
* style: format js files
---------
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com >
Co-authored-by: Ankush Menat <ankush@frappe.io >
2024-03-11 10:47:18 +05:30
mergify[bot]
ee119f30fb
chore: fixed fetch from (backport #40270 ) ( #40275 )
...
chore: fixed fetch from (#40270 )
(cherry picked from commit 34051bc04f )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-03-05 14:32:36 +05:30
mergify[bot]
9d19ec43c8
fix: Data too long for column 'serial_no' at row 1 (backport #40098 ) ( #40139 )
...
* fix: Data too long for column 'serial_no' at row 1 (#40098 )
(cherry picked from commit 08caa7cfa1 )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-26 23:00:01 +05:30
Nabin Hait
692867427c
fix: resolved conflict
2024-02-21 11:38:21 +05:30
Nabin Hait
a0c0ab7709
fix: resolved conflict
2024-02-21 11:37:47 +05:30
Nabin Hait
8eb2f67910
fix: Issues regarding asset cancellation and deletion
...
(cherry picked from commit 17f85de6fb )
# Conflicts:
# erpnext/assets/doctype/asset/depreciation.py
# erpnext/assets/doctype/asset_capitalization/asset_capitalization.py
2024-02-21 05:45:27 +00:00
Rohit Waghchaure
a08b97e886
test: fixed test cases
...
(cherry picked from commit c1e869f040 )
2024-02-06 10:18:05 +00:00
Rohit Waghchaure
282c19e7e1
fix: use old serial / batch fields to make serial batch bundle
...
(cherry picked from commit 9fafc83632 )
2024-02-06 10:18:05 +00:00
Nabin Hait
3bdd1e9514
fix: fetch correct quantity and amount for grouped asset
...
(cherry picked from commit 06f48c678b )
2024-01-25 10:51:53 +00:00
mergify[bot]
00a3ee313b
refactor(UX): Accounts workspace cleanup (backport #39232 ) ( #39456 )
...
* refactor(UX): Accounts workspace cleanup (#39232 )
* refactor(UX): Accounts workspace cleanup
* chore: move asset workspace outside accounting
* fix: remove redundant links from parent workspace
* chore: change icons for payable & receivable workspaces
* chore: remove redundant links from subworkspaces
(cherry picked from commit 35067282cf )
* chore: fix conflicts
---------
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2024-01-19 12:40:25 +05:30
mergify[bot]
c8b3478fe1
Merge branch 'version-15-hotfix' into mergify/bp/version-15-hotfix/pr-39429
2024-01-17 16:26:04 +00:00
Nabin Hait
ff1647a1d2
fix: test for asset depreciation
2024-01-17 21:53:00 +05:30
Nabin Hait
8bc8bc1822
fix: composite asset capitalization using asset components
...
(cherry picked from commit 5df40661d2 )
2024-01-17 15:36:04 +00:00
Nabin Hait
9f86b92eb7
Merge pull request #39431 from frappe/mergify/bp/version-15-hotfix/pr-39427
...
fix: Asset module tests (backport #39427 )
2024-01-17 17:38:46 +05:30
Nabin Hait
04c8e9b355
Merge pull request #39422 from frappe/mergify/bp/version-15-hotfix/pr-39386
...
fix: Cancel asset capitalisation record on cancellation of asset and vice-versa (backport #39386 )
2024-01-17 17:33:21 +05:30
Nabin Hait
9e33216c24
fix: Asset module tests
...
(cherry picked from commit 97f69986ff )
2024-01-17 11:56:41 +00:00
Nabin Hait
011c5a69f0
fix: Cancel asset capitalisation record on cancellation of asset and vice-versa
...
(cherry picked from commit efe9f6656f )
2024-01-17 06:45:39 +00:00
Nabin Hait
e3cd35b959
fix: WDV as per IT Act: calculate yearly amount first and then split it based on months
...
(cherry picked from commit 22bd6a54b2 )
2024-01-17 06:44:26 +00:00
anandbaburajan
2448ba6bc4
fix: asset WDV depreciation calc according to IT act
...
(cherry picked from commit 026824880d )
2024-01-10 06:48:06 +00:00
Nabin Hait
f82125144a
Merge pull request #39190 from frappe/mergify/bp/version-15-hotfix/pr-39163
...
fix: Purchase information is not required for creating a composite asset (backport #39163 )
2024-01-10 12:15:02 +05:30
Nabin Hait
afefae08af
fix: Resolved conflict
2024-01-10 11:59:54 +05:30
Nabin Hait
f0070b4046
fix: Set asset purchase amount based on qty and valuation_rate
...
(cherry picked from commit 135e19d0aa )
2024-01-10 06:03:01 +00:00
Nabin Hait
1d2e831846
fix: Introduced company field to show amounts in company currency
...
(cherry picked from commit eab22eb282 )
2024-01-08 16:09:42 +00:00
Nabin Hait
d6d54ed220
fix: Purchase date and amount is not mandatory for composite asset creation
...
(cherry picked from commit c34f09c503 )
# Conflicts:
# erpnext/assets/doctype/asset/asset.py
2024-01-08 06:53:11 +00:00
Nabin Hait
e89dce726b
fix: improved validation message
...
(cherry picked from commit fe43dab4d7 )
2024-01-08 06:53:10 +00:00
Aulia Bismar
5e4693763a
fix: Creating Asset Activity while Importing Asset ( #39113 )
...
* fix: import asset not working on activity
* chore: fix linting issue in asset_activity.py
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2024-01-05 10:46:31 +05:30
mergify[bot]
a99470e017
chore: additional_asset_cost field (backport #38904 ) ( #38906 )
...
chore: additional_asset_cost field (#38904 )
(cherry picked from commit 283763dfb2 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-12-21 16:55:41 +05:30
mergify[bot]
58f1df5004
feat: total_asset_cost field (backport #38879 ) ( #38887 )
...
* feat: total_asset_cost field (#38879 )
(cherry picked from commit d370c60a6c )
# Conflicts:
# erpnext/patches.txt
* chore: resolve conflicts
* chore: remove unnecessary patch
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-12-20 22:47:48 +05:30
mergify[bot]
2bd96713db
fix: 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 (backport #38696 ) ( #38703 )
...
fix: 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 (#38696 )
fix: 1st row value of asset put to less than 180 days acc. to IT S. 32
(cherry picked from commit e7984b3ef9 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-12-12 21:09:38 +05:30
mergify[bot]
5e6a4d257e
feat: enable automatic type annotations (backport #38452 ) ( #38454 )
...
feat: enable automatic type annotations (#38452 )
(cherry picked from commit 63313eef6f )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-11-30 14:43:16 +05:30
Gursheen Anand
de7e1ab237
fix: set cwip account before asset tests
...
(cherry picked from commit ef8e4191cd )
2023-11-29 13:24:56 +00:00
mergify[bot]
12ad1ec71a
feat: shift depreciation for assets (backport #38327 ) ( #38417 )
...
feat: shift depreciation for assets (#38327 )
* feat: shift depreciation for assets
* chore: create new asset depr schedule on shift change
* refactor: move create_depr_schedule to after_insert
* fix: args in get_depreciation_amount test
* refactor: rename shift adjustment to shift allocation
* chore: asset shift factor doctype and auto allocate shift diff
* chore: use check instead of depr type, and add tests
* chore: make linter happy
* chore: give permissions to accounts users
(cherry picked from commit fe5fc5bd3a )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-11-29 12:15:53 +05:30
mergify[bot]
b9f26ae849
fix: debit credit mismatch in multi-currecy asset purchase receipt ( #38342 )
...
fix: debit credit mismatch in multi-currecy asset purchase receipt (#38342 )
* fix: Debit credit mimatch in multicurrecy asset purchase receipt
* test: multi currency purchase receipt
* chore: update init files
* test: roolback
(cherry picked from commit add238c892 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-11-29 09:06:34 +05:30
mergify[bot]
18613c595f
fix: don't depreciate assets with no schedule on scrapping (backport #38276 ) ( #38293 )
...
fix: don't depreciate assets with no schedule on scrapping (#38276 )
fix: don't depreciate non-depreciable assets on scrapping
(cherry picked from commit 816b1b6bd5 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-11-23 14:05:08 +05:30
mergify[bot]
99bf63ec0f
fix: set default asset quantity as 1 [dev] (backport #38223 ) ( #38226 )
...
fix: set default asset quantity as 1 [dev] (#38223 )
* fix: make default asset quantity as 1
* fix: get rate_of_depreciation from asset category for asset auto-creation
* chore: create asset depr schedules on PR submit, not asset submit
* fix: set default asset quantity as 1
* chore: move patch from v15 to v14
(cherry picked from commit 9903049c7a )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-11-20 22:49:38 +05:30
Deepesh Garg
d51237195a
fix: GL Entries for receiving non CWIP assets using Purchase Receipt ( #38123 )
...
* fix: GL Entries for receiving non CWIP assets using Purchase Receipt
* test: Update tests
2023-11-16 13:38:10 +05:30
mergify[bot]
8bc871a842
chore: change read only condition of asset quantity field (backport #38111 ) ( #38113 )
...
chore: change read only condition of asset quantity field (#38111 )
chore: change read only condition of asset quantity
(cherry picked from commit 6e0362dee8 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-11-15 18:01:33 +05:30