ruthra kumar
9836205725
fix: validation error on reconciling PE to Journals as Invoice
...
With the same exchange rate on Journal Entry and Payment Entry,
reconcilition should not post exc gain/loss journal and should not
throw validation error
(cherry picked from commit 5eeb650dfd )
2023-12-15 13:20:38 +05:30
ruthra kumar
f6c611d026
Merge pull request #38744 from ruthra-kumar/filter_error_on_reconciliation_tool
...
fix: error while filtering on name on reconciliation tool
2023-12-14 15:10:12 +05:30
ruthra kumar
30b6321fd5
fix: error while filtering on name on reconciliation tool
2023-12-14 14:28:20 +05:30
ruthra kumar
bf585de558
fix: fetch exc rate of multi currency journals
...
(cherry picked from commit 1b3ba25220 )
2023-12-14 04:06:43 +00:00
ruthra kumar
6715dd6167
Merge pull request #38677 from frappe/mergify/bp/version-14-hotfix/pr-38673
...
fix: typo in unittest (backport #38673 )
2023-12-12 17:35:16 +05:30
ruthra kumar
fa79a7cdab
refactor: add get_list for virtual child doctypes
...
(cherry picked from commit 15c90551b6 )
2023-12-12 14:51:41 +05:30
ruthra kumar
e61a12b4cb
refactor(test): update repost settings before test case
...
(cherry picked from commit acb6e8e120 )
2023-12-12 07:16:49 +00:00
ruthra kumar
4542a12787
refactor: increase limit and remove explicit call to start_repost
...
(cherry picked from commit ccff588563 )
2023-12-12 07:16:49 +00:00
ruthra kumar
f0408c89ce
refactor: remove explicit commit on repost
...
(cherry picked from commit a97b3db749 )
2023-12-12 07:16:48 +00:00
ruthra kumar
7c080bd60c
refactor(test): repost utility deletion flag test
...
(cherry picked from commit cc15f695b4 )
2023-12-12 07:16:48 +00:00
Raffael Meyer
c87a3c7793
fix: typo in unittest ( #38673 )
...
(cherry picked from commit 6ad298adfc )
2023-12-12 04:26:10 +00:00
Deepesh Garg
7813efad35
Revert "refactor: bank transaction (backport #38182 )" ( #38653 )
...
Revert "refactor: bank transaction (#38182 )"
This reverts commit a4b5fc8100 .
2023-12-10 16:29:27 +05:30
Deepesh Garg
f6fcb7ee26
Merge pull request #38571 from frappe/mergify/bp/version-14-hotfix/pr-38556
...
fix(minor): financial statements period end date (#38556 )
2023-12-06 13:45:45 +05:30
ruthra kumar
25ec1fce61
fix: sql error while filtering on finance book in GL
...
(cherry picked from commit b1d9f3132d )
2023-12-05 09:11:39 +00:00
ruthra kumar
4544727654
refactor: ingore on JE cancel as well
...
(cherry picked from commit 1a5d56977e )
2023-12-05 13:32:10 +05:30
ruthra kumar
35c06fabc5
refactor: ignore unreconcile doc on PI cancel/delete
...
(cherry picked from commit 4ca84eadb6 )
2023-12-05 06:34:13 +00:00
Gursheen Anand
cbe15e159a
fix: limit end date to current date
...
(cherry picked from commit ab6e92aae1 )
2023-12-05 05:54:12 +00:00
ruthra kumar
67f149ee06
Merge pull request #38541 from frappe/mergify/bp/version-14-hotfix/pr-38148
...
refactor: convert Payment Reconciliation to virtual doctype (backport #38148 )
2023-12-04 13:01:49 +05:30
ruthra kumar
d27e588672
chore: resolve conflicts
2023-12-04 12:21:19 +05:30
mergify[bot]
2e333e6802
fix: don't show non-stock items in Stock Analytics report (backport #38543 ) ( #38544 )
...
* fix(ux): stock-item filter for Item Code field
(cherry picked from commit ccdcb7dfcc )
* fix: don't show non-stock items in Stock Analytics report
(cherry picked from commit 01aadbef85 )
* fix: `linter`
(cherry picked from commit 15fff84bb5 )
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-12-04 12:18:31 +05:30
ruthra kumar
c349c89ae3
refactor: virtual doctype methods
...
(cherry picked from commit 9c7b19e0b7 )
2023-12-04 06:31:04 +00:00
ruthra kumar
36dc7bd55e
refactor: convert payment reconciliation tool to virtual doctype
...
(cherry picked from commit 3a51a3f37e )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.json
2023-12-04 06:31:03 +00:00
Dany Robert
1042d4cfeb
fix: exclude invoice_doctypes from party advance
...
(cherry picked from commit f34ffc2062 )
2023-12-04 05:31:28 +00:00
mergify[bot]
9f23b7e46f
fix: use predefined onload property load_after_mapping (backport #38209 ) ( #38518 )
...
Co-authored-by: Sagar Vora <sagar@resilient.tech >
fix: use predefined onload property `load_after_mapping` (#38209 )
2023-12-04 09:52:16 +05:30
ruthra kumar
419943a9d9
fix: remove hardcoded, implicit rounding loss allowance
...
(cherry picked from commit 64266c4d38 )
2023-12-03 11:14:13 +00:00
mergify[bot]
9345334196
fix: don't consider cancelled entries ( #38401 )
...
* fix: don't consider cancelled entries
(cherry picked from commit adfcdb3b65 )
* refactor: get outstanding journal entry using query builder
(cherry picked from commit ff27cccff4 )
---------
Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com >
2023-12-02 20:06:48 +05:30
Dany Robert
8d6d74c237
fix(pe): show split alert only on splitting
...
(cherry picked from commit 96b13c59c1 )
2023-12-01 07:10:29 +00:00
mergify[bot]
bec7fb5493
fix(ux): make valuation field read only when it can't be modified (backport #38450 ) ( #38463 )
...
* fix(ux): make `basic_rate` field read-only based on purpose
(cherry picked from commit abc7d30024 )
* fix(ux): make PR `rate` field read-only having PO ref
(cherry picked from commit ae294ee470 )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
* fix(ux): make PI `rate` field read-only having PR ref
(cherry picked from commit 3d4156cc7d )
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-11-30 17:32:58 +05:30
ruthra kumar
b7556f9b30
refactor: use flt on outstanding on AR/AP summary report
...
(cherry picked from commit e4bdd3a28d )
2023-11-30 16:28:13 +05:30
ruthra kumar
e8ea6022f0
refactor: pass on filter to upfront outstanding query as well
...
(cherry picked from commit cfd3230c75 )
2023-11-30 07:26:29 +00:00
ruthra kumar
2aa9171027
refactor: handle rounding loss on AR/AP reports
...
(cherry picked from commit 592ce45da7 )
2023-11-27 06:22:44 +00:00
mergify[bot]
730a3bb7ce
fix: Payment Reco Issue and chart of account importer
...
fix: Payment Reco Issue and chart of account importer
2023-11-27 10:30:46 +05:30
ruthra kumar
faf025454f
chore: resolve conflict
2023-11-27 09:08:23 +05:30
Gursheen Anand
f777d24679
fix: check reposting settings before allowing editable si
...
(cherry picked from commit 894ae1fe0f )
2023-11-27 03:35:38 +00:00
Gursheen Anand
d72fbe9125
fix: allow on submit for child table fields
...
(cherry picked from commit 5fae2f6d57 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json
2023-11-27 03:35:37 +00:00
Gursheen Anand
3ad6d0890a
fix: do not set repost flag without validating voucher
...
(cherry picked from commit ad5edbb1de )
2023-11-27 03:35:37 +00:00
Gursheen Anand
776c884403
refactor: validate reposting settings for editables inv
...
(cherry picked from commit 780b827adc )
2023-11-27 03:35:37 +00:00
mergify[bot]
a4b5fc8100
refactor: bank transaction ( #38182 )
...
refactor: bank transaction (#38182 )
(cherry picked from commit 5426b93387 )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-11-26 18:58:04 +05:30
Deepesh Garg
b0547b5619
Merge pull request #38074 from frappe/mergify/bp/version-14-hotfix/pr-37859
...
fix: `split_invoices_based_on_payment_terms` (#37859 )
2023-11-26 18:15:11 +05:30
Deepesh Garg
28b6afcb10
Merge pull request #38315 from frappe/mergify/bp/version-14-hotfix/pr-38269
...
fix: skip fixed assets in product bundle (#38269 )
2023-11-24 16:30:05 +05:30
Gursheen Kaur Anand
aea169d4d4
chore: resolve conflicts
2023-11-24 15:30:19 +05:30
Gursheen Anand
7dce68bdcc
fix: annual income and expenses in digest
...
(cherry picked from commit 52305e3000 )
# Conflicts:
# erpnext/accounts/utils.py
2023-11-24 09:51:29 +00:00
ruthra kumar
47093bebd3
refactor: update project costing based on frequency
...
(cherry picked from commit dd016e6ced )
2023-11-24 06:20:04 +00:00
ruthra kumar
a88d322e4f
perf: optimize total_purchase_cost update
...
(cherry picked from commit aa17110bde )
2023-11-24 06:20:02 +00:00
Deepesh Garg
dfdaad0111
Merge pull request #38300 from frappe/mergify/bp/version-14-hotfix/pr-38297
...
feat: add Bank Transaction to connections in Journal and Payment Entry (#38297 )
2023-11-24 10:06:59 +05:30
Gursheen Anand
e96ef7338e
fix: condition in other bundle utils
...
(cherry picked from commit 8bdb61cb87 )
2023-11-24 04:30:38 +00:00
ruthra kumar
f74132b0be
chore: speed up Purchase Invoice cancellation
...
(cherry picked from commit 1efff268b0 )
2023-11-24 04:16:22 +00:00
ruthra kumar
6353deacf0
chore: index to speed up queries on JE child table reference
...
(cherry picked from commit 24fcd67f8b )
2023-11-24 04:16:21 +00:00
Raffael Meyer
2293696ab4
chore: resolve conflicts
2023-11-23 15:10:29 +01:00
Raffael Meyer
06c6da5c0d
feat: add Bank Transaction to connections in Journal and Payment Entry ( #38297 )
...
* feat(Payment Entry): Bank Transaction connection
* feat(Journal Entry): Bank Transaction connection
(cherry picked from commit 3be345e605 )
# Conflicts:
# erpnext/accounts/doctype/payment_entry/payment_entry.json
2023-11-23 13:03:38 +00:00