ruthra kumar
9ffb4c5ca9
chore: resolve conflicts
2024-03-13 17:55:22 +05:30
ruthra kumar
e07f9e6754
chore: better popup message
...
(cherry picked from commit 445d2acf50 )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2024-03-13 12:08:39 +00:00
ruthra kumar
9ccc22ca61
chore: update popup message
...
(cherry picked from commit adf13a19c4 )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2024-03-13 12:08:35 +00:00
mergify[bot]
40752c1f5c
fix: conditionally apply is_group filter in accounting dimension query (backport #40414 ) ( #40416 )
...
fix: conditionally apply `is_group` filter in accounting dimension query (#40414 )
(cherry picked from commit daf4ae2a6b )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2024-03-12 20:45:31 +05:30
mergify[bot]
32660abdc8
fix: Use serial/batch fields for delivery note return (backport #40374 ) ( #40376 )
...
fix: Use serial/batch fields for delivery note return (#40374 )
fix: User serial/batch fields for delivery note return
(cherry picked from commit b9a8dd468b )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-03-11 17:27:02 +05:30
Deepesh Garg
173b3b85f6
fix: Filter for projects in Sales Cycle
...
(cherry picked from commit d0e0b66b2f )
2024-03-10 13:57:13 +00:00
ruthra kumar
d6a3b179ec
refactor(test): make sure party has USD account
...
1. Don't reset 'party_account_currency' of SO/PO upon Payment Entry
cancellation. This happens when there are no payments against a SO/PO
(cherry picked from commit e52c4c8f22 )
2024-03-10 11:09:54 +00:00
ruthra kumar
6a5a941a5a
fix: advance paid amount and ledger entries against SO/PO
...
(cherry picked from commit d9a0494fc3 )
# Conflicts:
# erpnext/accounts/utils.py
2024-03-10 11:09:53 +00:00
mergify[bot]
7ca72423b9
fix: use serial/batch field for rejected items (backport #40327 ) ( #40329 )
...
fix: use serial/batch field for rejected items (#40327 )
(cherry picked from commit 01856a6e9d )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-03-07 14:36:59 +05:30
mergify[bot]
4b15c00b11
fix: use serial batch fields for subcontracting receipt (backport #40311 ) ( #40315 )
...
fix: use serial batch fields for subcontracting receipt (#40311 )
(cherry picked from commit cef6291311 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-03-06 19:59:21 +05:30
mergify[bot]
e0e80f7eed
fix: not able to cancel purchase receipt for old subcontracting flow (backport #40298 ) ( #40302 )
...
fix: not able to cancel purchase receipt for old subcontracting flow (#40298 )
(cherry picked from commit 48da952fd7 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-03-06 13:16:57 +05:30
Gursheen Anand
6230bbc77d
fix: test for reposting pi
2024-03-04 00:18:09 +05:30
Gursheen Anand
e20c1acb6e
fix: check child rows before update
2024-03-04 00:18:09 +05:30
Gursheen Anand
a512ec7af5
refactor: better abstraction for controller code
2024-03-04 00:16:39 +05:30
ruthra kumar
e5fdca7b05
test: gain/loss on Journals against Journals
...
(cherry picked from commit 8a5078b826 )
2024-03-02 10:08:19 +00:00
ruthra kumar
9057bff786
fix: make use of 'flt' to prevent really low precision exc gain/loss
...
(cherry picked from commit 0aa72f841d )
2024-03-02 10:08:18 +00:00
ruthra kumar
23d7a1fc76
fix: include Debit To/Credit To account while fetching advance
...
(cherry picked from commit 3327599c9d )
2024-02-29 12:22:48 +00:00
ljain112
7e43f6b7e0
fix: default taxable value for item not found in item list
...
(cherry picked from commit 5885978fc2 )
2024-02-27 16:40:19 +00:00
mergify[bot]
1860399ccb
fix: use serial batch fields for packed items (backport #40140 ) ( #40142 )
...
fix: use serial batch fields for packed items (#40140 )
(cherry picked from commit bc9c480246 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-27 07:57:37 +05:30
Gursheen Kaur Anand
e4baacd79e
Merge pull request #40066 from frappe/mergify/bp/version-15-hotfix/pr-40040
...
fix: skip max discount validation for rate adjustment (backport #40040 )
2024-02-23 15:10:38 +05:30
Gursheen Anand
3b96aaeead
fix: skip max discount validation for rate adjustment
...
(cherry picked from commit 5a3b133d65 )
2024-02-23 07:28:37 +00:00
Gursheen Anand
a75a69a01e
fix: only check for delinked PLEs
...
(cherry picked from commit 146c5b3e16 )
2024-02-23 07:10:08 +00:00
Gursheen Anand
190bd45bd7
fix: delete PLE containing invoice in against
...
(cherry picked from commit c1e1fd8829 )
2024-02-23 07:10:08 +00:00
ruthra kumar
b40baf5e63
refactor: skip popup for POS invoices
...
(cherry picked from commit 3634c4c284 )
2024-02-23 00:33:08 +00:00
Nabin Hait
8eb2f67910
fix: Issues regarding asset cancellation and deletion
...
(cherry picked from commit 17f85de6fb )
# Conflicts:
# erpnext/assets/doctype/asset/depreciation.py
# erpnext/assets/doctype/asset_capitalization/asset_capitalization.py
2024-02-21 05:45:27 +00:00
mergify[bot]
2ee51d36ff
fix: set batch created from bundle to batch field in stock transaction (backport #39966 ) ( #39987 )
...
fix: set batch created from bundle to batch field in stock transaction (#39966 )
* fix: set batch created from bundle to batch field in stock transaction
* fix: validation for serial and batch no
(cherry picked from commit 4b24fcd221 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-21 00:04:01 +05:30
mergify[bot]
acd2e93f8c
fix: do not empty serial batch fields (backport #39948 ) ( #39956 )
...
fix: do not empty serial batch fields (#39948 )
(cherry picked from commit a4cbfabe0e )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-19 10:45:28 +05:30
ruthra kumar
ce11180793
refactor: use popup to inform on additional reconciliation step
...
(cherry picked from commit 0d260faa00 )
2024-02-19 07:31:33 +05:30
Rohit Waghchaure
37329469c3
fix: not able to make purchase receipt
...
(cherry picked from commit 2fb0499923 )
2024-02-15 12:04:49 +00:00
mergify[bot]
a548f12941
fix: landed cost voucher not submitting because of incorrect reference (backport #39898 ) ( #39900 )
...
fix: landed cost voucher not submitting because of incorrect reference (#39898 )
(cherry picked from commit 6239fd704b )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-14 15:57:40 +05:30
mergify[bot]
f08b424972
fix: use correct field name in accounts controller (backport #39884 ) ( #39897 )
...
fix: use correct field name in accounts controller (#39884 )
Changes to get advance payments in SI or PI from JV's
(cherry picked from commit b124081065 )
Co-authored-by: Rohit Gunjegaonkar <135806454+rohitg-pbspl@users.noreply.github.com >
2024-02-14 13:21:55 +05:30
mergify[bot]
a2f1a964f1
fix: validate duplicate SBB (backport #39862 ) ( #39866 )
...
* fix: validate duplicate SBB
(cherry picked from commit 094ecc1f62 )
* test: duplicate SBB
(cherry picked from commit 55e66db315 )
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-02-13 09:09:03 +05:30
mergify[bot]
c643e70e2f
perf: cached get_last_purchase_details to fix performance issue (backport #39854 ) ( #39856 )
...
perf: cached get_last_purchase_details to fix performance issue (#39854 )
(cherry picked from commit b966c06a4f )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-12 15:53:50 +05:30
mergify[bot]
43fce29a04
fix: stock entry for use serial batch fields (backport #39843 ) ( #39844 )
...
fix: stock entry for use serial batch fields (#39843 )
(cherry picked from commit e5824fc3f1 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-11 11:28:48 +05:30
ruthra kumar
83bf2c17e0
refactor(test): Forex Credit Note cancellation against Invoice
...
(cherry picked from commit 2f676ced5c )
2024-02-07 15:00:48 +00:00
ruthra kumar
5fd4ca56f5
refactor: cancel Cr/Dr JE's on Sales/Purchase return cancel
...
(cherry picked from commit 0549535603 )
2024-02-07 15:00:45 +00:00
Rohit Waghchaure
73618f0605
test: test case to check use serial / batch fields feature
...
(cherry picked from commit 01650120d4 )
2024-02-06 10:18:06 +00:00
Rohit Waghchaure
a08b97e886
test: fixed test cases
...
(cherry picked from commit c1e869f040 )
2024-02-06 10:18:05 +00:00
Rohit Waghchaure
282c19e7e1
fix: use old serial / batch fields to make serial batch bundle
...
(cherry picked from commit 9fafc83632 )
2024-02-06 10:18:05 +00:00
mergify[bot]
53992deb10
fix: show warehouse title field in sales docs (backport #39746 ) ( #39755 )
...
fix: show warehouse title field in sales docs
(cherry picked from commit ee14faaa39 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-02-06 12:45:37 +05:30
mergify[bot]
f246684694
fix: remove applied pricing rule on qty change (backport #39688 ) ( #39737 )
...
fix: remove pricing rule
(cherry picked from commit 7c6a5a0f23 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-02-05 16:09:00 +05:30
Rohit Waghchaure
1b2831bdfe
perf: timeout for auto material request through reorder level
...
(cherry picked from commit 951023f434 )
2024-02-05 06:10:56 +00:00
mergify[bot]
d7c7748c03
fix: fetch/change tax template on basis of base_net_rate instead of net_rate ( #39448 )
...
fix: fetch/change tax template on basis of base_net_rate instead of net_rate (#39448 )
fix: change tax template on basis of base_net_rate instead of net_rate
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit e9fe10c6f1 )
Co-authored-by: Divyam Mistry <73271406+divyam-mistry@users.noreply.github.com >
2024-02-03 09:09:59 +05:30
ruthra kumar
10fcf5af5f
refactor: prevent '{debit/credit}_to' account mismatch
...
(cherry picked from commit 6f2fae1b61 )
2024-01-30 05:31:52 +00:00
mergify[bot]
e4230cf6d9
feat: Partly billed status in Purchase Receipt ( #39543 )
...
feat: Partly billed status in Purchase Receipt (#39543 )
(cherry picked from commit a673220feb )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2024-01-29 22:41:09 +05:30
mergify[bot]
960443d268
fix: not able to submit subcontracting pr (old flow) (backport #39622 ) ( #39625 )
...
fix: not able to submit subcontracting pr (old flow) (#39622 )
(cherry picked from commit 5cf47ae5f9 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-01-29 21:22:21 +05:30
mergify[bot]
a118417645
refactor: provision to filter on dimensions in reconciliation tool ( #39054 )
...
* refactor: dimensions section in allocation table in reconciliation
(cherry picked from commit 1cde804c77 )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json
* refactor: update dimension doctypes in hooks
(cherry picked from commit cfb3d87267 )
* refactor: dimensions filter section in payment reconciliation
(cherry picked from commit 20e0acc20a )
* refactor: column break in dimension section
(cherry picked from commit 20576e0f47 )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json
* refactor: handle dimension filters
(cherry picked from commit c1fe4bcc64 )
* refactor: pass dimension filters to query
(cherry picked from commit ff60ec85b8 )
* refactor: set query filters for dimensions
(cherry picked from commit ad8475cb8b )
* refactor: pass dimension details to query
(cherry picked from commit 5dc22e1811 )
* refactor: replace sql with query builder for Jourals query
(cherry picked from commit 9c5a79209e )
* refactor: partial change on outstanding invoice popup
(cherry picked from commit 2154502955 )
* fix: typo's and parameter changes
(cherry picked from commit 0ec17590ae )
* refactor: Credit Note and its Exc gain/loss JE inherits dimensions
(cherry picked from commit ab939cc6e8 )
* refactor: apply dimension filters on cr/dr notes
(cherry picked from commit 188ff8cde7 )
* chore: test dimension filter output
(cherry picked from commit e3c44231ab )
* test: dimension inheritance for cr note reconciliation
(cherry picked from commit ba5a7c8cd8 )
* refactor: pass dimension values to Gain/Loss journal
(cherry picked from commit c44eb432a5 )
# Conflicts:
# erpnext/accounts/utils.py
* test: dimension inheritance in PE reconciliation
(cherry picked from commit 6148fb024b )
* refactor: pass dimensions on advance allocation
(cherry picked from commit cbd443a78a )
* test: dimension inheritance on adv allocation
(cherry picked from commit fcf4687c52 )
* refactor: dynamic dimension filters in pop up
(cherry picked from commit f8bbb0619c )
* refactor: update dimensions, only if provided
(cherry picked from commit ec0f17ca8b )
* refactor: handle dynamic dimension in order query
(cherry picked from commit 7c2cb70387 )
* chore: resolve conflicts
---------
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2024-01-28 13:50:08 +05:30
mergify[bot]
6d4ca6a1ee
fix: prevent extra transfer against inter transfer transaction (backport #39213 ) ( #39596 )
...
fix: prevent extra transfer against inter transfer transaction (#39213 )
* fix: prevent extra transfer against inter transfer transaction
* fix: internal transfer dashboard
(cherry picked from commit 8fdc244e16 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-01-27 23:25:13 +05:30
mergify[bot]
63eef680d0
fix: not able to save subcontracting purchase receipt (old flow) (backport #39590 ) ( #39592 )
...
fix: not able to save subcontracting purchase receipt (old flow) (#39590 )
(cherry picked from commit 67d828dab3 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-01-27 12:15:11 +05:30
Rohit Waghchaure
2905db19e5
fix: Item Tax template is not working for e-commerce
...
(cherry picked from commit 7d3240ae3a )
2024-01-25 06:07:23 +00:00