style: linting issue fixed

This commit is contained in:
scmmishra
2019-04-17 15:46:15 +05:30
parent 63921ebbc9
commit fed4fd0f02

View File

@@ -8,6 +8,7 @@ erpnext.SerialNoBatchSelector = Class.extend({
if (d && d.has_batch_no && (!d.batch_no || this.show_dialog)) { if (d && d.has_batch_no && (!d.batch_no || this.show_dialog)) {
this.has_batch = 1; this.has_batch = 1;
this.setup(); this.setup();
// !(this.show_dialog == false) ensures that show_dialog is implictly true, even when undefined
} else if(d && d.has_serial_no && !(this.show_dialog == false)) { } else if(d && d.has_serial_no && !(this.show_dialog == false)) {
this.has_batch = 0; this.has_batch = 0;
this.setup(); this.setup();
@@ -66,14 +67,14 @@ erpnext.SerialNoBatchSelector = Class.extend({
{ {
fieldname: 'qty', fieldname: 'qty',
fieldtype:'Float', fieldtype:'Float',
read_only: me.has_batch ? 1 : 0, read_only: me.has_batch,
label: __(me.has_batch ? 'Total Qty' : 'Qty'), label: __(me.has_batch ? 'Total Qty' : 'Qty'),
default: 0 default: 0
}, },
{ {
fieldname: 'auto_fetch_button', fieldname: 'auto_fetch_button',
fieldtype:'Button', fieldtype:'Button',
hidden: me.has_batch ? 1 : 0, hidden: me.has_batch,
label: __('Fetch based on FIFO'), label: __('Fetch based on FIFO'),
click: () => { click: () => {
let qty = this.dialog.fields_dict.qty.get_value(); let qty = this.dialog.fields_dict.qty.get_value();