From fea1ec867ed38a0bdc2da2745a6bbf8fddcaa207 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2026 19:45:16 +0000 Subject: [PATCH] refactor(queries): using `frappe.get_query` in `get_filtered_child_rows` (backport #57991) (#57993) Co-authored-by: Diptanil Saha --- erpnext/controllers/queries.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/erpnext/controllers/queries.py b/erpnext/controllers/queries.py index 981375e9f0e..ad8f069e1f1 100644 --- a/erpnext/controllers/queries.py +++ b/erpnext/controllers/queries.py @@ -996,9 +996,8 @@ def get_payment_terms_for_references(doctype, txt, searchfield, start, page_len, def get_filtered_child_rows(doctype, txt, searchfield, start, page_len, filters) -> list: table = frappe.qb.DocType(doctype) query = ( - frappe.qb.from_(table) + frappe.get_query(table, filters=filters) .select( - table.name, Concat("#", table.idx, ", ", table.item_code), ) .orderby(table.idx) @@ -1006,10 +1005,6 @@ def get_filtered_child_rows(doctype, txt, searchfield, start, page_len, filters) .limit(page_len) ) - if filters: - for field, value in filters.items(): - query = query.where(table[field] == value) - if txt: txt += "%" query = query.where(