From 686685bba0363764d2511d7d3cee01776c1003f7 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 31 May 2023 12:50:14 +0530 Subject: [PATCH 1/2] fix: use kwargs in new_doc (#35497) To handle https://github.com/frappe/frappe/pull/21190#event-9386089620 --- erpnext/controllers/accounts_controller.py | 2 +- .../patches/v13_0/copy_custom_field_filters_to_website_item.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py index 20b332e7827..707db8a6a2b 100644 --- a/erpnext/controllers/accounts_controller.py +++ b/erpnext/controllers/accounts_controller.py @@ -2444,7 +2444,7 @@ def set_order_defaults( Returns a Sales/Purchase Order Item child item containing the default values """ p_doc = frappe.get_doc(parent_doctype, parent_doctype_name) - child_item = frappe.new_doc(child_doctype, p_doc, child_docname) + child_item = frappe.new_doc(child_doctype, parent_doc=p_doc, parentfield=child_docname) item = frappe.get_doc("Item", trans_item.get("item_code")) for field in ("item_code", "item_name", "description", "item_group"): diff --git a/erpnext/patches/v13_0/copy_custom_field_filters_to_website_item.py b/erpnext/patches/v13_0/copy_custom_field_filters_to_website_item.py index e8d0b593e6f..4ad572fdb09 100644 --- a/erpnext/patches/v13_0/copy_custom_field_filters_to_website_item.py +++ b/erpnext/patches/v13_0/copy_custom_field_filters_to_website_item.py @@ -15,7 +15,7 @@ def execute(): web_item = frappe.db.get_value("Website Item", {"item_code": row.parent}) web_item_doc = frappe.get_doc("Website Item", web_item) - child_doc = frappe.new_doc(docfield.options, web_item_doc, field) + child_doc = frappe.new_doc(docfield.options, parent_doc=web_item_doc, parentfield=field) for field in ["name", "creation", "modified", "idx"]: row[field] = None From 517d8a03ec8e4b9e3767dd2c48eca22baef9112b Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Wed, 31 May 2023 14:38:37 +0530 Subject: [PATCH 2/2] chore: remove whitelisting for method not accessed from UI --- erpnext/assets/doctype/asset_category/asset_category.py | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/assets/doctype/asset_category/asset_category.py b/erpnext/assets/doctype/asset_category/asset_category.py index a4d2c82845a..2e1def98fc3 100644 --- a/erpnext/assets/doctype/asset_category/asset_category.py +++ b/erpnext/assets/doctype/asset_category/asset_category.py @@ -96,7 +96,6 @@ class AssetCategory(Document): frappe.throw(msg, title=_("Missing Account")) -@frappe.whitelist() def get_asset_category_account( fieldname, item=None, asset=None, account=None, asset_category=None, company=None ):