nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-13 18:21:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix tests failing due to dependent state (#51187)

Browse Source 
* test: Use fixture instead of hardcoded employee

* test: create user before assigning
This commit is contained in:
Ankush Menat
2025-12-18 14:43:05 +05:30
committed by GitHub
parent 9638e7ea83
commit fe66bd4dc2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/manufacturing/doctype/job_card/test_job_card.py
View File

@@ -32,10 +32,9 @@ class TestJobCard(ERPNextTestSuite):
@classmethod @classmethod
def setUpClass(cls): def setUpClass(cls):
super().setUpClass() super().setUpClass()
# used in job card time log
cls.make_employees()
def setUp(self): def setUp(self):
self.make_employees() # used in job card time log
self.make_bom_for_jc_tests() self.make_bom_for_jc_tests()
self.transfer_material_against: Literal["Work Order", "Job Card"] = "Work Order" self.transfer_material_against: Literal["Work Order", "Job Card"] = "Work Order"
self.source_warehouse = None self.source_warehouse = None
@@ -128,7 +127,7 @@ class TestJobCard(ERPNextTestSuite):
jc1 = frappe.get_last_doc("Job Card", {"work_order": self.work_order.name}) jc1 = frappe.get_last_doc("Job Card", {"work_order": self.work_order.name})
jc2 = frappe.get_last_doc("Job Card", {"work_order": wo2.name}) jc2 = frappe.get_last_doc("Job Card", {"work_order": wo2.name})
employee = "_T-Employee-00001" # from test records employee = self.employees[0].name
jc1.append( jc1.append(
"time_logs", "time_logs",

1
erpnext/support/doctype/issue/test_issue.py
View File

@@ -219,6 +219,7 @@ class TestIssue(TestSetUp):
frappe.flags.current_time = get_datetime("2021-11-01 19:00") frappe.flags.current_time = get_datetime("2021-11-01 19:00")
issue = make_issue(frappe.flags.current_time, index=1) issue = make_issue(frappe.flags.current_time, index=1)
create_user("test@admin.com")
create_communication(issue.name, "test@example.com", "Received", frappe.flags.current_time) create_communication(issue.name, "test@example.com", "Received", frappe.flags.current_time)
add_assignment({"doctype": issue.doctype, "name": issue.name, "assign_to": ["test@admin.com"]}) add_assignment({"doctype": issue.doctype, "name": issue.name, "assign_to": ["test@admin.com"]})
issue.reload() issue.reload()