From fe39ce03bbb2b6419452ced07aad510b861dfa69 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Mon, 20 Oct 2025 13:16:18 +0530 Subject: [PATCH] refactor: enable legacy controller by default for pcv --- .../doctype/accounts_settings/accounts_settings.json | 4 ++-- .../test_period_closing_voucher.py | 4 ++++ erpnext/patches.txt | 1 + .../v15_0/toggle_legacy_controller_for_period_closing.py | 9 +++++++++ 4 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py diff --git a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json index f810a2073a9..64b8b27cd76 100644 --- a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json +++ b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json @@ -654,7 +654,7 @@ "label": "Use Legacy Budget Controller" }, { - "default": "0", + "default": "1", "fieldname": "use_legacy_controller_for_pcv", "fieldtype": "Check", "label": "Use Legacy Controller For Period Closing Voucher" @@ -666,7 +666,7 @@ "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2025-10-01 15:17:47.168354", + "modified": "2025-10-20 14:06:08.870427", "modified_by": "Administrator", "module": "Accounts", "name": "Accounts Settings", diff --git a/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py index b29f97beacc..e9bc137fcd4 100644 --- a/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py +++ b/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py @@ -13,6 +13,10 @@ from erpnext.accounts.utils import get_fiscal_year class TestPeriodClosingVoucher(IntegrationTestCase): + def setUp(self): + super().setUp() + frappe.db.set_single_value("Accounts Settings", "use_legacy_controller_for_pcv", 1) + def test_closing_entry(self): frappe.db.sql("delete from `tabGL Entry` where company='Test PCV Company'") frappe.db.sql("delete from `tabPeriod Closing Voucher` where company='Test PCV Company'") diff --git a/erpnext/patches.txt b/erpnext/patches.txt index e2a77df8ce0..d78481268ab 100644 --- a/erpnext/patches.txt +++ b/erpnext/patches.txt @@ -443,3 +443,4 @@ erpnext.patches.v16_0.update_serial_no_reference_name erpnext.patches.v16_0.rename_subcontracted_quantity erpnext.patches.v16_0.add_new_stock_entry_types erpnext.patches.v15_0.set_asset_status_if_not_already_set +erpnext.patches.v15_0.toggle_legacy_controller_for_period_closing diff --git a/erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py b/erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py new file mode 100644 index 00000000000..7e7cb2f7b49 --- /dev/null +++ b/erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py @@ -0,0 +1,9 @@ +import frappe + + +def execute(): + """ + Description: + Enable Legacy controller for Period Closing Voucher + """ + frappe.db.set_single_value("Accounts Settings", "use_legacy_controller_for_pcv", 1)