From fdfa60546a37ebbb7167700caa40a502b92eed44 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Mon, 19 Nov 2012 18:46:23 +0530 Subject: [PATCH] always open links embedded in knowledge base answers in new tab --- home/page/latest_updates/latest_updates.js | 5 +++-- public/js/kb_common.js | 4 +++- utilities/page/question_view/question_view.js | 4 +--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/home/page/latest_updates/latest_updates.js b/home/page/latest_updates/latest_updates.js index 16c51f5858c..38ff40f2b85 100644 --- a/home/page/latest_updates/latest_updates.js +++ b/home/page/latest_updates/latest_updates.js @@ -1,7 +1,8 @@ erpnext.updates = [ ["19th November 2012", [ - "Sales Order: Bugfix - Shipping Address should be a Link field", - "Link Fields: Search Profile, Employee and Lead using Full Names instead of ID", + "Sales Order: Bugfix - Shipping Address should be a Link field.", + "Link Fields: Search Profile, Employee and Lead using Full Names instead of ID.", + "Knowledge Base: Always open links, embedded in an answer, in a new tab." ]], ["16th November 2012", [ "Appraisal: Cleaned up form and logic. Removed complex and unnecessary approval logic, \ diff --git a/public/js/kb_common.js b/public/js/kb_common.js index 9d6b7e8e0ba..ae80acf4f8a 100644 --- a/public/js/kb_common.js +++ b/public/js/kb_common.js @@ -100,7 +100,9 @@ EditableText = function(args) { ', args)).appendTo(me.parent); this.set_display = function(txt) { - me.$w.find('.ed-text-display').html(wn.markdown(txt)); + var display_wrapper = me.$w.find('.ed-text-display'); + display_wrapper.html(wn.markdown(txt)); + display_wrapper.find("a").attr("target", "blank"); me.text = txt; } diff --git a/utilities/page/question_view/question_view.js b/utilities/page/question_view/question_view.js index 87a4422a189..3d16fa86bdc 100644 --- a/utilities/page/question_view/question_view.js +++ b/utilities/page/question_view/question_view.js @@ -183,8 +183,6 @@ KBAnswer = function(body, data, ans_list) { with_tags: 0, doctype: 'Answer' }, ans_list) - } - -wn.require('app/utilities/page/kb_common/kb_common.js'); +wn.require('app/js/kb_common.js'); \ No newline at end of file