mirror of
https://github.com/frappe/erpnext.git
synced 2026-06-08 15:42:52 +00:00
fix: review fixes
This commit is contained in:
@@ -75,7 +75,7 @@ def set_caller_information(doc, state):
|
||||
|
||||
# Contact now has all the nos saved in child table
|
||||
if doc.doctype == 'Contact':
|
||||
numbers = [nos.phone for nos in doc.phone_nos]
|
||||
numbers = [d.phone for d in doc.phone_nos]
|
||||
|
||||
for number in numbers:
|
||||
number = strip_number(number)
|
||||
|
||||
@@ -45,7 +45,7 @@ class TestOpportunity(unittest.TestCase):
|
||||
|
||||
# create new customer and create new contact against 'new.opportunity@example.com'
|
||||
customer = make_customer(opp_doc.party_name).insert(ignore_permissions=True)
|
||||
d = frappe.get_doc({
|
||||
contact = frappe.get_doc({
|
||||
"doctype": "Contact",
|
||||
"first_name": "_Test Opportunity Customer",
|
||||
"links": [{
|
||||
@@ -53,8 +53,8 @@ class TestOpportunity(unittest.TestCase):
|
||||
"link_name": customer.name
|
||||
}]
|
||||
})
|
||||
d.add_email(new_lead_email_id)
|
||||
d.insert(ignore_permissions=True)
|
||||
contact.add_email(new_lead_email_id)
|
||||
contact.insert(ignore_permissions=True)
|
||||
|
||||
opp_doc = frappe.get_doc(args).insert(ignore_permissions=True)
|
||||
self.assertTrue(opp_doc.party_name)
|
||||
|
||||
Reference in New Issue
Block a user