nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 00:44:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: update item-wise tax detail test for high conversion rates

Browse Source
This commit is contained in:
ljain112
2026-03-30 20:04:53 +05:30
parent a18196f584
commit fc8437c499
1 changed files with 32 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
erpnext/controllers/tests/test_item_wise_tax_details.py
View File

@@ -1,6 +1,6 @@
import frappe import frappe
from erpnext.tests.utils import ERPNextTestSuite from erpnext.tests.utils import ERPNextTestSuite, change_settings
class TestTaxesAndTotals(ERPNextTestSuite): class TestTaxesAndTotals(ERPNextTestSuite):
@@ -122,10 +122,22 @@ class TestTaxesAndTotals(ERPNextTestSuite):
self.assertEqual(actual_values, expected_values) self.assertEqual(actual_values, expected_values)
def test_item_wise_tax_detail_with_multi_currency(self): @change_settings("Selling Settings", {"allow_multiple_items": 1})
def test_item_wise_tax_detail_high_conversion_rate(self):
""" """
For multi-item, multi-currency invoices, item-wise tax breakup should With a high conversion rate (e.g. USD -> KRW ~1300), independently rounding
still reconcile with base tax totals. each item's base tax amount causes per-item errors that accumulate and exceed
the 0.5-unit safety threshold, raising a validation error.
Error diffusion fixes this: the cumulative base total after the last item
equals base_tax_amount_after_discount_amount exactly, so the sum of all
per-item amounts is always exact regardless of item count or rate magnitude.
Analytically with conversion_rate=1300, rate=7.77 x3 items, VAT 16%:
per-item txn tax = 1.2432
OLD independent: flt(1.2432 * 1300, 2) = 1616.16 -> sum 4848.48
expected base: flt(flt(3.7296, 2) * 1300, 0) = flt(3.73 * 1300, 0) = 4849
diff = 0.52 -> exceeds 0.5 threshold -> would throw with old code
""" """
doc = frappe.get_doc( doc = frappe.get_doc(
{ {
@@ -134,20 +146,28 @@ class TestTaxesAndTotals(ERPNextTestSuite):
"company": "_Test Company", "company": "_Test Company",
"currency": "USD", "currency": "USD",
"debit_to": "_Test Receivable USD - _TC", "debit_to": "_Test Receivable USD - _TC",
"conversion_rate": 129.99, "conversion_rate": 1300,
"items": [ "items": [
{ {
"item_code": "_Test Item", "item_code": "_Test Item",
"qty": 1, "qty": 1,
"rate": 47.41, "rate": 7.77,
"income_account": "Sales - _TC", "income_account": "Sales - _TC",
"expense_account": "Cost of Goods Sold - _TC", "expense_account": "Cost of Goods Sold - _TC",
"cost_center": "_Test Cost Center - _TC", "cost_center": "_Test Cost Center - _TC",
}, },
{ {
"item_code": "_Test Item 2", "item_code": "_Test Item",
"qty": 2, "qty": 1,
"rate": 33.33, "rate": 7.77,
"income_account": "Sales - _TC",
"expense_account": "Cost of Goods Sold - _TC",
"cost_center": "_Test Cost Center - _TC",
},
{
"item_code": "_Test Item",
"qty": 1,
"rate": 7.77,
"income_account": "Sales - _TC", "income_account": "Sales - _TC",
"expense_account": "Cost of Goods Sold - _TC", "expense_account": "Cost of Goods Sold - _TC",
"cost_center": "_Test Cost Center - _TC", "cost_center": "_Test Cost Center - _TC",
@@ -176,11 +196,11 @@ class TestTaxesAndTotals(ERPNextTestSuite):
details_by_tax = {} details_by_tax = {}
for detail in doc.item_wise_tax_details: for detail in doc.item_wise_tax_details:
bucket = details_by_tax.setdefault(detail.tax_row, {"amount": 0.0}) bucket = details_by_tax.setdefault(detail.tax_row, 0.0)
bucket["amount"] += detail.amount details_by_tax[detail.tax_row] = bucket + detail.amount
for tax in doc.taxes: for tax in doc.taxes:
self.assertEqual(details_by_tax[tax.name]["amount"], tax.base_tax_amount_after_discount_amount) self.assertEqual(details_by_tax[tax.name], tax.base_tax_amount_after_discount_amount)
def test_item_wise_tax_detail_with_multi_currency_with_single_item(self): def test_item_wise_tax_detail_with_multi_currency_with_single_item(self):
""" """