nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 07:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fetch billed PO amount

Browse Source
This commit is contained in:
ruthra kumar
2024-12-20 17:26:35 +05:30
parent 31ac9a5ea0
commit fb667f5e09
1 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
erpnext/controllers/budget_controller.py
View File

@@ -13,7 +13,10 @@ class BudgetValidation:
self.doc_date = ( self.doc_date = (
doc.get("transaction_date") if doc.get("doctype") == "Purchase Order" else doc.get("posting_date") doc.get("transaction_date") if doc.get("doctype") == "Purchase Order" else doc.get("posting_date")
) )
self.fiscal_year = get_fiscal_year(self.doc_date)[0] fy = get_fiscal_year(self.doc_date)
self.fiscal_year = fy[0]
self.fy_start_date = fy[1]
self.fy_end_date = fy[2]
self.get_dimensions() self.get_dimensions()
# When GL Map is passed, there is a possibility of multiple fiscal year. # When GL Map is passed, there is a possibility of multiple fiscal year.
# TODO: need to handle it # TODO: need to handle it
@@ -109,9 +112,33 @@ class BudgetValidation:
self.build_to_validate_map() self.build_to_validate_map()
self.validate_for_overbooking() self.validate_for_overbooking()
def get_ordered_amount(self):
items = set([x.item_code for x in self.doc.items])
exp_accounts = set([x.expense_account for x in self.doc.items])
po = qb.DocType("Purchase Order")
poi = qb.DocType("Purchase Order Item")
query = (
qb.from_(po)
.inner_join(poi)
.on(po.name == poi.parent)
.select(po.name)
.where(
po.docstatus.eq(1)
& (poi.amount > poi.billed_amt)
& po.status.ne("Closed")
& poi.item_code.isin(items)
& poi.expense_account.isin(exp_accounts)
& po.transaction_date[self.fy_start_date : self.fy_end_date]
)
)
print("Query:", query)
def validate_for_overbooking(self): def validate_for_overbooking(self):
# TODO: Need to fetch historical amount and add them to the current document # TODO: Need to fetch historical amount and add them to the current document
# TODO: handle applicable checkboxes # TODO: handle applicable checkboxes
for k, v in self.to_validate.items(): for v in self.to_validate.values():
current_amount = sum([x.amount for x in v.get("items_to_process")]) v["current_amount"] = sum([x.amount for x in v.get("items_to_process")])
print((k, v.get("budget_amount"), current_amount))
self.get_ordered_amount()