nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-13 20:05:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: validation to prevent foreign currency advance accounts in PE

Browse Source 
(cherry picked from commit e3fc5990ee)
This commit is contained in:
ruthra kumar
2024-04-18 12:24:45 +05:30
committed by Mergify
parent a8866b61a1
commit fb4a75c5aa
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/accounts/doctype/payment_entry/payment_entry.py
View File

@@ -76,6 +76,7 @@ class PaymentEntry(AccountsController):
self.setup_party_account_field() self.setup_party_account_field()
self.set_missing_values() self.set_missing_values()
self.set_liability_account() self.set_liability_account()
self.validate_advance_account_currency()
self.set_missing_ref_details(force=True) self.set_missing_ref_details(force=True)
self.validate_payment_type() self.validate_payment_type()
self.validate_party_details() self.validate_party_details()
@@ -157,6 +158,22 @@ class PaymentEntry(AccountsController):
alert=True, alert=True,
) )
def validate_advance_account_currency(self):
if self.book_advance_payments_in_separate_party_account is True:
company_currency = frappe.get_cached_value("Company", self.company, "default_currency")
if self.payment_type == "Receive" and self.paid_from_account_currency != company_currency:
frappe.throw(
_("Booking advances in foreign currency account: {0} ({1}) is not yet supported.").format(
frappe.bold(self.paid_from), frappe.bold(self.paid_from_account_currency)
)
)
if self.payment_type == "Pay" and self.paid_to_account_currency != company_currency:
frappe.throw(
_("Booking advances in foreign currency account: {0} ({1}) is not yet supported.").format(
frappe.bold(self.paid_to), frappe.bold(self.paid_to_account_currency)
)
)
def on_cancel(self): def on_cancel(self):
self.ignore_linked_doctypes = ( self.ignore_linked_doctypes = (
"GL Entry", "GL Entry",