nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-22 06:29:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #45300 from HarryPaulo/fix-prevent-commit

Browse Source 
fix: prevent unnecessary db.commit for contact insert
This commit is contained in:
ruthra kumar
2025-01-27 12:18:07 +05:30
committed by GitHub
parent 887645e55f 87de5c7450
commit fb285749dd
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/telephony/doctype/call_log/call_log.py
View File

@@ -157,6 +157,8 @@ def link_existing_conversations(doc, state):
""" """
Called from hooks on creation of Contact or Lead to link all the existing conversations. Called from hooks on creation of Contact or Lead to link all the existing conversations.
""" """
if doc.flags.ignore_auto_link_call_log:
return
if doc.doctype != "Contact": if doc.doctype != "Contact":
return return
try: try:
@@ -183,12 +185,12 @@ def link_existing_conversations(doc, state):
""", """,
dict(phone_number=f"%{number}", docname=doc.name, doctype=doc.doctype), dict(phone_number=f"%{number}", docname=doc.name, doctype=doc.doctype),
) )
if logs:
for log in logs: for log in logs:
call_log = frappe.get_doc("Call Log", log) call_log = frappe.get_doc("Call Log", log)
call_log.add_link(link_type=doc.doctype, link_name=doc.name) call_log.add_link(link_type=doc.doctype, link_name=doc.name)
call_log.save(ignore_permissions=True) call_log.save(ignore_permissions=True)
frappe.db.commit() frappe.db.commit()
except Exception: except Exception:
frappe.log_error(title=_("Error during caller information update")) frappe.log_error(title=_("Error during caller information update"))