nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-25 04:53:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #55835 from mihir-kandoi/codex/develop-user-disable-audit-fix

Browse Source 
fix: sync employee user status after save
This commit is contained in:
Mihir Kandoi
2026-06-13 14:49:34 +05:30
committed by GitHub
parent c933e34914 64175bdb3e
commit f7ff25d9a8
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/setup/doctype/employee/employee.py
View File

@@ -150,6 +150,9 @@ class Employee(NestedSet):
) )
def validate_user_details(self): def validate_user_details(self):
if not self.user_id:
return
self.validate_for_enabled_user_id() self.validate_for_enabled_user_id()
self.validate_duplicate_user_id() self.validate_duplicate_user_id()
@@ -172,6 +175,7 @@ class Employee(NestedSet):
if self.user_id: if self.user_id:
self.update_user() self.update_user()
self.update_user_permissions() self.update_user_permissions()
self.update_user_status()
self.reset_employee_emails_cache() self.reset_employee_emails_cache()
def before_insert(self): def before_insert(self):
@@ -293,10 +297,18 @@ class Employee(NestedSet):
if not frappe.db.exists("User", self.user_id): if not frappe.db.exists("User", self.user_id):
frappe.throw(_("User {0} does not exist").format(self.user_id)) frappe.throw(_("User {0} does not exist").format(self.user_id))
def update_user_status(self):
if not self.user_id:
return
if not self.has_value_changed("status") and not self.has_value_changed("user_id"):
return
user = frappe.get_doc("User", self.user_id) user = frappe.get_doc("User", self.user_id)
enabled = user.enabled enabled = user.enabled
if self.status != "Active" and enabled or self.status == "Active" and enabled == 0: if self.status != "Active" and enabled or self.status == "Active" and enabled == 0:
user.enabled = not enabled user.enabled = not enabled
# Keep linked User status in sync from the Employee lifecycle and record the audit log.
user.save(ignore_permissions=True) user.save(ignore_permissions=True)
def validate_duplicate_user_id(self): def validate_duplicate_user_id(self):