nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-08 23:52:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(supplier_scorecard):replace sql with orm (#55161)

Browse Source
This commit is contained in:
Loic Oberle
2026-05-22 12:41:04 +02:00
committed by GitHub
parent 30ba93fb8f
commit f5899b5519
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
View File

@@ -89,19 +89,11 @@ class SupplierScorecard(Document):
throw(_("Criteria weights must add up to 100%")) throw(_("Criteria weights must add up to 100%"))
def calculate_total_score(self): def calculate_total_score(self):
scorecards = frappe.db.sql( scorecards = frappe.get_all(
""" "Supplier Scorecard Period",
SELECT fields=["name"],
scp.name filters={"scorecard": self.name, "docstatus": 1},
FROM order_by="end_date desc",
`tabSupplier Scorecard Period` scp
WHERE
scp.scorecard = %(sc)s
AND scp.docstatus = 1
ORDER BY
scp.end_date DESC""",
{"sc": self.name},
as_dict=1,
) )
period = 0 period = 0