nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-14 12:25:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: validation for difference account

Browse Source 
(cherry picked from commit fb819c558e)
This commit is contained in:
Rohit Waghchaure
2025-05-02 14:27:53 +05:30
committed by Mergify
parent 035394ae6a
commit f4a43d07b0
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
erpnext/stock/doctype/stock_entry/stock_entry.py
View File

@@ -503,17 +503,29 @@ class StockEntry(StockController):
).format(frappe.bold(self.company)) ).format(frappe.bold(self.company))
) )
elif ( acc_details = frappe.get_cached_value(
self.is_opening == "Yes" "Account",
and frappe.db.get_value("Account", d.expense_account, "report_type") == "Profit and Loss" d.expense_account,
): ["account_type", "report_type"],
as_dict=True,
)
if self.is_opening == "Yes" and acc_details.report_type == "Profit and Loss":
frappe.throw( frappe.throw(
_( _(
"Difference Account must be a Asset/Liability type account, since this Stock Entry is an Opening Entry" "Difference Account must be a Asset/Liability type account (Temporary Opening), since this Stock Entry is an Opening Entry"
), ),
OpeningEntryAccountError, OpeningEntryAccountError,
) )
if acc_details.account_type == "Stock":
frappe.throw(
_(
"At row {0}: the Difference Account must not be a Stock type account, please change the Account Type for the account {1} or select a different account"
).format(d.idx, get_link_to_form("Account", d.expense_account)),
OpeningEntryAccountError,
)
def validate_warehouse(self): def validate_warehouse(self):
"""perform various (sometimes conditional) validations on warehouse""" """perform various (sometimes conditional) validations on warehouse"""