diff --git a/erpnext/accounts/doctype/gl_entry/gl_entry.py b/erpnext/accounts/doctype/gl_entry/gl_entry.py index 2243420f13c..89b184e89d0 100644 --- a/erpnext/accounts/doctype/gl_entry/gl_entry.py +++ b/erpnext/accounts/doctype/gl_entry/gl_entry.py @@ -7,7 +7,7 @@ from frappe import _ from frappe.model.document import Document from frappe.model.meta import get_field_precision from frappe.model.naming import set_name_from_naming_options -from frappe.utils import flt, fmt_money, now +from frappe.utils import create_batch, flt, fmt_money, now import erpnext from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import ( @@ -451,12 +451,15 @@ def rename_gle_sle_docs(): def rename_temporarily_named_docs(doctype): """Rename temporarily named docs using autoname options""" docs_to_rename = frappe.get_all(doctype, {"to_rename": "1"}, order_by="creation", limit=50000) - for doc in docs_to_rename: - oldname = doc.name - set_name_from_naming_options(frappe.get_meta(doctype).autoname, doc) - newname = doc.name - frappe.db.sql( - f"UPDATE `tab{doctype}` SET name = %s, to_rename = 0, modified = %s where name = %s", - (newname, now(), oldname), - auto_commit=True, - ) + autoname = frappe.get_meta(doctype).autoname + + for batch in create_batch(docs_to_rename, 100): + for doc in batch: + oldname = doc.name + set_name_from_naming_options(autoname, doc) + newname = doc.name + frappe.db.sql( + f"UPDATE `tab{doctype}` SET name = %s, to_rename = 0, modified = %s where name = %s", + (newname, now(), oldname), + ) + frappe.db.commit()