From f44f23a25def75043584937602bc7f6839e1cbc7 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Fri, 24 Apr 2026 11:40:18 +0530 Subject: [PATCH] fix: tests --- .../test_subcontracting_receipt.py | 34 ++++++++----------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/erpnext/subcontracting/doctype/subcontracting_receipt/test_subcontracting_receipt.py b/erpnext/subcontracting/doctype/subcontracting_receipt/test_subcontracting_receipt.py index d7b4bca0182..c5cffc34602 100644 --- a/erpnext/subcontracting/doctype/subcontracting_receipt/test_subcontracting_receipt.py +++ b/erpnext/subcontracting/doctype/subcontracting_receipt/test_subcontracting_receipt.py @@ -25,6 +25,10 @@ from erpnext.controllers.tests.test_subcontracting_controller import ( set_backflush_based_on, ) from erpnext.manufacturing.doctype.production_plan.test_production_plan import make_bom +from erpnext.stock.doctype.inventory_dimension.test_inventory_dimension import ( + create_inventory_dimension, + prepare_test_data, +) from erpnext.stock.doctype.item.test_item import make_item from erpnext.stock.doctype.purchase_receipt.test_purchase_receipt import get_gl_entries from erpnext.stock.doctype.serial_and_batch_bundle.test_serial_and_batch_bundle import ( @@ -44,6 +48,17 @@ from erpnext.subcontracting.doctype.subcontracting_receipt.subcontracting_receip class TestSubcontractingReceipt(FrappeTestCase): + @classmethod + def setUpClass(cls): + prepare_test_data() + create_inventory_dimension( + apply_to_all_doctypes=1, + dimension_name="Inv Site", + reference_document="Inv Site", + document_type="Inv Site", + ) + return super().setUpClass() + def setUp(self): make_subcontracted_items() make_raw_materials() @@ -2007,22 +2022,6 @@ class TestSubcontractingReceipt(FrappeTestCase): The subcontracting controller resets the supplied items table on each save causing the inventory dimensions to be lost. This test ensures that the inventory dimensions are retained on each save. """ - from erpnext.stock.doctype.inventory_dimension.test_inventory_dimension import ( - create_inventory_dimension, - prepare_test_data, - ) - - prepare_test_data() - inventory_dimension = create_inventory_dimension( - apply_to_all_doctypes=1, - dimension_name="Inv Site", - reference_document="Inv Site", - document_type="Inv Site", - ) - - inventory_dimension.reqd = 1 - inventory_dimension.save() - set_backflush_based_on("BOM") sco = get_subcontracting_order() @@ -2042,9 +2041,6 @@ class TestSubcontractingReceipt(FrappeTestCase): self.assertEqual(scr.supplied_items[0].inv_site, "Site 1") - inventory_dimension.reqd = 0 - inventory_dimension.save() - def make_return_subcontracting_receipt(**args): args = frappe._dict(args)